Upload the release binary to the GitHub release

To make sure we download the correct binary from the GitHub releases,
the logic for determining the archive name now lives in a dedicated
JavaScript module that is used by both, the release process in
GitHub actions and the NPM package create-comit-app.

Author: thomaseizinger

.github/workflows/release-bin.yml

@@ -43,6 +43,31 @@ jobs:
       - name: Build ${{ matrix.os }} release binary
         run: make release
 
+      - name: Use Node.js 10.x
+        uses: actions/setup-node@v1
+        with:
+          node-version: 10.x
+
+      - name: Create archive
+        if: startsWith(github.ref, 'refs/tags/')
+        shell: bash
+        run: |
+          VERSION=$(git describe --tags)
+
+          # We need to do bash -c to make sure this also works on GitBash for Windows.
+          # GitHub actions uses GitBash for Windows if we say 'shell: bash' on a Windows executor.
+          ARCHIVE=$(bash -c "node .npm/printArchiveName.js ${VERSION}")
+
+          tar czvf ${ARCHIVE} -C target/release ${{ matrix.binary }}
+
+      - name: Upload asset to GitHub release
+        uses: softprops/action-gh-release@v1
+        if: startsWith(github.ref, 'refs/tags/')
+        with:
+          files: create-comit-app_*.tar.gz
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+
   npm_build:
     name: NPM Project
     runs-on: ubuntu-latest

.npm/download.js

@@ -1,30 +1,14 @@
 const fs = require("fs");
 const util = require("util");
-const exec = util.promisify(require("child_process").exec);
 const extract = util.promisify(require("targz").decompress);
 const axios = require("axios");
 const path = require("path");
-
-async function getSystem() {
-  const { stdout } = await exec("uname -s");
-  return stdout.trim();
-}
-
-async function getArch() {
-  const { stdout } = await exec("uname -m");
-  return stdout.trim();
-}
+const makeArchiveName = require("./makeArchiveName").default;
 
 async function download(version, binTarget) {
-  const system = await getSystem();
-  const arch = await getArch();
-  if (!version || !system || !arch) {
-    throw new Error("Could not retrieve needed information.");
-  }
-
   const targetDir = path.dirname(binTarget);
 
-  const archiveName = `create-comit-app_${version}_${system}_${arch}.tar.gz`;
+  const archiveName = makeArchiveName(version);
   const archivePath = targetDir + "/" + archiveName;
 
   if (!fs.existsSync(targetDir)) {

.npm/makeArchiveName.js

@@ -0,0 +1,8 @@
+const os = require("os");
+
+exports.default = function makeArchiveName(version) {
+  const kernel = os.type();
+  const arch = os.arch();
+
+  return `create-comit-app_${version}_${kernel}_${arch}.tar.gz`;
+};

.npm/printArchiveName.js

@@ -0,0 +1,12 @@
+const makeArchiveName = require("./makeArchiveName").default;
+
+const version = process.argv[2];
+
+if (!version) {
+  console.error("Please pass the version as the first argument.");
+  process.exit(1);
+}
+
+const archiveName = makeArchiveName(version);
+
+console.log(archiveName);