Skip to content
This repository was archived by the owner on Mar 23, 2021. It is now read-only.

Commit 3d1150b

Browse files
Make variable name clearer
1 parent 73b7815 commit 3d1150b

File tree

1 file changed

+8
-10
lines changed

1 file changed

+8
-10
lines changed

tests/new.sh

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -5,27 +5,25 @@ set -e
55
PROJECT_DIR=${0%/tests/*.sh}
66

77
CCA="${PROJECT_DIR}/target/debug/create-comit-app"
8-
9-
# Random 10 char name
10-
NAME="example-test-project"
8+
PROJECT_NAME="example-test-project"
119

1210
function clean () {
13-
rm -rf "$NAME"
11+
rm -rf "$PROJECT_NAME"
1412
}
1513

1614
## Start tests
1715
echo "Running $0"
1816

19-
$CCA new "${NAME}" > /dev/null || (echo "FAIL: Non-zero exit code returned."; clean ; exit 1;)
17+
$CCA new "${PROJECT_NAME}" > /dev/null || (echo "FAIL: Non-zero exit code returned."; clean ; exit 1;)
2018

21-
test -d "${NAME}" > /dev/null || (echo "FAIL: Project directory ${NAME} was not created."; clean; exit 1;)
19+
test -d "${PROJECT_NAME}" > /dev/null || (echo "FAIL: Project directory ${PROJECT_NAME} was not created."; clean; exit 1;)
2220

23-
test -f "${NAME}/package.json" > /dev/null || (echo "FAIL: ${NAME} project was not initialized with a package.json file."; clean; exit 1;)
21+
test -f "${PROJECT_NAME}/package.json" > /dev/null || (echo "FAIL: ${PROJECT_NAME} project was not initialized with a package.json file."; clean; exit 1;)
2422

25-
PACKAGE_JSON_PROJECT_NAME=$(cat "${NAME}/package.json" | jq .name)
26-
if [ "$PACKAGE_JSON_PROJECT_NAME" != "\"$NAME\"" ]
23+
PACKAGE_JSON_PROJECT_NAME=$(cat "${PROJECT_NAME}/package.json" | jq .name)
24+
if [ "$PACKAGE_JSON_PROJECT_NAME" != "\"$PROJECT_NAME\"" ]
2725
then
28-
echo "FAIL: Project was not properly initialized with ${NAME} in package.json."
26+
echo "FAIL: Project was not properly initialized with ${PROJECT_NAME} in package.json."
2927
clean
3028
exit 1
3129
fi

0 commit comments

Comments
 (0)