CallWrapper event methods are not executed

[NhatBangLe]

Hi team,

Currently, I am using comfyui-sdk to interact between React and ComfyUI. I have a problem with CallWrapper event methods such as: onStart, onProgress and onFinished.

Description:
I created a CallWrapper object with onPending, onStart, onProgress and onFinished implementations (just simple console.log). Subsequently, I called run() and awaited it. As a result, the created task was executed successfully in ComfyUI but I only received log from onPending.
I tried to debug at the added callback functions of those methods but I recognized that they were not executed (except onPending).

Please help me solve this issue. Thanks for your help.

Version:
comfyui-sdk: 0.2.48
ComfyUI: 0.4.70 [Desktop]
Python 3.12.11

Workflow:
test_workflow.json

[GameKit28]

I can second that this is happening to me as well. I am able to initialize the API, build the prompt, and create the call wrapper. But when I call await callWrapper.run(); the promise never resolves. I can see that my workflow is being executed successfully inside of ComfyUI and I receive the Prompt executed in N.NN seconds confirmation in the ComfyUI terminal.

Potentially related, in my web browser running the React code calling the comfyui-sdk method, I am receiving the following CORS errors:

• Access to fetch at 'http://127.0.0.1:8188/internal/logs/subscribe' from origin 'http://localhost:5173' has been blocked by CORS policy: Method PATCH is not allowed by Access-Control-Allow-Methods in preflight response.
• PATCH http://127.0.0.1:8188/internal/logs/subscribe net::ERR_FAILED
• Uncaught (in promise) TypeError: Failed to fetch at _x.fetchApi (@saintno_comfyui-sdk.js?v=e6d4b191:355:77) at _x.setTerminalSubscription (@saintno_comfyui-sdk.js?v=e6d4b191:405:42) at @saintno_comfyui-sdk.js?v=e6d4b191:524:73

I have the Port set to 8188 and the Enable CORS header set to * in the Server-Config settings.

[GameKit28]

@NhatBangLe, This is far from a proper fix, but in-case it helps unblock you, here is how I am currently working around this issue:

1. Each time I run my workflow, I first generate a unique filename for the output image: const filenamePrefix = 'output-folder/my-generated-image-' + (Math.floor(Math.random() * 1000);
2. I add an .setInputNode to my prompt builder that references the filename_prefix of my Save Image node in my workflow. In my workflow, it is node 9. I set this input param to the filenamePrefix I generated.

const workflow = new PromptBuilder(/*workflowJson*/, [/*inputs*/, "filename"],[/*outputs*/])
/*setInputNodes*/
.setInputNode("filename", "9.inputs.filename_prefix")
/*setOutputNodes*/
.input("filename", filenamePrefix)
/*other inputs*/
;

3. I run the workflow without await awaiting the result. callwrapper.run();
4. I poll every N seconds to check if the output file is where I expect in ComfyUI's output folder on the server. (I'm using the ky package to check for the presence of the file)

const outputURL = "https://server:port/path/" + filenamePrefix + "_00001_.png"; //ComfyUI appends a padded counter to each image filename. We want the first one.
const pollRateMs = 3000;

async function isImageUrlPresent(url: string): Promise<boolean> {
  return await ky
    .head(url)
    .then(
      (response) =>
        response.headers.get('content-type')?.startsWith('image/') || false
    );
}

while (true) {
  const imageHasGenerated = await isImageUrlPresent(outputUrl);
  if (imageHasGenerated) {
    //onFinished code here
    return { url: outputURL };
  }

  await new Promise((resolve) => setTimeout(resolve, pollRateMs)); // Wait before polling again
}

This workaround is far from elegant, but it has unblocked me until the team of this excellent sdk has the opportunity to address the issue.

[NhatBangLe]

@NhatBangLe, This is far from a proper fix, but in-case it helps unblock you, here is how I am currently working around this issue:

1. Each time I run my workflow, I first generate a unique filename for the output image: const filenamePrefix = 'output-folder/my-generated-image-' + (Math.floor(Math.random() * 1000);
2. I add an .setInputNode to my prompt builder that references the filename_prefix of my Save Image node in my workflow. In my workflow, it is node 9. I set this input param to the filenamePrefix I generated.

const workflow = new PromptBuilder(/*workflowJson*/, [/*inputs*/, "filename"],[/*outputs*/])
/*setInputNodes*/
.setInputNode("filename", "9.inputs.filename_prefix")
/*setOutputNodes*/
.input("filename", filenamePrefix)
/*other inputs*/
;

3. I run the workflow without await awaiting the result. callwrapper.run();
4. I poll every N seconds to check if the output file is where I expect in ComfyUI's output folder on the server. (I'm using the ky package to check for the presence of the file)

const outputURL = "https://server:port/path/" + filenamePrefix + "_00001_.png"; //ComfyUI appends a padded counter to each image filename. We want the first one.
const pollRateMs = 3000;

async function isImageUrlPresent(url: string): Promise<boolean> {
  return await ky
    .head(url)
    .then(
      (response) =>
        response.headers.get('content-type')?.startsWith('image/') || false
    );
}

while (true) {
  const imageHasGenerated = await isImageUrlPresent(outputUrl);
  if (imageHasGenerated) {
    //onFinished code here
    return { url: outputURL };
  }

  await new Promise((resolve) => setTimeout(resolve, pollRateMs)); // Wait before polling again
}

This workaround is far from elegant, but it has unblocked me until the team of this excellent sdk has the opportunity to address the issue.

Thank you so much