Building library - error

[smlkdev]

I tried to build library from the source code to debug it (npm link library to my app):

➜  comfyui-sdk git:(main) ✗ npm run build

> @saintno/comfyui-sdk@0.2.39 build
> bun build.ts

JSCompiling Building...
JSCompiling Done!
TypeCompiling Building...
src/client.ts(514,32): error TS2345: Argument of type 'Blob | Buffer<ArrayBufferLike>' is not assignable to parameter of type 'Blob'.
  Type 'Buffer<ArrayBufferLike>' is missing the following properties from type 'Blob': size, type, arrayBuffer, bytes, and 4 more.
src/client.ts(557,32): error TS2345: Argument of type 'Blob | Buffer<ArrayBufferLike>' is not assignable to parameter of type 'Blob'.
  Type 'Buffer<ArrayBufferLike>' is missing the following properties from type 'Blob': size, type, arrayBuffer, bytes, and 4 more.
18 | function checkDiagnosticsErrors(diagnostics, failMessage) {
19 |     if (diagnostics.length === 0) {
20 |         return;
21 |     }
22 |     (0, logger_1.errorLog)(ts.formatDiagnostics(diagnostics, formatDiagnosticsHost).trim());
23 |     throw new Error(failMessage);
               ^
error: Compiled with errors
      at checkDiagnosticsErrors (/Users/user123/Workspace/jp/comfyui-sdk/node_modules/dts-bundle-generator/dist/helpers/check-diagnostics-errors.js:23:11)
      at checkProgramDiagnosticsErrors (/Users/user123/Workspace/jp/comfyui-sdk/node_modules/dts-bundle-generator/dist/helpers/check-diagnostics-errors.js:15:5)
      at getDeclarationFiles (/Users/user123/Workspace/jp/comfyui-sdk/node_modules/dts-bundle-generator/dist/compile-dts.js:151:36)
      at compileDts (/Users/user123/Workspace/jp/comfyui-sdk/node_modules/dts-bundle-generator/dist/compile-dts.js:39:22)
      at generateDtsBundle (/Users/user123/Workspace/jp/comfyui-sdk/node_modules/dts-bundle-generator/dist/bundle-generator.js:14:63)
      at /Users/user123/Workspace/jp/comfyui-sdk/build.ts:41:22

Bun v1.1.42 (macOS x64)

It compiled code (.cjs.js, .esm.js, .map) to build dir but without typescript definitions.

[tctien342]

I use BunJS to compile the project, please install and use bun run build.

[smlkdev]

For me narrowing type by using instanceof does not work.

When I switch from:

comfyui-sdk/src/client.ts

Lines 510 to 514 in c84eadf

	if (file instanceof Buffer) {
	formData.append("image", new Blob([file]), fileName);
	} else {
	formData.append("image", file, fileName);
	}

to:

if (file instanceof Blob) {
  formData.append("image", file, "mask.png");
} else {
  formData.append("image", new Blob([file]), "mask.png");
}

it compiles fine

npm run build

> @saintno/comfyui-sdk@0.2.39 build
> bun build.ts

JSCompiling Building...
JSCompiling Done!
TypeCompiling Building...
TypeCompiling Done!
Build Build success, take 2738ms
Build Done!

I tried to find out why this happens, but I couldn't find an answer.

[fantik11]

Same error, @smlkdev solution doesn't help me.

$ bun build.ts
JSCompiling Building...
JSCompiling Done!
TypeCompiling Building...
src/client.ts(580,42): error TS2322: Type 'Buffer' is not assignable to type 'BlobPart'.
Type 'Buffer' is not assignable to type 'ArrayBufferView'.
Types of property 'buffer' are incompatible.
Type 'ArrayBufferLike' is not assignable to type 'ArrayBuffer'.
Type 'SharedArrayBuffer' is missing the following properties from type 'ArrayBuffer': resizable, resize, detached, transfer, transferToFixedLength
src/client.ts(623,42): error TS2322: Type 'Buffer' is not assignable to type 'BlobPart'.
Type 'Buffer' is not assignable to type 'ArrayBufferView'.
Types of property 'buffer' are incompatible.
Type 'ArrayBufferLike' is not assignable to type 'ArrayBuffer'.
Type 'SharedArrayBuffer' is missing the following properties from type 'ArrayBuffer': resizable, resize, detached, transfer, transferToFixedLength
src/client.ts(926,41): error TS2339: Property 'terminate' does not exist on type 'WebSocket'.
src/client.ts(927,32): error TS2339: Property 'terminate' does not exist on type 'WebSocket'.
18 | function checkDiagnosticsErrors(diagnostics, failMessage) {
19 | if (diagnostics.length === 0) {
20 | return;
21 | }
22 | (0, logger_1.errorLog)(ts.formatDiagnostics(diagnostics, formatDiagnosticsHost).trim());
23 | throw new Error(failMessage);

[tctien342]

@fantik11 @smlkdev please try latest commit to see if it build success with "npm".

I see that when we install packages with "npm i" but not using "bun install", the build process will be failed.

[fantik11]

@tctien342 Yes, great job! Build success with both bun and npm

bun run build
$ bun build.ts
JSCompiling Building...
JSCompiling Done!
TypeCompiling Building...
TypeCompiling Done!
Build Build success, take 5329ms
Build Done!

npm run build

> @saintno/comfyui-sdk@0.2.48 build
> bun build.ts

JSCompiling Building...
JSCompiling Done!
TypeCompiling Building...
TypeCompiling Done!
Build Build success, take 2531ms
Build Done!