Skip to content

OOM when running compile in large build #4451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
hoangmaihuy opened this issue Feb 2, 2025 · 0 comments · Fixed by #4454, #4860 or #4974 · May be fixed by #4865
Closed

OOM when running compile in large build #4451

hoangmaihuy opened this issue Feb 2, 2025 · 0 comments · Fixed by #4454, #4860 or #4974 · May be fixed by #4865
Milestone
0.12.8

Comments

@hoangmaihuy
Copy link
Contributor

As discussed in Mill's discord, I'm having OOM issue when updating Mill to version 0.12.7 and running __.compile command.
There might be some issues in #4145 as I tried Mill version 0.12.5-131-1e6358 and it's stable for my build.

Heapdump file is huge (> 7GB) so below are some heap dump and usage screenshots from VisualVM

0.12.5

Image Image Image

0.12.7

Image Image Image
@hoangmaihuy hoangmaihuy mentioned this issue Feb 2, 2025
Merged
lihaoyi pushed a commit that referenced this issue Feb 2, 2025
@hoangmaihuy
Fix transitiveCoursierProjects cause OOM on large build (#4452)
83a00c9 
Resolve #4451 

It seems that `transitiveCoursierProjects` is populated with repetitive
transitive modules, that's why it only causes problem for large build.
@lihaoyi lihaoyi mentioned this issue Feb 2, 2025
Merged
@lihaoyi lihaoyi closed this as completed in 737dec9 Feb 2, 2025
@lefou lefou added this to the 0.12.8 milestone Feb 2, 2025
alexarchambault pushed a commit to alexarchambault/mill that referenced this issue Feb 3, 2025
@lihaoyi @hoangmaihuy @alexarchambault
Fix transitiveCoursierProjects cause OOM on large build (com-lihaoy…
f540871 
…i#4452) (com-lihaoyi#4454)

Resolve com-lihaoyi#4451 

It seems that `transitiveCoursierProjects` is populated with repetitive
transitive modules, that's why it only causes problem for large build.

Please open all PRs as drafts and ensure that your fork of Mill has 
`settings/actions` / `Allow all actions and reusable workflows` enabled
to run CI on
your own fork of the Mill repo. Only once CI passes mark the PR as
`Ready for review`
and CI will run on the main Mill repo before we merge it.

Co-authored-by: Mai Huy Hoàng <hoangmaihuy@users.noreply.github.com>
gamlerhart pushed a commit to gamlerhart/mill that referenced this issue Feb 9, 2025
@lihaoyi @hoangmaihuy @gamlerhart
Fix transitiveCoursierProjects cause OOM on large build (com-lihaoy…
76a632f 
…i#4452) (com-lihaoyi#4454)

Resolve com-lihaoyi#4451 

It seems that `transitiveCoursierProjects` is populated with repetitive
transitive modules, that's why it only causes problem for large build.

Please open all PRs as drafts and ensure that your fork of Mill has 
`settings/actions` / `Allow all actions and reusable workflows` enabled
to run CI on
your own fork of the Mill repo. Only once CI passes mark the PR as
`Ready for review`
and CI will run on the main Mill repo before we merge it.

Co-authored-by: Mai Huy Hoàng <hoangmaihuy@users.noreply.github.com>
This was referenced Apr 3, 2025
Merged
Open
@lefou lefou mentioned this issue Apr 22, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.12.8
2 participants
@lefou @hoangmaihuy