Skip to content

Commit 2dc2a62

Browse files
authored
Rebootstrap on main branch targeting 0.13.x (#4848)
1 parent 3dafe8b commit 2dc2a62

File tree

18 files changed

+117
-340
lines changed

18 files changed

+117
-340
lines changed

.config/mill-version

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
0.12.10-3-7afdee-native
1+
0.13.0-M0-222-c61593-native

.github/actions/pre-build-setup/action.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -52,9 +52,9 @@ runs:
5252
- run: cat .mill-jvm-version
5353
shell: bash
5454

55-
- run: ./mill -i -k selective.prepare ${{ inputs.prepareargs }}
56-
if: ${{ (github.event_name == 'pull_request' && !contains(github.event.pull_request.labels.*.name, 'run-all-tests')) || github.repository != 'com-lihaoyi/mill' }}
57-
shell: ${{ inputs.shell }}
55+
# - run: ./mill -i -k selective.prepare ${{ inputs.prepareargs }}
56+
# if: ${{ (github.event_name == 'pull_request' && !contains(github.event.pull_request.labels.*.name, 'run-all-tests')) || github.repository != 'com-lihaoyi/mill' }}
57+
# shell: ${{ inputs.shell }}
5858

5959
- uses: actions/upload-artifact@v4.6.0
6060
with:

.github/workflows/autofix.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ jobs:
1010
- uses: sbt/setup-sbt@v1
1111

1212
- run: |
13-
./mill __.fix + mill.javalib.palantirformat.PalantirFormatModule/ + mill.scalalib.scalafmt.ScalafmtModule/ + mill.kotlinlib.ktlint.KtlintModule/
14-
./mill --meta-level 1 mill.scalalib.scalafmt.ScalafmtModule/
13+
./mill __.fix + mill.javalib.palantirformat.PalantirFormatModule/ + mill.scalalib.scalafmt.ScalafmtModule/scalafmt + mill.kotlinlib.ktlint.KtlintModule/
1514
1615
- uses: autofix-ci/action@551dded8c6cc8a1054039c8bc0b8b48c51dfc6ef

.github/workflows/pre-build.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ jobs:
3232
java-version: ${{ inputs.java-version }}
3333
shell: ${{ inputs.shell }}
3434

35-
- run: ./mill -i -k ${{ inputs.compileargs }}
35+
#- run: ./mill -i -k ${{ inputs.compileargs }}
3636

3737
- uses: actions/upload-artifact@v4.6.2
3838
with:

.github/workflows/run-tests.yml

Lines changed: 23 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -91,15 +91,15 @@ jobs:
9191
# Run these with Mill native launcher as a smoketest
9292
include:
9393
- os: ubuntu-24.04-arm
94-
millargs: "'example.thirdparty[fansi].native.server.test'"
94+
millargs: "'example.thirdparty[fansi].native.server'"
9595
java-version: 17
9696

9797
- os: macos-latest
98-
millargs: "'example.thirdparty[acyclic].native.server.test'"
98+
millargs: "'example.thirdparty[acyclic].native.server'"
9999
java-version: 11
100100

101101
- os: macos-13
102-
millargs: "'example.thirdparty[jimfs].native.server.test'"
102+
millargs: "'example.thirdparty[jimfs].native.server'"
103103
java-version: 11
104104
steps:
105105
- uses: actions/checkout@v4
@@ -150,78 +150,78 @@ jobs:
150150
install-sbt: false
151151

152152
- java-version: 17
153-
millargs: "example.javalib.__.local.server.test"
153+
millargs: "example.javalib.__.local.server"
154154
install-android-sdk: false
155155
install-sbt: false
156156

157157
- java-version: 17
158-
millargs: "example.kotlinlib.__.local.server.test"
158+
millargs: "example.kotlinlib.__.local.server"
159159
install-android-sdk: false
160160
install-sbt: false
161161

162162
# Run this one using `.native` as a smoketest. Also make sure the java-version
163163
# is the same as that used in the `build-linux` job to avoid diverging code
164164
# hashes (https://github.com/com-lihaoyi/mill/pull/4410)
165165
- java-version: 11
166-
millargs: "example.scalalib.__.native.server.test"
166+
millargs: "example.scalalib.__.native.server"
167167
install-android-sdk: false
168168
install-sbt: false
169169

170170
- java-version: 17
171-
millargs: "'example.android.__.local.server.test'"
171+
millargs: "'example.android.__.local.server'"
172172
install-android-sdk: true
173173
install-sbt: false
174174

175175
- java-version: 17
176-
millargs: "'{example,integration}.migrating.__.local.server.test'"
176+
millargs: "'{example,integration}.migrating.__.local.server'"
177177
install-android-sdk: false
178178
install-sbt: true
179179

180180
- java-version: 17
181-
millargs: "'example.{pythonlib,javascriptlib}.__.local.server.test'"
181+
millargs: "'example.{pythonlib,javascriptlib}.__.local.server'"
182182
install-android-sdk: false
183183
install-sbt: false
184184

185185
- java-version: 11
186-
millargs: "'example.thirdparty[{mockito,commons-io}].local.server.test'"
186+
millargs: "'example.thirdparty[{mockito,commons-io}].local.server'"
187187
install-android-sdk: false
188188
install-sbt: false
189189

190190
- java-version: 17
191-
millargs: "'example.thirdparty[{netty,gatling}].local.server.test'"
191+
millargs: "'example.thirdparty[{netty,gatling}].local.server'"
192192
install-android-sdk: false
193193
install-sbt: false
194194

195195
- java-version: '17'
196-
millargs: "'example.thirdparty[arrow].local.server.test'"
196+
millargs: "'example.thirdparty[arrow].local.server'"
197197
install-android-sdk: false
198198
install-sbt: false
199199

200200
- java-version: 11
201-
millargs: "'example.{cli,fundamentals,depth,extending}.__.local.server.test'"
201+
millargs: "'example.{cli,fundamentals,depth,extending}.__.local.server'"
202202
install-android-sdk: false
203203
install-sbt: false
204204

205205
- java-version: 11
206-
millargs: "'integration.{failure,feature,ide}.__.packaged.server.test'"
206+
millargs: "'integration.{failure,feature,ide}.__.packaged.server'"
207207
install-android-sdk: false
208208
install-sbt: false
209209

210210
# run this specifically in `native` mode to make sure our non-JVM native image
211211
# launcher is able to bootstrap everything necessary without a JVM installed
212212
- java-version: 17
213-
millargs: "'integration.bootstrap[no-java-bootstrap].native.server.test'"
213+
millargs: "'integration.bootstrap[no-java-bootstrap].native.server'"
214214
install-android-sdk: false
215215

216216
# These invalidation tests need to be exercised in both execution modes
217217
# to make sure they work with and without -i/--no-server being passed
218218
- java-version: 17
219-
millargs: "'integration.invalidation.__.packaged.fork.test'"
219+
millargs: "'integration.invalidation.__.packaged.fork'"
220220
install-android-sdk: false
221221
install-sbt: false
222222

223223
- java-version: 17
224-
millargs: "'integration.invalidation.__.packaged.server.test'"
224+
millargs: "'integration.invalidation.__.packaged.server'"
225225
install-android-sdk: false
226226
install-sbt: false
227227

@@ -250,23 +250,23 @@ jobs:
250250
install-sbt: false
251251

252252
- java-version: 11
253-
millargs: '"example.scalalib.{basic,publishing}.__.local.fork.test"'
253+
millargs: '"example.scalalib.{basic,publishing}.__.local.fork"'
254254
install-sbt: false
255255

256256
- java-version: 11
257-
millargs: '"example.migrating.{scalalib,javalib}.__.local.fork.test"'
257+
millargs: '"example.migrating.{scalalib,javalib}.__.local.fork"'
258258
install-sbt: true
259259

260260
- java-version: 17
261-
millargs: "'integration.{feature,failure}.__.packaged.fork.test'"
261+
millargs: "'integration.{feature,failure}.__.packaged.fork'"
262262
install-sbt: false
263263

264264
- java-version: 11 # Run this with Mill native launcher as a smoketest
265-
millargs: "'integration.invalidation.__.native.server.test'"
265+
millargs: "'integration.invalidation.__.native.server'"
266266
install-sbt: false
267267

268268
- java-version: 17
269-
millargs: "'integration.bootstrap[no-java-bootstrap].native.server.test'"
269+
millargs: "'integration.bootstrap[no-java-bootstrap].native.server'"
270270

271271
uses: ./.github/workflows/post-build-selective.yml
272272
with:
@@ -305,5 +305,4 @@ jobs:
305305
java-version: '17'
306306
buildcmd: |
307307
set -eux
308-
./mill -i mill.scalalib.scalafmt.ScalafmtModule/checkFormatAll + __.mimaReportBinaryIssues + __.fix --check + mill.javalib.palantirformat.PalantirFormatModule/ --check + mill.kotlinlib.ktlint.KtlintModule/checkFormatAll
309-
./mill -i --meta-level 1 mill.scalalib.scalafmt.ScalafmtModule/checkFormatAll
308+
./mill -i mill.scalalib.scalafmt.ScalafmtModule/scalafmt --check + __.fix --check + mill.javalib.palantirformat.PalantirFormatModule/ --check + mill.kotlinlib.ktlint.KtlintModule/checkFormatAll

build.mill

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
package build
22
// imports
3-
import com.github.lolgab.mill.mima.Mima
3+
//import com.github.lolgab.mill.mima.Mima
44
import coursier.maven.MavenRepository
55
import coursier.VersionConstraint
6-
import de.tobiasroeser.mill.vcs.version.VcsVersion
7-
import com.goyeau.mill.scalafix.ScalafixModule
6+
import mill.main.VcsVersion
7+
//import com.goyeau.mill.scalafix.ScalafixModule
88
import mill._
99
import mill.define.NamedTask
1010
import mill.main.Tasks
@@ -475,7 +475,7 @@ trait MillPublishJavaModule extends MillJavaModule with PublishModule {
475475
/**
476476
* Some custom scala settings and test convenience
477477
*/
478-
trait MillScalaModule extends ScalaModule with MillJavaModule with ScalafixModule { outer =>
478+
trait MillScalaModule extends ScalaModule with MillJavaModule /* with ScalafixModule*/ { outer =>
479479
def scalaVersion = Deps.scalaVersion
480480
def scalapVersion: T[String] = Deps.scala2Version
481481
def scalafixScalaBinaryVersion = T {
@@ -532,22 +532,22 @@ trait MillScalaModule extends ScalaModule with MillJavaModule with ScalafixModul
532532
val binaryVersion = JvmWorkerUtil.scalaBinaryVersion(sv)
533533
val hasModuleDefs = binaryVersion == "2.13" || binaryVersion == "3"
534534
super.scalacPluginIvyDeps() ++
535-
Agg.when(binaryVersion != "3")(Deps.acyclic) ++
536-
Agg.when(hasModuleDefs)(Deps.millModuledefsPlugin)
535+
Option.when(binaryVersion != "3")(Deps.acyclic) ++
536+
Option.when(hasModuleDefs)(Deps.millModuledefsPlugin)
537537
}
538538

539539
def mandatoryIvyDeps = T {
540540
val sv = scalaVersion()
541541
val binaryVersion = JvmWorkerUtil.scalaBinaryVersion(sv)
542542
val hasModuleDefs = binaryVersion == "2.13" || binaryVersion == "3"
543543
super.mandatoryIvyDeps() ++
544-
Agg.when(hasModuleDefs)(Deps.millModuledefs)
544+
Option.when(hasModuleDefs)(Deps.millModuledefs)
545545
}
546546

547547
/** Default tests module. */
548548
lazy val test: MillScalaTests = new MillScalaTests {}
549549
trait MillScalaTests extends ScalaTests with MillJavaModule with MillBaseTestsModule
550-
with ScalafixModule {
550+
/*with ScalafixModule*/ {
551551
def scalafixConfig = T { Some(T.workspace / ".scalafix.conf") }
552552
def forkArgs = super.forkArgs() ++ outer.testArgs()
553553
def moduleDeps = outer.testModuleDeps
@@ -589,7 +589,8 @@ trait MillBaseTestsModule extends TestModule {
589589
trait MillPublishScalaModule extends MillScalaModule with MillPublishJavaModule
590590

591591
/** Publishable module which contains strictly handled API. */
592-
trait MillStableScalaModule extends MillPublishScalaModule with Mima {
592+
trait MillStableScalaModule extends MillPublishScalaModule /*with Mima*/ {
593+
/*
593594
import com.github.lolgab.mill.mima._
594595
// override def mimaBinaryIssueFilters: T[Seq[ProblemFilter]] = Seq()
595596

@@ -623,7 +624,7 @@ trait MillStableScalaModule extends MillPublishScalaModule with Mima {
623624
def skipPreviousVersions: T[Seq[String]] = T {
624625
T.log.info("Skipping mima for previous versions (!!1000s of errors due to Scala 3)")
625626
mimaPreviousVersions() // T(Seq.empty[String])
626-
}
627+
}*/
627628
}
628629

629630
trait MillPublishCrossScalaModule extends MillPublishJavaModule with CrossScalaModule

0 commit comments

Comments
 (0)