Shim createMock for php7.2 compatibility

Author: Xon

tests/CredisSentinelTest.php

@@ -155,7 +155,7 @@ public function testGetHostAndPort()
       $host = 'localhost';
       $port = '123456';
 
-      $client = $this->createMock('\Credis_Client');
+      $client = $this->createMockShim('\Credis_Client');
       $sentinel = new Credis_Sentinel($client);
 
       $client->expects($this->once())->method('getHost')->willReturn($host);

tests/CredisTestCommon.php

@@ -151,10 +151,15 @@ public static function tearDownAfterClass()
         }
     }
 
+
+    //
     /**
+     * php 7.2 compat fix, as directly polyfilling for older PHPUnit causes a function signature compatibility issue
+     * This is due to the defined return type
+     *
      * Polyfill for older PHPUnit
      */
-    protected function createMock($originalClassName)
+    protected function createMockShim($originalClassName)
     {
         if (method_exists($this, 'getMock')) {
             return $this->getMock($originalClassName);
@@ -165,6 +170,7 @@ protected function createMock($originalClassName)
 
     /**
      * php 7.2 compat fix, as directly polyfilling for older PHPUnit causes a function signature compatibility issue
+     * This is due to the defined return type
      */
     public function setExpectedExceptionShim($class, $message = NULL, $code = NULL)
     {