remove unnecessary else statement

laupkram · laupkram · commit 97f61ec4f15e · 2014-09-10T13:20:37.000+08:00
I just stumbled upon the code, and this is quite not following the pattern on other functions :)
diff --git a/File.php b/File.php
@@ -404,11 +404,11 @@ protected function _path($id, $parts = false)
             $root .= $prefix . '--' . substr(md5($id), -$this->_options['hashed_directory_level']) . DIRECTORY_SEPARATOR;
             $partsArray[] = $root;
         }
-        if ($parts) {
-            return $partsArray;
-        } else {
-            return $root;
+        if ($parts){
+         return $partsArray;
         }
+        return $root;
+        
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -404,11 +404,11 @@ protected function _path($id, $parts = false)`
`404`	`404`	`$root .= $prefix . '--' . substr(md5($id), -$this->_options['hashed_directory_level']) . DIRECTORY_SEPARATOR;`
`405`	`405`	`$partsArray[] = $root;`
`406`	`406`	`}`
`407`		`- if ($parts) {`
`408`		`- return $partsArray;`
`409`		`- } else {`
`410`		`- return $root;`
	`407`	`+ if ($parts){`
	`408`	`+ return $partsArray;`
`411`	`409`	`}`
	`410`	`+ return $root;`
	`411`	`+`
`412`	`412`	`}`
`413`	`413`
`414`	`414`	`/**`