From b348854a12939b9768556a46dbc810164dd364b3 Mon Sep 17 00:00:00 2001 From: Felix Zhang Date: Fri, 18 Jul 2025 10:25:56 -0700 Subject: [PATCH 1/3] align ifram w parent --- packages/wallet-sdk/src/util/provider.ts | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/packages/wallet-sdk/src/util/provider.ts b/packages/wallet-sdk/src/util/provider.ts index 3f48532f86..e25fe66086 100644 --- a/packages/wallet-sdk/src/util/provider.ts +++ b/packages/wallet-sdk/src/util/provider.ts @@ -31,6 +31,8 @@ export interface CBWindow { top: CBWindow; ethereum?: CBInjectedProvider; coinbaseWalletExtension?: CBInjectedProvider; + ReactNativeWebView?: unknown; + __CIPHER_BRIDGE__?: unknown; } export interface CBInjectedProvider extends ProviderInterface { @@ -43,6 +45,18 @@ function getCoinbaseInjectedLegacyProvider(): CBInjectedProvider | undefined { return window.coinbaseWalletExtension; } +function alignIframeWithParentIfNeeded() { + const window = globalThis as CBWindow; + if (window !== window.top && window.top.ethereum?.isCoinbaseBrowser) { + if (window.top?.ReactNativeWebView) { + window.ReactNativeWebView = window.top.ReactNativeWebView; + } + if (window.top?.__CIPHER_BRIDGE__) { + window.__CIPHER_BRIDGE__ = window.top.__CIPHER_BRIDGE__; + } + } +} + function getInjectedEthereum(): CBInjectedProvider | undefined { try { const window = globalThis as CBWindow; @@ -68,6 +82,7 @@ export function getCoinbaseInjectedProvider({ const ethereum = getInjectedEthereum(); if (ethereum?.isCoinbaseBrowser) { + alignIframeWithParentIfNeeded(); ethereum.setAppInfo?.(appName, appLogoUrl, appChainIds, preference); return ethereum; } From 4d958b9aedaa5af74f8ae00343eb359cba777335 Mon Sep 17 00:00:00 2001 From: Spencer Stock <46308524+spencerstock@users.noreply.github.com> Date: Fri, 18 Jul 2025 14:45:11 -0600 Subject: [PATCH 2/3] Spencer/fix (#1697) * Revert "align ifram w parent" This reverts commit b348854a12939b9768556a46dbc810164dd364b3. * reorder provider preference --- packages/wallet-sdk/src/util/provider.ts | 17 +---------------- 1 file changed, 1 insertion(+), 16 deletions(-) diff --git a/packages/wallet-sdk/src/util/provider.ts b/packages/wallet-sdk/src/util/provider.ts index e25fe66086..05cef5cf03 100644 --- a/packages/wallet-sdk/src/util/provider.ts +++ b/packages/wallet-sdk/src/util/provider.ts @@ -31,8 +31,6 @@ export interface CBWindow { top: CBWindow; ethereum?: CBInjectedProvider; coinbaseWalletExtension?: CBInjectedProvider; - ReactNativeWebView?: unknown; - __CIPHER_BRIDGE__?: unknown; } export interface CBInjectedProvider extends ProviderInterface { @@ -45,22 +43,10 @@ function getCoinbaseInjectedLegacyProvider(): CBInjectedProvider | undefined { return window.coinbaseWalletExtension; } -function alignIframeWithParentIfNeeded() { - const window = globalThis as CBWindow; - if (window !== window.top && window.top.ethereum?.isCoinbaseBrowser) { - if (window.top?.ReactNativeWebView) { - window.ReactNativeWebView = window.top.ReactNativeWebView; - } - if (window.top?.__CIPHER_BRIDGE__) { - window.__CIPHER_BRIDGE__ = window.top.__CIPHER_BRIDGE__; - } - } -} - function getInjectedEthereum(): CBInjectedProvider | undefined { try { const window = globalThis as CBWindow; - return window.ethereum ?? window.top?.ethereum; + return window.top?.ethereum ?? window.ethereum; } catch { return undefined; } @@ -82,7 +68,6 @@ export function getCoinbaseInjectedProvider({ const ethereum = getInjectedEthereum(); if (ethereum?.isCoinbaseBrowser) { - alignIframeWithParentIfNeeded(); ethereum.setAppInfo?.(appName, appLogoUrl, appChainIds, preference); return ethereum; } From 19cf710adf79793a9e33a3456a01d8ffddde6b60 Mon Sep 17 00:00:00 2001 From: Felix Zhang Date: Fri, 18 Jul 2025 13:46:46 -0700 Subject: [PATCH 3/3] bump ver --- packages/wallet-sdk/package.json | 2 +- packages/wallet-sdk/src/sdk-info.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/wallet-sdk/package.json b/packages/wallet-sdk/package.json index ad29c2a01d..754801d491 100644 --- a/packages/wallet-sdk/package.json +++ b/packages/wallet-sdk/package.json @@ -1,6 +1,6 @@ { "name": "@coinbase/wallet-sdk", - "version": "4.3.6", + "version": "4.3.7", "description": "Coinbase Wallet JavaScript SDK", "keywords": [ "coinbase", diff --git a/packages/wallet-sdk/src/sdk-info.ts b/packages/wallet-sdk/src/sdk-info.ts index 17f9d13761..e68a27af1b 100644 --- a/packages/wallet-sdk/src/sdk-info.ts +++ b/packages/wallet-sdk/src/sdk-info.ts @@ -1,2 +1,2 @@ -export const VERSION = '4.3.6'; +export const VERSION = '4.3.7'; export const NAME = '@coinbase/wallet-sdk';