From 6059ea2586db828de526fbcceebc81faf6faaf42 Mon Sep 17 00:00:00 2001 From: Felix Zhang <22125939+fan-zhang-sv@users.noreply.github.com> Date: Fri, 11 Jul 2025 10:52:30 -0700 Subject: [PATCH 1/2] redirect instantly (#1688) --- .../walletlink/relay/ui/WLMobileRelayUI.ts | 21 ++++++++++--------- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/packages/wallet-sdk/src/sign/walletlink/relay/ui/WLMobileRelayUI.ts b/packages/wallet-sdk/src/sign/walletlink/relay/ui/WLMobileRelayUI.ts index 4846a4968c..82ede3cd98 100644 --- a/packages/wallet-sdk/src/sign/walletlink/relay/ui/WLMobileRelayUI.ts +++ b/packages/wallet-sdk/src/sign/walletlink/relay/ui/WLMobileRelayUI.ts @@ -1,7 +1,7 @@ +import { CBW_MOBILE_DEEPLINK_URL } from ':core/constants.js'; +import { RelayUI } from './RelayUI.js'; import { RedirectDialog } from './components/RedirectDialog/RedirectDialog.js'; import { getLocation } from './components/util.js'; -import { RelayUI } from './RelayUI.js'; -import { CBW_MOBILE_DEEPLINK_URL } from ':core/constants.js'; export class WLMobileRelayUI implements RelayUI { private readonly redirectDialog: RedirectDialog; @@ -35,16 +35,17 @@ export class WLMobileRelayUI implements RelayUI { } openCoinbaseWalletDeeplink(walletLinkUrl?: string): void { - this.redirectDialog.present({ - title: 'Redirecting to Coinbase Wallet...', - buttonText: 'Open', - onButtonClick: () => { - this.redirectToCoinbaseWallet(walletLinkUrl); - }, - }); + // redirect to coinbase wallet immediately to avoid Safari/Chrome popup(deeplink) blocking + this.redirectToCoinbaseWallet(walletLinkUrl); setTimeout(() => { - this.redirectToCoinbaseWallet(walletLinkUrl); + this.redirectDialog.present({ + title: 'Redirecting to Coinbase Wallet...', + buttonText: 'Open', + onButtonClick: () => { + this.redirectToCoinbaseWallet(walletLinkUrl); + }, + }); }, 99); } From 0cb8216db2f8f4a70c01c1e5a49351e13e6af16e Mon Sep 17 00:00:00 2001 From: Felix Zhang Date: Fri, 11 Jul 2025 11:11:00 -0700 Subject: [PATCH 2/2] version --- packages/wallet-sdk/package.json | 2 +- packages/wallet-sdk/src/sdk-info.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/wallet-sdk/package.json b/packages/wallet-sdk/package.json index 9d16916c6f..6d2fabd4e1 100644 --- a/packages/wallet-sdk/package.json +++ b/packages/wallet-sdk/package.json @@ -1,6 +1,6 @@ { "name": "@coinbase/wallet-sdk", - "version": "4.3.4", + "version": "4.3.5", "description": "Coinbase Wallet JavaScript SDK", "keywords": [ "coinbase", diff --git a/packages/wallet-sdk/src/sdk-info.ts b/packages/wallet-sdk/src/sdk-info.ts index cc6e07fcf6..03398a1205 100644 --- a/packages/wallet-sdk/src/sdk-info.ts +++ b/packages/wallet-sdk/src/sdk-info.ts @@ -1,2 +1,2 @@ -export const VERSION = '4.3.4'; +export const VERSION = '4.3.5'; export const NAME = '@coinbase/wallet-sdk';