refactor: inline rules to make it explicit

Author: coderwyd

src/configs/comments.ts

@@ -1,5 +1,4 @@
 import type { FlatESLintConfigItem } from 'eslint-define-config'
-import { OFF } from '../flags'
 import { pluginComments } from '../plugins'
 
 export const comments: FlatESLintConfigItem[] = [
@@ -8,8 +7,10 @@ export const comments: FlatESLintConfigItem[] = [
       'eslint-comments': pluginComments,
     },
     rules: {
-      ...pluginComments.configs.recommended.rules,
-      'eslint-comments/disable-enable-pair': OFF,
+      'eslint-comments/no-aggregating-enable': 'error',
+      'eslint-comments/no-duplicate-disable': 'error',
+      'eslint-comments/no-unlimited-disable': 'error',
+      'eslint-comments/no-unused-enable': 'error',
     },
   },
 ]

src/configs/jsdoc.ts

@@ -8,19 +8,25 @@ export const jsdoc: FlatESLintConfigItem[] = [
       jsdoc: pluginJsdoc,
     },
     rules: {
-      ...pluginJsdoc.configs['flat/recommended-typescript'].rules,
-      'jsdoc/check-tag-names': OFF,
-      'jsdoc/check-values': OFF,
-      'jsdoc/no-undefined-types': OFF,
-      'jsdoc/require-jsdoc': OFF,
-      'jsdoc/require-param': OFF,
-      'jsdoc/require-param-description': OFF,
-      'jsdoc/require-param-type': OFF,
-      'jsdoc/require-returns': OFF,
-      'jsdoc/require-returns-type': OFF,
-      'jsdoc/require-throws': OFF,
-      'jsdoc/require-yields': OFF,
-      'jsdoc/tag-lines': OFF,
+      'jsdoc/check-access': 'warn',
+      'jsdoc/check-alignment': 'warn',
+      'jsdoc/check-param-names': 'warn',
+      'jsdoc/check-property-names': 'warn',
+      'jsdoc/check-types': 'warn',
+      'jsdoc/empty-tags': 'warn',
+      'jsdoc/implements-on-classes': 'warn',
+      'jsdoc/multiline-blocks': 'warn',
+      'jsdoc/no-defaults': 'warn',
+      'jsdoc/no-multi-asterisks': 'warn',
+      'jsdoc/no-types': 'warn',
+      'jsdoc/require-param-name': 'warn',
+      'jsdoc/require-property': 'warn',
+      'jsdoc/require-property-description': 'warn',
+      'jsdoc/require-property-name': 'warn',
+      'jsdoc/require-returns-check': 'warn',
+      'jsdoc/require-returns-description': 'warn',
+      'jsdoc/require-yields-check': 'warn',
+      'jsdoc/valid-types': 'warn',
     },
   },
 ]

src/configs/jsonc.ts

@@ -12,16 +12,42 @@ export const jsonc: FlatESLintConfigItem[] = [
       jsonc: pluginJsonc as any,
     },
     rules: {
-      ...pluginJsonc.configs['recommended-with-jsonc'].rules as any,
       'jsonc/array-bracket-spacing': ['error', 'never'],
       'jsonc/comma-dangle': ['error', 'never'],
       'jsonc/comma-style': ['error', 'last'],
       'jsonc/indent': ['error', 2],
       'jsonc/key-spacing': ['error', { afterColon: true, beforeColon: false }],
+      'jsonc/no-bigint-literals': 'error',
+      'jsonc/no-binary-expression': 'error',
+      'jsonc/no-binary-numeric-literals': 'error',
+      'jsonc/no-dupe-keys': 'error',
+      'jsonc/no-escape-sequence-in-identifier': 'error',
+      'jsonc/no-floating-decimal': 'error',
+      'jsonc/no-hexadecimal-numeric-literals': 'error',
+      'jsonc/no-infinity': 'error',
+      'jsonc/no-multi-str': 'error',
+      'jsonc/no-nan': 'error',
+      'jsonc/no-number-props': 'error',
+      'jsonc/no-numeric-separators': 'error',
+      'jsonc/no-octal': 'error',
       'jsonc/no-octal-escape': 'error',
+      'jsonc/no-octal-numeric-literals': 'error',
+      'jsonc/no-parenthesized': 'error',
+      'jsonc/no-plus-sign': 'error',
+      'jsonc/no-regexp-literals': 'error',
+      'jsonc/no-sparse-arrays': 'error',
+      'jsonc/no-template-literals': 'error',
+      'jsonc/no-undefined-value': 'error',
+      'jsonc/no-unicode-codepoint-escapes': 'error',
+      'jsonc/no-useless-escape': 'error',
       'jsonc/object-curly-newline': ['error', { consistent: true, multiline: true }],
       'jsonc/object-curly-spacing': ['error', 'always'],
       'jsonc/object-property-newline': ['error', { allowMultiplePropertiesPerLine: true }],
+      'jsonc/quote-props': 'error',
+      'jsonc/quotes': 'error',
+      'jsonc/space-unary-ops': 'error',
+      'jsonc/valid-json-number': 'error',
+      'jsonc/vue-custom-block/no-parsing-error': 'error',
     },
   },
 ]

src/configs/markdown.ts

@@ -33,23 +33,18 @@ export function markdown(options: OptionsComponentExts = {}): FlatESLintConfigIt
         ts: pluginTs as any,
       },
       rules: {
-        ...pluginMarkdown.configs.recommended.overrides[1].rules,
-
         'antfu/no-cjs-exports': OFF,
         'antfu/no-ts-export-equal': OFF,
 
-        'import/no-unresolved': OFF,
-
+        'eol-last': OFF,
         'no-alert': OFF,
         'no-console': OFF,
-        'no-restricted-imports': OFF,
         'no-undef': OFF,
         'no-unused-expressions': OFF,
         'no-unused-vars': OFF,
 
         'node/prefer-global/process': OFF,
 
-        'ts/comma-dangle': OFF,
         'ts/consistent-type-imports': OFF,
         'ts/no-namespace': OFF,
         'ts/no-redeclare': OFF,
@@ -58,6 +53,8 @@ export function markdown(options: OptionsComponentExts = {}): FlatESLintConfigIt
         'ts/no-use-before-define': OFF,
         'ts/no-var-requires': OFF,
 
+        'unicode-bom': 'off',
+
         'unused-imports/no-unused-imports': OFF,
         'unused-imports/no-unused-vars': OFF,
       },

src/configs/stylistic.ts

@@ -1,7 +1,7 @@
 import type { FlatESLintConfigItem } from 'eslint-define-config'
 import { pluginStylistic } from '../plugins'
 
-export const javascriptStylistic: FlatESLintConfigItem[] = [
+export const stylistic: FlatESLintConfigItem[] = [
   {
     plugins: {
       style: pluginStylistic,

src/configs/typescript.ts

@@ -57,18 +57,10 @@ export function typescript(options?: OptionsComponentExts): FlatESLintConfigItem
 
         // TS
         'ts/ban-ts-comment': ['error', { 'ts-ignore': 'allow-with-description' }],
-        'ts/ban-ts-ignore': OFF,
-        'ts/consistent-indexed-object-style': OFF,
         'ts/consistent-type-definitions': ['error', 'interface'],
         'ts/consistent-type-imports': ['error', { disallowTypeAnnotations: false, prefer: 'type-imports' }],
-        'ts/explicit-function-return-type': OFF,
-        'ts/explicit-member-accessibility': OFF,
-        'ts/explicit-module-boundary-types': OFF,
-        'ts/naming-convention': OFF,
         'ts/no-dupe-class-members': 'error',
         'ts/no-dynamic-delete': OFF,
-        'ts/no-empty-function': OFF,
-        'ts/no-empty-interface': OFF,
         'ts/no-explicit-any': OFF,
         'ts/no-extra-parens': ['error', 'functions'],
         'ts/no-invalid-this': 'error',
@@ -79,7 +71,6 @@ export function typescript(options?: OptionsComponentExts): FlatESLintConfigItem
         'ts/no-require-imports': 'error',
         'ts/no-unused-vars': OFF,
         'ts/no-use-before-define': ['error', { classes: false, functions: false, variables: true }],
-        'ts/parameter-properties': OFF,
         'ts/prefer-ts-expect-error': 'error',
         'ts/triple-slash-reference': OFF,
       },

src/configs/yml.ts

@@ -13,13 +13,28 @@ export const yml: FlatESLintConfigItem[] = [
       yml: pluginYml as any,
     },
     rules: {
-      ...pluginYml.configs.standard.rules as any,
-
       'style/spaced-comment': OFF,
-      'yml/no-empty-document': OFF,
-      'yml/no-empty-mapping-value': OFF,
+
+      'yml/block-mapping': 'error',
+      'yml/block-mapping-question-indicator-newline': 'error',
+      'yml/block-sequence': 'error',
+      'yml/block-sequence-hyphen-indicator-newline': 'error',
+      'yml/flow-mapping-curly-newline': 'error',
+      'yml/flow-mapping-curly-spacing': 'error',
+      'yml/flow-sequence-bracket-newline': 'error',
+      'yml/flow-sequence-bracket-spacing': 'error',
+      'yml/indent': ['error', 2],
+      'yml/key-spacing': 'error',
+      'yml/no-empty-key': 'error',
+      'yml/no-empty-sequence-entry': 'error',
+      'yml/no-irregular-whitespace': 'error',
+      'yml/no-tab-indent': 'error',
+      'yml/plain-scalar': 'error',
 
       'yml/quotes': ['error', { avoidEscape: false, prefer: 'single' }],
+      'yml/spaced-comment': 'error',
+
+      'yml/vue-custom-block/no-parsing-error': 'error',
     },
   },
 ]

src/factory.ts

@@ -9,17 +9,16 @@ import {
   ignores,
   imports,
   javascript,
-  javascriptStylistic,
   jsdoc,
   jsonc,
   markdown,
   node,
   react,
   sortPackageJson,
   sortTsconfig,
+  stylistic,
   test,
   typescript,
-  typescriptStylistic,
   typescriptWithLanguageServer,
   unicorn,
   vue, yml,
@@ -79,9 +78,6 @@ export function coderwyd(options: OptionsConfig & FlatESLintConfigItem = {}, ...
   if (enableVue)
     componentExts.push('vue')
 
-  if (enableStylistic)
-    configs.push(javascriptStylistic)
-
   if (enableTypeScript) {
     configs.push(typescript({ componentExts }))
 
@@ -91,11 +87,11 @@ export function coderwyd(options: OptionsConfig & FlatESLintConfigItem = {}, ...
         componentExts,
       }))
     }
-
-    if (enableStylistic)
-      configs.push(typescriptStylistic)
   }
 
+  if (enableStylistic)
+    configs.push(stylistic)
+
   if (options.test ?? true)
     configs.push(test({ isInEditor }))
 
@@ -132,8 +128,10 @@ export function coderwyd(options: OptionsConfig & FlatESLintConfigItem = {}, ...
   if (Object.keys(fusedConfig).length)
     configs.push([fusedConfig])
 
-  return combine(
+  const merged = combine(
     ...configs,
     ...userConfigs,
   )
+
+  return merged
 }