From 85b4f3b84d66ee4f2d744573f485a37bb12e5f64 Mon Sep 17 00:00:00 2001 From: Rafaela Soares Date: Mon, 17 Mar 2025 15:33:23 +0000 Subject: [PATCH 1/2] clean unnecessary copy --- test/e2e/parallel/user_rolebindings_test.go | 3 --- testsupport/wait/awaitility.go | 2 -- 2 files changed, 5 deletions(-) diff --git a/test/e2e/parallel/user_rolebindings_test.go b/test/e2e/parallel/user_rolebindings_test.go index 116cccec0..44a846d38 100644 --- a/test/e2e/parallel/user_rolebindings_test.go +++ b/test/e2e/parallel/user_rolebindings_test.go @@ -114,7 +114,6 @@ func TestUserCreatingRoleBindings(t *testing.T) { }, } for k, tc := range tests { - tc := tc t.Run(k, func(t *testing.T) { // when err = clientset.Create(context.TODO(), &tc.RoleBinding) @@ -160,7 +159,6 @@ func TestUserCreatingRoleBindings(t *testing.T) { }, } for k, tc := range tests { - tc := tc t.Run(k, func(t *testing.T) { // when err = awaitilities.Host().Client.Create(context.TODO(), &tc.RoleBinding) @@ -209,7 +207,6 @@ func TestUserCreatingRoleBindings(t *testing.T) { }, } for k, tc := range tests { - tc := tc t.Run(k, func(t *testing.T) { // when err = clientset.Create(context.TODO(), &tc.RoleBinding) diff --git a/testsupport/wait/awaitility.go b/testsupport/wait/awaitility.go index f9ec5efa2..42be0cdf3 100644 --- a/testsupport/wait/awaitility.go +++ b/testsupport/wait/awaitility.go @@ -691,7 +691,6 @@ func (w *Waiter[T]) FirstThat(predicates ...assertions.Predicate[client.Object]) return false, err } for _, obj := range list.Items { - obj := obj // required due to memory aliasing until we upgrade to Go 1.22 which fixes this. object, err := w.cast(&obj) if err != nil { return false, fmt.Errorf("failed to cast the object to GVK %v: %w", w.gvk, err) @@ -718,7 +717,6 @@ func (w *Waiter[T]) FirstThat(predicates ...assertions.Predicate[client.Object]) } else { sb.WriteString("\nlisting the objects found in cluster with the differences from the expected state for each:") for _, o := range list.Items { - o := o obj, _ := w.cast(&o) key := client.ObjectKeyFromObject(obj) From a5f30dca40a94c9c12faf28c660688ade8718f81 Mon Sep 17 00:00:00 2001 From: Rafaela Soares Date: Thu, 20 Mar 2025 21:58:45 +0000 Subject: [PATCH 2/2] empty commit to trigger gh actions