diff --git a/pkg/controller/signup_test.go b/pkg/controller/signup_test.go index 12b019a6..f1449d62 100644 --- a/pkg/controller/signup_test.go +++ b/pkg/controller/signup_test.go @@ -164,6 +164,8 @@ func (s *TestSignupSuite) TestSignupGetHandler() { Status: signup.Status{ Reason: "Provisioning", }, + FamilyName: "Bar", + GivenName: "Foo", } // when diff --git a/pkg/signup/service/signup_service.go b/pkg/signup/service/signup_service.go index dda84d3b..60e37283 100644 --- a/pkg/signup/service/signup_service.go +++ b/pkg/signup/service/signup_service.go @@ -344,8 +344,10 @@ func (s *ServiceImpl) DoGetSignup(ctx *gin.Context, cl namespaced.Client, userna } signupResponse := &signup.Signup{ - Name: userSignup.GetName(), - Username: userSignup.Spec.IdentityClaims.PreferredUsername, + Name: userSignup.GetName(), + Username: userSignup.Spec.IdentityClaims.PreferredUsername, + GivenName: userSignup.Spec.IdentityClaims.GivenName, + FamilyName: userSignup.Spec.IdentityClaims.FamilyName, } if userSignup.Status.CompliantUsername != "" { signupResponse.CompliantUsername = userSignup.Status.CompliantUsername diff --git a/pkg/signup/service/signup_service_test.go b/pkg/signup/service/signup_service_test.go index ccea840d..6a91335c 100644 --- a/pkg/signup/service/signup_service_test.go +++ b/pkg/signup/service/signup_service_test.go @@ -738,6 +738,8 @@ func (s *TestSignupServiceSuite) TestGetSignupStatusOK() { require.Equal(s.T(), us.Name, response.Name) require.Equal(s.T(), username, response.Username) + require.Equal(s.T(), us.Spec.IdentityClaims.GivenName, response.GivenName) + require.Equal(s.T(), us.Spec.IdentityClaims.FamilyName, response.FamilyName) require.Equal(s.T(), "ted", response.CompliantUsername) require.Equal(s.T(), mur.Status.ProvisionedTime.UTC().Format(time.RFC3339), response.StartDate)