Pass golint

Closes #5

Author: nhooyr

ci/lint.sh

@@ -7,5 +7,4 @@ cd "$(git rev-parse --show-toplevel)"
 # shellcheck disable=SC2046
 shellcheck -x $(git ls-files "*.sh")
 go vet ./...
-# Re enable later.
-#go run golang.org/x/lint/golint -set_exit_status ./...
+go run golang.org/x/lint/golint -set_exit_status ./...

internal/skipctx/skipctx.go

@@ -9,11 +9,14 @@ import (
 
 type skipKey struct{}
 
+// With appends to the skip offset in the context and returns
+// a new context with the new skip offset.
 func With(ctx context.Context, skip int) context.Context {
 	skip += From(ctx)
 	return context.WithValue(ctx, skipKey{}, skip)
 }
 
+// From returns the skip offset.
 func From(ctx context.Context) int {
 	l, _ := ctx.Value(skipKey{}).(int)
 	return l

slog.go

@@ -4,6 +4,7 @@ import (
 	"context"
 )
 
+// Logger is the core interface for logging.
 type Logger interface {
 	// Debug means a potentially noisy log.
 	Debug(ctx context.Context, msg string, fields ...Field)
@@ -31,17 +32,26 @@ type field struct {
 	value fieldValue
 }
 
+// Field represents a log field.
 type Field interface {
 	LogKey() string
 	Value
 }
 
+// Value represents a log value.
+// The value returned will be logged.
+// Your own types can implement this interface to
+// override their logging appearance.
 type Value interface {
 	LogValue() interface{}
 }
 
+// ValueFunc is a function that computes its logging
+// representation. Use it to override the logging
+// representation of a structure inline.
 type ValueFunc func() interface{}
 
+// LogValue implements Value.
 func (fn ValueFunc) LogValue() interface{} {
 	return fn()
 }

test.go

@@ -5,10 +5,15 @@ import (
 	"testing"
 )
 
+// TestOptions represents the options for the logger returned
+// by Test.
 type TestOptions struct {
+	// IgnoreErrors causes the test logger to not fatal the test
+	// on Fatal and not error the test on Error or Critical.
 	IgnoreErrors bool
 }
 
+// Test creates a Logger that writes logs to tb.
 func Test(tb testing.TB, opts *TestOptions) Logger {
 	if opts == nil {
 		opts = &TestOptions{}