make max page size configurable initial code

Author: bcpeinhardt

api/api.go

@@ -4,6 +4,7 @@ import (
 	"encoding/json"
 	"net/http"
 	"os"
+	"strconv"
 
 	"github.com/go-chi/chi/v5"
 	"github.com/go-chi/chi/v5/middleware"
@@ -55,14 +56,16 @@ type Options struct {
 	Database database.Database
 	Logger   slog.Logger
 	// Set to <0 to disable.
-	RateLimit int
-	Storage   storage.Storage
+	RateLimit   int
+	Storage     storage.Storage
+	MaxPageSize int
 }
 
 type API struct {
-	Database database.Database
-	Handler  http.Handler
-	Logger   slog.Logger
+	Database    database.Database
+	Handler     http.Handler
+	Logger      slog.Logger
+	MaxPageSize int
 }
 
 // New creates a new API server.
@@ -84,9 +87,10 @@ func New(options *Options) *API {
 	)
 
 	api := &API{
-		Database: options.Database,
-		Handler:  r,
-		Logger:   options.Logger,
+		Database:    options.Database,
+		Handler:     r,
+		Logger:      options.Logger,
+		MaxPageSize: options.MaxPageSize,
 	}
 
 	r.Get("/", func(rw http.ResponseWriter, r *http.Request) {
@@ -163,10 +167,10 @@ func (api *API) extensionQuery(rw http.ResponseWriter, r *http.Request) {
 		})
 	}
 	for _, filter := range query.Filters {
-		if filter.PageSize < 0 || filter.PageSize > 50 {
+		if filter.PageSize < 0 || filter.PageSize > api.MaxPageSize {
 			httpapi.Write(rw, http.StatusBadRequest, httpapi.ErrorResponse{
 				Message:   "Invalid page size",
-				Detail:    "Check that the page size is between zero and fifty",
+				Detail:    "Check that the page size is between 0 and " + strconv.Itoa(api.MaxPageSize),
 				RequestID: httpmw.RequestID(r),
 			})
 		}

cli/server.go

@@ -28,6 +28,7 @@ func server() *cobra.Command {
 		extdir            string
 		repo              string
 		listcacheduration time.Duration
+		maxpagesize       int
 	)
 
 	cmd := &cobra.Command{
@@ -85,9 +86,10 @@ func server() *cobra.Command {
 
 			// Start the API server.
 			mapi := api.New(&api.Options{
-				Database: database,
-				Storage:  store,
-				Logger:   logger,
+				Database:    database,
+				Storage:     store,
+				Logger:      logger,
+				MaxPageSize: maxpagesize,
 			})
 			server := &http.Server{
 				Handler: mapi.Handler,
@@ -136,6 +138,7 @@ func server() *cobra.Command {
 	}
 
 	cmd.Flags().StringVar(&extdir, "extensions-dir", "", "The path to extensions.")
+	cmd.Flags().IntVar(&maxpagesize, "max-page-size", 50, "The maximum number of pages to request")
 	cmd.Flags().StringVar(&artifactory, "artifactory", "", "Artifactory server URL.")
 	cmd.Flags().StringVar(&repo, "repo", "", "Artifactory repository.")
 	cmd.Flags().StringVar(&address, "address", "127.0.0.1:3001", "The address on which to serve the marketplace API.")

storage/local.go

@@ -27,7 +27,7 @@ type Local struct {
 }
 
 type LocalOptions struct {
-	// How long to cache the list of extensions with their manifests.  Zero means 
+	// How long to cache the list of extensions with their manifests.  Zero means
 	// no cache.
 	ListCacheDuration time.Duration
 	ExtDir            string