refactor(zkevm): optimize the zero param opcode case (ethereum#1737)

* refactor: optimize the zero param opcode case

* fix(tests): correct parameter naming in worst compute test

* refactor: optimize gas cost for staticcall loop

Author: LouisTsai-Csie

tests/zkevm/test_worst_compute.py

@@ -42,6 +42,7 @@
 REFERENCE_SPEC_GIT_PATH = "TODO"
 REFERENCE_SPEC_VERSION = "TODO"
 
+MAX_STACK_HEIGHT = 1024
 KECCAK_RATE = 136
 
 
@@ -84,22 +85,22 @@ def make_dup(index: int) -> Opcode:
 def test_worst_zero_param(
     state_test: StateTestFiller,
     pre: Alloc,
-    fork: Fork,
     opcode: Op,
+    fork: Fork,
 ):
     """Test running a block with as many zero-parameter opcodes as possible."""
     env = Environment()
-    max_code_size = fork.max_code_size()
 
-    code_prefix = Op.JUMPDEST
-    iter_loop = Op.POP(opcode)
-    code_suffix = Op.PUSH0 + Op.JUMP
-    code_iter_len = (max_code_size - len(code_prefix) - len(code_suffix)) // len(iter_loop)
-    code = code_prefix + iter_loop * code_iter_len + code_suffix
-    assert len(code) <= max_code_size
+    opcode_sequence = opcode * MAX_STACK_HEIGHT
+    target_contract_address = pre.deploy_contract(code=opcode_sequence)
+
+    calldata = Bytecode()
+    attack_block = Op.POP(Op.STATICCALL(Op.GAS, target_contract_address, 0, 0, 0, 0))
+    code = code_loop_precompile_call(calldata, attack_block, fork)
+    code_address = pre.deploy_contract(code=code)
 
     tx = Transaction(
-        to=pre.deploy_contract(code=bytes(code)),
+        to=code_address,
         gas_limit=env.gas_limit,
         sender=pre.fund_eoa(),
     )