fix: refreshKey is evaluated ten times more frequently if sql and every are simultaneously defined (cube-js#3873)

* fix: `refreshKey` is evaluated ten times more frequently if `sql` and `every` are simultaneously defined

* chore: `refreshKey` is evaluated ten times more frequently if `sql` and `every` are simultaneously defined -- tests

Author: paveltiunov

packages/cubejs-schema-compiler/src/adapter/BaseQuery.js

@@ -2311,23 +2311,23 @@ export class BaseQuery {
     );
   }
 
-  refreshKeyRenewalThresholdForInterval(refreshKey, limitedWithMax = true) {
+  refreshKeyRenewalThresholdForInterval(refreshKey, everyWithoutSql = true) {
     const { every } = refreshKey;
 
     if (/^(\d+) (second|minute|hour|day|week)s?$/.test(every)) {
-      const threshold = Math.max(Math.round(this.parseSecondDuration(every) / 10), 1);
+      const threshold = Math.max(Math.round(this.parseSecondDuration(every) / (everyWithoutSql ? 10 : 1)), 1);
 
-      if (limitedWithMax) {
+      if (everyWithoutSql) {
         return Math.min(threshold, 300);
       }
 
       return threshold;
     }
 
     const { interval } = this.calcIntervalForCronString(refreshKey);
-    const threshold = Math.max(Math.round(interval / 10), 1);
+    const threshold = Math.max(Math.round(interval / (everyWithoutSql ? 10 : 1)), 1);
 
-    if (limitedWithMax) {
+    if (everyWithoutSql) {
       return Math.min(threshold, 300);
     }
 

packages/cubejs-schema-compiler/test/unit/base-query.test.ts

@@ -513,7 +513,7 @@ describe('SQL Generation', () => {
         [],
         {
           external: false,
-          renewalThreshold: 720,
+          renewalThreshold: 7200,
         }
       ]
     ]);
@@ -562,7 +562,7 @@ describe('SQL Generation', () => {
         {
           external: false,
           // 60 * 60 *2
-          renewalThreshold: 720,
+          renewalThreshold: 7200,
         }
       ]
     ]);