fix: Invalid identifier day for month lambdaRollup (cube-js#5338)

* fix: Invalid identifier day for month `lambdaRollup`

* chore: Invalid identifier day for month `lambdaRollup`

Author: paveltiunov

packages/cubejs-schema-compiler/src/adapter/PreAggregations.js

@@ -144,7 +144,7 @@ export class PreAggregations {
   }
 
   preAggregationDescriptionFor(cube, foundPreAggregation) {
-    const { preAggregationName, preAggregation } = foundPreAggregation;
+    const { preAggregationName, preAggregation, references } = foundPreAggregation;
 
     const tableName = this.preAggregationTableName(cube, preAggregationName, preAggregation);
     const invalidateKeyQueries = this.query.preAggregationInvalidateKeyQueries(cube, preAggregation);
@@ -185,10 +185,11 @@ export class PreAggregations {
       uniqueKeyColumns,
       aggregationsColumns,
       dataSource: queryForSqlEvaluation.dataSource,
-      granularity: preAggregation.granularity,
+      // in fact we can reference preAggregation.granularity however accessing timeDimensions is more strict and consistent
+      granularity: references.timeDimensions[0]?.granularity,
       partitionGranularity: preAggregation.partitionGranularity,
       preAggregationStartEndQueries:
-        (preAggregation.partitionGranularity || preAggregation.granularity) &&
+        (preAggregation.partitionGranularity || references.timeDimensions[0]?.granularity) &&
         this.refreshRangeQuery().preAggregationStartEndQueries(cube, preAggregation),
       matchedTimeDimensionDateRange:
         preAggregation.partitionGranularity && (
@@ -1072,7 +1073,7 @@ export class PreAggregations {
     )(this.rollupMeasures(preAggregationForQuery));
 
     // TODO granularity shouldn't be null?
-    const rollupGranularity = this.castGranularity(preAggregationForQuery.preAggregation.granularity) || 'day';
+    const rollupGranularity = preAggregationForQuery.references.timeDimensions[0]?.granularity || 'day';
 
     return this.query.evaluateSymbolSqlWithContext(
       // eslint-disable-next-line prefer-template

packages/cubejs-testing/birdbox-fixtures/lambda/schema/Orders.js

@@ -2,6 +2,12 @@ cube(`Orders`, {
   sql: `SELECT * FROM public.orders`,
 
   preAggregations: {
+    ordersByCompletedAtMonthLambda: {
+      type: `rollupLambda`,
+      rollups: [ordersByCompletedAtMonth],
+      unionWithSourceData: true,
+    },
+
     ordersByCompletedAtLambda: {
       type: `rollupLambda`,
       rollups: [ordersByCompletedAt],
@@ -18,6 +24,22 @@ cube(`Orders`, {
       unionWithSourceData: true,
     },
 
+    ordersByCompletedAtMonth: {
+      measures: [count],
+      timeDimension: completedAt,
+      granularity: `month`,
+      partitionGranularity: `month`,
+      buildRangeStart: {
+        sql: `SELECT DATE('2020-02-7')`,
+      },
+      buildRangeEnd: {
+        sql: `SELECT DATE('2020-05-7')`,
+      },
+      refreshKey: {
+        every: '1 day'
+      },
+    },
+
     ordersByCompletedAt: {
       measures: [count],
       dimensions: [status],

packages/cubejs-testing/test/smoke-lambda.test.ts

@@ -214,6 +214,49 @@ describe('lambda', () => {
     );
   });
 
+  test('query month', async () => {
+    const query: Query = {
+      measures: ['Orders.count'],
+      timeDimensions: [
+        {
+          dimension: 'Orders.completedAt',
+          granularity: 'month'
+        }
+      ],
+      order: {
+        'Orders.completedAt': 'desc',
+      },
+      limit: 3
+    };
+    const response = await client.load(query);
+
+    // @ts-ignore
+    expect(Object.keys(response.loadResponse.results[0].usedPreAggregations)).toEqual([
+      'dev_pre_aggregations.orders_orders_by_completed_at_month'
+    ]);
+
+    // With lambda-view we observe all 'fresh' data, with no partition/buildRange limit.
+    expect(response.rawData()).toEqual(
+      [
+        {
+          'Orders.completedAt': '2021-12-01T00:00:00.000',
+          'Orders.completedAt.month': '2021-12-01T00:00:00.000',
+          'Orders.count': '2',
+        },
+        {
+          'Orders.completedAt': '2021-01-01T00:00:00.000',
+          'Orders.completedAt.month': '2021-01-01T00:00:00.000',
+          'Orders.count': '127',
+        },
+        {
+          'Orders.completedAt': '2020-12-01T00:00:00.000',
+          'Orders.completedAt.month': '2020-12-01T00:00:00.000',
+          'Orders.count': '808',
+        },
+      ]
+    );
+  });
+
   test('query with 2 dimensions', async () => {
     const response = await client.load({
       measures: ['Orders.count'],