address comments

Author: eti-codefresh

action.yaml

@@ -157,8 +157,6 @@ runs:
         # github
         GITHUB_REF_NAME: "${{ github.ref_name }}"
         GITHUB_REPOSITORY: "${{ github.repository }}"
-        GITHUB_COMMIT_MESSAGE: "${{ github.event.head_commit.message }}"
-        GITHUB_PAYLOAD_MESSAGE: "${{ github.event.client_payload.message }}"
         GITHUB_WORKFLOW_NAME: "${{ github.repository }}/${{ github.run_id }}"
         GITHUB_WORKFLOW_URL: "${{ github.server_url	}}/${{ github.repository }}/actions/runs/${{ github.run_id }}"
 

src/__tests__/validate.spec.ts

@@ -6,7 +6,7 @@ describe('client report-image validation', () => {
         try {
             validate({ ENV1: '1', someVal: 'ignored' })
         } catch (error) {
-            const expectedErrorMsg = 'Validation Error: ["CF_API_KEY must be provided as environment variable.","CF_IMAGE must be provided as environment variable.","CF_RUNTIME_NAME must be provided as environment variable."]'
+            const expectedErrorMsg = '["CF_API_KEY must be provided as environment variable.","CF_IMAGE must be provided as environment variable.","CF_RUNTIME_NAME must be provided as environment variable."]'
             expect(error.message).toBe(expectedErrorMsg)
             return
         }

src/main.ts

@@ -1,7 +1,7 @@
 import EventSource from 'eventsource'
 
 import { validate } from './validate'
-import { Utils } from './utils'
+import { Utils }  from './utils'
 import {  errors } from './errors'
 import { logger, workflowLogger } from './logger'
 

src/utils.ts

@@ -2,12 +2,13 @@ import { GraphQLClient, gql } from 'graphql-request'
 import { get } from 'lodash'
 
 import { errors } from './errors'
-export class Utils {
+
+export namespace Utils {
     /**
      * Build image-report url and headers
      * @param payload
      */
-    static async buildUrlHeaders(payload: Record<string, string | undefined>): Promise<{ url: string, headers: { authorization: string } }> {
+     export async function buildUrlHeaders(payload: Record<string, string | undefined>): Promise<{ url: string, headers: { authorization: string } }> {
         const esc = encodeURIComponent
         const headers = { 'authorization': payload['CF_API_KEY']! }
         const runtimeName = payload['CF_RUNTIME_NAME']
@@ -16,7 +17,7 @@ export class Utils {
             host = payload['CF_HOST']
             delete payload['CF_HOST']
         } else {
-            host = await this.getRuntimeIngressHost(runtimeName, headers)
+            host = await Utils.getRuntimeIngressHost(runtimeName, headers)
             delete payload['CF_RUNTIME_NAME']
         }
         delete payload['CF_API_KEY']
@@ -28,7 +29,7 @@ export class Utils {
         return { url, headers }
     }
 
-    static async getRuntimeIngressHost(runtimeName: string, headers: Record<string, string>, platformHost = 'https://g.codefresh.io'): Promise<string> {
+    export async function getRuntimeIngressHost(runtimeName: string, headers: Record<string, string>, platformHost = 'https://g.codefresh.io'): Promise<string> {
         const graphQLClient = new GraphQLClient(`${platformHost}/2.0/api/graphql`, {
             headers
         })
@@ -44,12 +45,12 @@ export class Utils {
         const ingressHost = get(res, 'runtime.ingressHost')
         if (!ingressHost) {
             const message = res.runtime ? `ingress host is not defined on your '${runtimeName}' runtime` : `runtime '${runtimeName}' does not exist`
-            throw new errors.ValidationError(`Validation Error: ${message}`)
+            throw new errors.ValidationError(message)
         }
         return ingressHost
     }
 
-    static tryParseJson = (str: string) => {
+    export function tryParseJson (str: string) {
         try {
             return JSON.parse(str)
         } catch {

src/validate.ts

@@ -19,7 +19,7 @@ export function validate(payload: Record<string, string|undefined>): Record<stri
         messages.push(`You can only specify CF_RUNTIME_NAME or CF_HOST. please delete one of them.`)
     }
     if (messages.length > 0) {
-        throw new errors.ValidationError(`Validation Error: ${JSON.stringify(messages)}`)
+        throw new errors.ValidationError(`${JSON.stringify(messages)}`)
     }
 
     return filtered