double encode URL path segment: JS encodeURIComponent function does work as expected for path segments

Author: alexei-led

lib/logic/api/trigger.js

@@ -100,7 +100,7 @@ const getPipelineTriggers = async (pipeline) => {
 
 const getEventTriggers = async (event) => {
     const options = {
-        url: `/api/hermes/triggers/event/${encodeURIComponent(event)}`,
+        url: `/api/hermes/triggers/event/${encodeURIComponent(encodeURIComponent(event))}`,
         method: 'GET',
     };
 
@@ -117,7 +117,7 @@ const getEventTriggers = async (event) => {
 
 const createTrigger = async (event, pipeline, filters) => {
     const options = {
-        url: `/api/hermes/triggers/${encodeURIComponent(event)}/${pipeline}`,
+        url: `/api/hermes/triggers/${encodeURIComponent(encodeURIComponent(event))}/${pipeline}`,
         method: 'POST',
         body: {
             filters,
@@ -129,7 +129,7 @@ const createTrigger = async (event, pipeline, filters) => {
 
 const deleteTrigger = async (event, pipeline) => {
     const options = {
-        url: `api/hermes/triggers/${encodeURIComponent(event)}/${pipeline}`,
+        url: `api/hermes/triggers/${encodeURIComponent(encodeURIComponent(event))}/${pipeline}`,
         method: 'DELETE',
     };
 
@@ -140,7 +140,7 @@ const deleteTrigger = async (event, pipeline) => {
 
 const getEvent = async (event) => {
     const options = {
-        url: `/api/hermes/events/${encodeURIComponent(event)}`,
+        url: `/api/hermes/events/${encodeURIComponent(encodeURIComponent(event))}`,
         method: 'GET',
     };
 
@@ -181,7 +181,7 @@ const createEvent = async (type, kind, secret, values, context, pub) => {
 
 const deleteEvent = async (event, context) => {
     const options = {
-        url: `/api/hermes/events/${encodeURIComponent(event)}/${context}`,
+        url: `/api/hermes/events/${encodeURIComponent(encodeURIComponent(event))}/${context}`,
         method: 'DELETE',
     };
 

package.json

@@ -1,6 +1,6 @@
 {
   "name": "codefresh",
-  "version": "0.8.45",
+  "version": "0.8.46",
   "description": "Codefresh command line utility",
   "main": "index.js",
   "preferGlobal": true,