Skip to content

Commit bc75e0e

Browse files
added build-node-selector from values file (#680)
1 parent a8d59f3 commit bc75e0e

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

lib/interface/cli/commands/hybrid/helper.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -961,7 +961,7 @@ async function newAgentName(kubeContextName, kubeNamespace, agents) {
961961
}
962962

963963
function keyValueAsStringToObject(nodeSelectorStr) {
964-
if (nodeSelectorStr) {
964+
if (_.isString(nodeSelectorStr)) {
965965
const kubeNodeSelectorObj = {};
966966
const nsSplitParts = nodeSelectorStr.split(',');
967967
nsSplitParts.forEach((nsPart) => {
@@ -974,6 +974,7 @@ function keyValueAsStringToObject(nodeSelectorStr) {
974974
});
975975
return kubeNodeSelectorObj;
976976
}
977+
return nodeSelectorStr;
977978
}
978979

979980
function objectToKeyValueArray(obj) {
@@ -1057,6 +1058,9 @@ function mergeValuesFromValuesFile(argv, valuesFile, handleError) {
10571058
if (_.has(valuesObj, 'Runtime.AdditionalEnvVars')) {
10581059
_.set(_argv, 'reEnvVars', valuesObj.Runtime.AdditionalEnvVars);
10591060
}
1061+
if (_.has(valuesObj, 'Runtime.NodeSelector')) {
1062+
_.set(_argv, 'build-node-selector', valuesObj.Runtime.NodeSelector);
1063+
}
10601064
if (_.has(valuesObj, 'Runtime.resources')) {
10611065
_.set(_argv, 'reResources', valuesObj.Runtime.resources);
10621066
}

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "codefresh",
3-
"version": "0.75.23",
3+
"version": "0.75.25",
44
"description": "Codefresh command line utility",
55
"main": "index.js",
66
"preferGlobal": true,

0 commit comments

Comments
 (0)