Saas 7579 (#516)

check node version

Author: oren-codefresh

Dockerfile

@@ -28,6 +28,7 @@ WORKDIR /cf-cli
 COPY package.json /cf-cli
 COPY yarn.lock /cf-cli
 COPY check-version.js /cf-cli
+COPY run-check-version.js /cf-cli
 
 RUN yarn install --prod --frozen-lockfile && \
     yarn cache clean

check-version.js

@@ -1,8 +1,13 @@
 const semver = require('semver');
 const { engines } = require('./package');
 
-const version = engines.node;
-if (!semver.satisfies(process.version, version)) {
-    throw new Error(`Required node version ${version} not satisfied with current version ${process.version}.`);
+function checkVersion(version = engines.node) {
+    if (!semver.satisfies(process.version, version)) {
+        throw new Error(`Required node version ${version} not satisfied with current version ${process.version}.`);
+    }
 }
+// checkVersion();
 
+module.exports = {
+    checkVersion,
+};

lib/interface/cli/commands/hybrid/init.cmd.js

@@ -368,11 +368,12 @@ const initCmd = new Command({
         installationPlan.addStep({
             name: 'create new runtime',
             func: async () => {
+                const reName = installationPlan.getContext('runtimeName');
                 const runtimeCreateOpt = {
                     namespace: kubeNamespace,
                     storageClassName: storageClassName || `${INSTALLATION_DEFAULTS.STORAGE_CLASS_PREFIX}-${kubeNamespace}`,
                     clusterName: kubeContextName,
-                    runtimeEnvironmentName: installationPlan.getContext('runtimeName'),
+                    runtimeEnvironmentName: reName,
                     agent: true,
                 };
 
@@ -381,6 +382,7 @@ const initCmd = new Command({
                 }
 
                 await sdk.cluster.create(runtimeCreateOpt);
+                console.log(`Runtime environment "${colors.cyan(reName)}" has been created`);
             },
         });
 

lib/interface/cli/commands/pipeline/pipeline.sdk.spec.js

@@ -7,7 +7,7 @@ const { positionalHandler } = require('./get.completion');
 const { sdk } = require('../../../../logic');
 
 jest.mock('../../helpers/validation'); // eslint-disable-line
-
+jest.mock('../../../../../check-version');
 jest.mock('../../completion/helpers', () => { // eslint-disable-line
     return {
         authContextWrapper: func => func,

lib/interface/cli/helpers/helpers.sdk.spec.js

@@ -15,6 +15,8 @@ jest.mock('../../../logic/entities/Context', () => ({
         getType: () => 'yaml',
     }),
 }));
+jest.mock('./../../../../check-version');
+const versionChecker = require('./../../../../check-version');
 
 jest.mock('../../../logic/entities/Workflow', () => ({
     fromResponse: () => ({
@@ -65,6 +67,15 @@ describe('helpers using sdk', () => {
             expect(sdk.logs.showWorkflowLogs).toBeCalled();
             await verifyResponsesReturned([DEFAULT_RESPONSE]); // eslint-disable-line
         });
+        it('should not show logs if check version throw an exception', async () => {
+            const workflowId = 'id';
+            jest.spyOn(sdk.logs, 'showWorkflowLogs').mockImplementation();
+            versionChecker.checkVersion.mockImplementationOnce(() => {
+                throw new Error();
+            });
+            await followLogs(workflowId);
+            expect(sdk.logs.showWorkflowLogs).not.toBeCalled();
+        });
     });
 
     describe('auth', () => {
@@ -151,12 +162,10 @@ describe('helpers using sdk', () => {
 
             it('should log all contexts when filter is "all"', async () => {
                 sdk.config.context = Config.manager().getCurrentContext();
-                const verifyContexts = _.map(_.values(Config.MOCK_CONTEXTS), (context) => {
-                    return _.mapValues(_.pick(context, context.defaultColumns), (val, key) => {
-                        if (key === 'current') return chalk.green('*');
-                        return val;
-                    });
-                });
+                const verifyContexts = _.map(_.values(Config.MOCK_CONTEXTS), context => _.mapValues(_.pick(context, context.defaultColumns), (val, key) => {
+                    if (key === 'current') return chalk.green('*');
+                    return val;
+                }));
 
                 await printTableForAuthContexts();
 

lib/interface/cli/helpers/logs.js

@@ -6,6 +6,9 @@ const CFError = require('cf-errors');
 const { sdk } = require('../../../logic');
 const Workflow = require('../../../logic/entities/Workflow');
 const Output = require('../../../output/Output');
+const { checkVersion } = require('./../../../../check-version');
+
+const nodeVersionToValidate = '<=10.x >=8.x';
 
 const END_STATUSES = ['error', 'success', 'terminated'];
 
@@ -53,6 +56,15 @@ async function _fallbackLogs(workflowId, interval, retriesLeft) {
 }
 
 const followLogs = async (workflowId) => {
+    try {
+        checkVersion(nodeVersionToValidate);
+    } catch (error) {
+        const url = _.get(sdk, 'config.context.url', 'https://g.codefresh.io');
+        const buildLink = `${url}/build/${workflowId}`;
+        // eslint-disable-next-line max-len
+        console.log(`Your node version (${process.version}) is not compatible with supported node version (${nodeVersionToValidate}) for this command, click the link to see it in codefresh UI : ${buildLink}`);
+        return;
+    }
     try {
         await sdk.logs.showWorkflowLogs(workflowId, true);
     } catch (e) {

lib/logic/entities/Agent.js

@@ -10,14 +10,13 @@ class Agent extends Entity {
         this.name = data.name;
         this.runtimes = data.runtimes;
         const status = _.get(data, 'status.healthStatus', 'N/A');
-        this.status = this._pickStatusColor(status)(status);
+        this.status = Agent._pickStatusColor(status)(status);
         const lastReported = _.get(data, 'status.reportedAt', 'N/A');
-        this.reported = this._pickLastReportedColor(status)(lastReported);
+        this.reported = Agent._pickLastReportedColor(status)(lastReported);
         this.defaultColumns = ['name', 'runtimes', 'status', 'reported'];
     }
 
-    // eslint-disable-next-line class-methods-use-this
-    _pickLastReportedColor(healthStatus) {
+    static _pickLastReportedColor(healthStatus) {
         switch (healthStatus) {
             case 'N/A':
                 return chalk.gray;
@@ -30,19 +29,20 @@ class Agent extends Entity {
         }
     }
 
-    _pickStatusColor(healthStatus) {
+    static _pickStatusColor(healthStatus) {
         switch (healthStatus) {
             case 'N/A':
-                return chalk.white.bgGray;
+                return chalk.white.bgGray || _.identity;
             case 'unhealthy':
-                return chalk.white.bgRed;
+                return chalk.white.bgRed || _.identity;
             case 'healthy':
-                return chalk.black.bgGreen;
+                return chalk.black.bgGreen || _.identity;
             default:
-                return chalk.black.bgRed;
+                return chalk.black.bgRed || _.identity;
         }
     }
 
+
     static fromResponse(response) {
         return new Agent(_.pick(response, 'id', 'name', 'runtimes', 'status', 'lastReported'));
     }

package.json

@@ -14,7 +14,7 @@
     "serve-docs-beta": "ALLOW_BETA_COMMANDS=true yarn build-local-docs && cd temp && hugo server -D",
     "build-local-docs": "node ./docs/index.js",
     "build-public-docs": "node ./docs/index.js && cd temp && hugo",
-    "postinstall": "node check-version.js"
+    "postinstall": "node run-check-version.js"
   },
   "bin": {
     "codefresh": "./lib/interface/cli/codefresh"
@@ -91,7 +91,7 @@
   "author": "Codefresh",
   "license": "ISC",
   "engines": {
-    "node": ">=8.0.0"
+    "node": ">=8.x"
   },
   "jest": {
     "testEnvironment": "node",

run-check-version.js

@@ -0,0 +1,3 @@
+const { checkVersion } = require('./check-version');
+
+checkVersion();