Skip to content

Commit 383b5fc

Browse files
added --insecure option to runner init, delete and upgrade (#573)
1 parent 0d5e07e commit 383b5fc

File tree

4 files changed

+32
-1
lines changed

4 files changed

+32
-1
lines changed

lib/interface/cli/commands/hybrid/delete.cmd.js

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,10 @@ const deleteCmd = new Command({
8787
})
8888
.option('verbose', {
8989
describe: 'Print logs',
90+
})
91+
.option('insecure', {
92+
describe: 'disable certificate validation for TLS connections (e.g. to g.codefresh.io)',
93+
type: 'boolean',
9094
}),
9195
handler: async (argv) => {
9296
let {
@@ -96,6 +100,7 @@ const deleteCmd = new Command({
96100
'kube-namespace': kubeNamespace,
97101
name: agentName,
98102
values: valuesFile,
103+
insecure,
99104
} = argv;
100105

101106
const [listReErr, runtimes] = await to(sdk.runtimeEnvs.list({ }));
@@ -129,10 +134,16 @@ const deleteCmd = new Command({
129134
if (!agentName && valuesObj.AgentId) {
130135
agentName = valuesObj.AgentId;
131136
}
137+
if (_.isUndefined(insecure)) {
138+
insecure = _.get(valuesObj, 'Insecure');
139+
}
132140
}
133141
if (!url) {
134142
url = DEFAULTS.URL;
135143
}
144+
if (insecure) {
145+
process.env.NODE_TLS_REJECT_UNAUTHORIZED = '0';
146+
}
136147

137148
if (!kubeContextName) {
138149
const contexts = getAllKubeContexts(kubeConfigPath);

lib/interface/cli/commands/hybrid/init.cmd.js

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -184,6 +184,10 @@ const initCmd = new Command({
184184
describe: 'docker daemon access (default true)',
185185
default: true,
186186
type: 'boolean',
187+
})
188+
.option('insecure', {
189+
describe: 'disable certificate validation for TLS connections (e.g. to g.codefresh.io)',
190+
type: 'boolean',
187191
}),
188192
handler: async (argv) => {
189193
let resumedInstallation = false;
@@ -233,6 +237,7 @@ const initCmd = new Command({
233237
url,
234238
token,
235239
name,
240+
insecure,
236241
'app-proxy': appProxy,
237242
'app-proxy-host': appProxyHost,
238243
'install-monitor': installMonitor,
@@ -275,10 +280,16 @@ const initCmd = new Command({
275280
if (_.has(valuesObj, 'dockerDaemonScheduler.userAccess')) {
276281
dockerDaemonAccess = _.get(valuesObj, 'dockerDaemonScheduler.userAccess')
277282
}
283+
if (_.isUndefined(insecure)) {
284+
insecure = _.get(valuesObj, 'Insecure');
285+
}
278286
}
279287
if (!url) {
280288
url = DEFAULTS.URL;
281289
}
290+
if (insecure) {
291+
process.env.NODE_TLS_REJECT_UNAUTHORIZED = '0';
292+
}
282293

283294
if (_.get(sdk, 'config.context.isNoAuth') && !token) {
284295
console.log('Not authenticated as a Codefresh account: ');

lib/interface/cli/commands/hybrid/upgrade.cmd.js

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,20 +69,29 @@ const upgradeCmd = new Command({
6969
})
7070
.option('verbose', {
7171
describe: 'Print logs',
72+
})
73+
.option('insecure', {
74+
describe: 'disable certificate validation for TLS connections (e.g. to g.codefresh.io)',
75+
type: 'boolean',
7276
}),
7377
handler: async (argv) => {
7478
const {
7579
'kube-config-path': kubeConfigPath,
7680
'agent-name': agentName,
7781
'install-monitor': installMonitor,
7882
verbose,
83+
insecure,
7984
} = argv;
8085
let {
8186
'kube-context-name': kubeContextName,
8287
'kube-namespace': kubeNamespace,
8388
'runtime-name': runtimeName,
8489
} = argv;
8590

91+
if (insecure) {
92+
process.env.NODE_TLS_REJECT_UNAUTHORIZED = '0';
93+
}
94+
8695
const [listReErr, runtimes] = await to(sdk.runtimeEnvs.list({ }));
8796
await handleError(listReErr, 'Failed to get runtime environments');
8897
const runtimesByName = runtimes.reduce((acc, cur) => ({ ...acc, [cur.metadata.name]: cur }), {});

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "codefresh",
3-
"version": "0.73.7",
3+
"version": "0.73.8",
44
"description": "Codefresh command line utility",
55
"main": "index.js",
66
"preferGlobal": true,

0 commit comments

Comments
 (0)