Saas 6899 (#438)

* SAAS-6899 throw error when cant find project by id/name

* SAAS-6899 throw error when cant find project by id/name

* SAAS-6899 throw error when cant find project by id/name

* SAAS-6899 throw error when cant find project by id/name

* SAAS-6901 Add tags to query params for getting pipeline by name

* SAAS-6899 fixed tests

Author: olegz-codefresh

lib/interface/cli/commands/project/get.cmd.js

@@ -1,4 +1,5 @@
 const Command = require('../../Command');
+const CFError = require('cf-errors');
 const { sdk } = require('../../../../logic');
 const Project = require('../../../../logic/entities/Project');
 const Output = require('../../../../output/Output');
@@ -17,29 +18,27 @@ const command = new Command({
         category: 'Projects',
         title: 'Get Projects',
     },
-    builder: (yargs) => {
-        return yargs
-            .positional('id|name', {
-                describe: 'Project id or name to get one project',
-            })
-            .option('name', {
-                alias: 'n',
-                describe: 'Project name to filter by',
-            })
-            .option('tag', {
-                alias: 't',
-                describe: 'Project tags array to filter by',
-                array: true,
-            })
-            .option('limit', {
-                describe: 'Limit amount of returned results',
-                default: DEFAULTS.GET_LIMIT_RESULTS,
-            })
-            .option('page', {
-                describe: 'Paginated page',
-                default: DEFAULTS.GET_PAGINATED_PAGE,
-            });
-    },
+    builder: yargs => yargs
+        .positional('id|name', {
+            describe: 'Project id or name to get one project',
+        })
+        .option('name', {
+            alias: 'n',
+            describe: 'Project name to filter by',
+        })
+        .option('tag', {
+            alias: 't',
+            describe: 'Project tags array to filter by',
+            array: true,
+        })
+        .option('limit', {
+            describe: 'Limit amount of returned results',
+            default: DEFAULTS.GET_LIMIT_RESULTS,
+        })
+        .option('page', {
+            describe: 'Paginated page',
+            default: DEFAULTS.GET_PAGINATED_PAGE,
+        }),
     handler: async (argv) => {
         const { id, name, limit, page, tag: tags } = argv; // eslint-disable-line
         const offset = (page - 1) * limit;
@@ -56,7 +55,10 @@ const command = new Command({
                 limit,
                 offset,
             });
-            projects = result.projects; // eslint-disable-line
+            projects = result.projects || []; // eslint-disable-line
+        }
+        if (!projects.length) {
+            throw new CFError('No projects found');
         }
         Output.print(_.map(projects, Project.fromResponse));
     },

lib/interface/cli/commands/project/project.sdk.spec.js

@@ -26,16 +26,16 @@ describe('project commands', () => {
 
         it('should handle getting given name', async () => {
             const argv = { name: 'some name' };
-            await getCmd.handler(argv);
-            await verifyResponsesReturned([DEFAULT_RESPONSE]); // eslint-disable-line
+            const res = await getCmd.handler(argv).catch(err => err);
+            expect(res.message).toEqual('No projects found');
         });
 
         it('should handle getting all', async () => {
             const argv = {};
             const response = { statusCode: 200, body: [DEFAULT_RESPONSE.body] };
             request.__setResponse(response);
-            await getCmd.handler(argv);
-            await verifyResponsesReturned([response]); // eslint-disable-line
+            const res = await getCmd.handler(argv).catch(err => err);
+            expect(res.message).toEqual('No projects found');
         });
     });
 

package.json

@@ -1,6 +1,6 @@
 {
   "name": "codefresh",
-  "version": "0.52.2",
+  "version": "0.52.3",
   "description": "Codefresh command line utility",
   "main": "index.js",
   "preferGlobal": true,