Skip to content

Commit 0b34605

Browse files
limit runtime name length (#472)
* limit runtime name length
1 parent 0c7888b commit 0b34605

File tree

2 files changed

+11
-4
lines changed

2 files changed

+11
-4
lines changed

lib/interface/cli/commands/runtimeEnvironments/install.cmd.js

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,10 @@ const colors = require('colors');
1111
const _ = require('lodash');
1212

1313
const defaultNamespace = 'codefresh';
14+
const maxRuntimeNameLength = 63;
1415

1516
async function newRuntimeName(kubeContextName, kubeNamespace) {
16-
const defaultName = `${kubeContextName}/${kubeNamespace}`;
17+
const defaultName = `${kubeContextName}/${kubeNamespace}`.slice(0, maxRuntimeNameLength);
1718
const runtimes = await sdk.runtimeEnvs.list({ });
1819
let name;
1920

@@ -22,10 +23,16 @@ async function newRuntimeName(kubeContextName, kubeNamespace) {
2223
} else {
2324
const reNames = new Set(_.map(runtimes, re => _.get(re, 'metadata.name'))); // for fast lookup
2425
let i = 1;
25-
while (reNames.has(`${defaultName}_${i}`)) {
26+
let suggestName;
27+
// eslint-disable-next-line no-constant-condition
28+
while (true) {
29+
suggestName = `${defaultName.slice(0, maxRuntimeNameLength - 2)}_${i}`;
30+
if (!reNames.has(suggestName)) {
31+
break;
32+
}
2633
i += 1;
2734
}
28-
name = `${defaultName}_${i}`;
35+
name = suggestName;
2936
}
3037

3138
return name;

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "codefresh",
3-
"version": "0.63.13",
3+
"version": "0.63.14",
44
"description": "Codefresh command line utility",
55
"main": "index.js",
66
"preferGlobal": true,

0 commit comments

Comments
 (0)