CR-6448-install-only-with-latest (#128)

* init commit

* bump

* removed redundant

* status code error and using store

* naming and removed comment

* tidy

* typo fix

* tested through changing makefile version

* cli - waiting for merged ap

* added comment

* added comment

* added comment

* without params getgitprovider

* removed redundant and changed comment

* removed redundant arg

* verification in all commands using platform

* bump sdk

* removed redundant

* getting string instead of release model

* remove local go mod

* bump

* without local sdk

* tidy

* return err instead of additional log

* return err instead of additional log

Author: elad-codefresh

Makefile

@@ -1,4 +1,4 @@
-VERSION=v0.0.121
+VERSION=v0.0.122
 
 OUT_DIR=dist
 YEAR?=$(shell date +"%Y")

cmd/commands/common.go

@@ -15,13 +15,16 @@
 package commands
 
 import (
+	"context"
 	_ "embed"
 	"fmt"
 	"os"
 	"regexp"
 
+	"github.com/Masterminds/semver/v3"
 	"github.com/argoproj-labs/argocd-autopilot/pkg/git"
 	"github.com/codefresh-io/cli-v2/pkg/config"
+	"github.com/codefresh-io/cli-v2/pkg/store"
 	"github.com/codefresh-io/cli-v2/pkg/util"
 
 	"github.com/spf13/cobra"
@@ -61,12 +64,12 @@ func IsValid(s string) (bool, error) {
 	return regexp.MatchString(`^[a-z]([-a-z0-9]{0,61}[a-z0-9])?$`, s)
 }
 
-func ensureRepo(cmd *cobra.Command, args []string, cloneOpts  *git.CloneOptions) error {
+func ensureRepo(cmd *cobra.Command, args []string, cloneOpts *git.CloneOptions) error {
 	ctx := cmd.Context()
 	if cloneOpts.Repo == "" {
 		runtimeData, err := cfConfig.NewClient().V2().Runtime().Get(ctx, args[0])
 		if err != nil {
-			return fmt.Errorf("Failed getting runtime repo information: %w", err)
+			return fmt.Errorf("failed getting runtime repo information: %w", err)
 		}
 		if runtimeData.Repo != nil {
 			cloneOpts.Repo = *runtimeData.Repo
@@ -75,3 +78,19 @@ func ensureRepo(cmd *cobra.Command, args []string, cloneOpts  *git.CloneOptions)
 	}
 	return nil
 }
+
+func verifyLatestVersion(ctx context.Context) error {
+	latestVersionString, err := cfConfig.NewClient().V2().CliReleases().GetLatest(ctx)
+	if err != nil {
+		return fmt.Errorf("failed getting latest cli release: %w", err)
+	}
+	
+	latestVersionSemver := semver.MustParse(latestVersionString)
+	currentVersion := store.Get().Version.Version
+
+	if currentVersion.LessThan(latestVersionSemver) {
+		return fmt.Errorf("please upgrade to the latest cli version: %s", latestVersionString)
+	}
+
+	return nil
+}

cmd/commands/component.go

@@ -59,6 +59,10 @@ func NewComponentListCommand() *cobra.Command {
 		RunE: func(cmd *cobra.Command, args []string) error {
 			ctx := cmd.Context()
 
+			if err := verifyLatestVersion(ctx); err != nil {
+				return err
+			}
+
 			return RunComponentList(ctx, args[0])
 		},
 	}

cmd/commands/git-source.go

@@ -133,7 +133,7 @@ func NewGitSourceCreateCommand() *cobra.Command {
 			if gsCloneOpts.Repo == "" {
 				log.G(ctx).Fatal("must enter a valid value to --git-src-repo. Example: https://github.com/owner/repo-name/path/to/workflow")
 			}
-			
+
 			err := ensureRepo(cmd, args, insCloneOpts)
 			if err != nil {
 				return err
@@ -159,6 +159,10 @@ func NewGitSourceCreateCommand() *cobra.Command {
 		RunE: func(cmd *cobra.Command, args []string) error {
 			ctx := cmd.Context()
 
+			if err := verifyLatestVersion(ctx); err != nil {
+				return err
+			}
+
 			return RunGitSourceCreate(ctx, &GitSourceCreateOptions{
 				InsCloneOpts:        insCloneOpts,
 				GsCloneOpts:         gsCloneOpts,
@@ -372,7 +376,13 @@ func NewGitSourceListCommand() *cobra.Command {
 			}
 		},
 		RunE: func(cmd *cobra.Command, args []string) error {
-			return RunGitSourceList(cmd.Context(), args[0])
+			ctx := cmd.Context()
+
+			if err := verifyLatestVersion(ctx); err != nil {
+				return err
+			}
+
+			return RunGitSourceList(ctx, args[0])
 		},
 	}
 	return cmd
@@ -468,6 +478,10 @@ func NewGitSourceDeleteCommand() *cobra.Command {
 		RunE: func(cmd *cobra.Command, args []string) error {
 			ctx := cmd.Context()
 
+			if err := verifyLatestVersion(ctx); err != nil {
+				return err
+			}
+
 			return RunGitSourceDelete(ctx, &GitSourceDeleteOptions{
 				RuntimeName:  args[0],
 				GsName:       args[1],
@@ -538,6 +552,10 @@ func NewGitSourceEditCommand() *cobra.Command {
 		RunE: func(cmd *cobra.Command, args []string) error {
 			ctx := cmd.Context()
 
+			if err := verifyLatestVersion(ctx); err != nil {
+				return err
+			}
+
 			return RunGitSourceEdit(ctx, &GitSourceEditOptions{
 				RuntimeName:  args[0],
 				GsName:       args[1],

cmd/commands/pipeline.go

@@ -62,6 +62,10 @@ func NewPipelineGetCommand() *cobra.Command {
 		RunE: func(cmd *cobra.Command, args []string) error {
 			ctx := cmd.Context()
 
+			if err := verifyLatestVersion(ctx); err != nil {
+				return err
+			}
+
 			return RunPipelineGet(ctx, name, namespace, runtime)
 		},
 	}
@@ -97,6 +101,10 @@ func NewPipelineListCommand() *cobra.Command {
 		RunE: func(cmd *cobra.Command, args []string) error {
 			ctx := cmd.Context()
 
+			if err := verifyLatestVersion(ctx); err != nil {
+				return err
+			}
+
 			filterArgs := model.PipelinesFilterArgs{
 				Name:      &name,
 				Namespace: &namespace,

cmd/commands/runtime.go

@@ -386,6 +386,10 @@ func installComponents(ctx context.Context, opts *RuntimeInstallOptions, rt *run
 func preInstallationChecks(ctx context.Context, opts *RuntimeInstallOptions) error {
 	log.G(ctx).Debug("running pre-installation checks...")
 
+	if err := verifyLatestVersion(ctx); err != nil {
+		return err
+	}
+
 	if err := checkRuntimeCollisions(ctx, opts.RuntimeName, opts.KubeFactory); err != nil {
 		return fmt.Errorf("runtime collision check failed: %w", err)
 	}
@@ -592,10 +596,15 @@ func NewRuntimeUninstallCommand() *cobra.Command {
 		},
 		RunE: func(cmd *cobra.Command, args []string) error {
 			ctx := cmd.Context()
+
 			if len(args) < 1 {
 				log.G(ctx).Fatal("must enter runtime name")
 			}
 
+			if err := verifyLatestVersion(ctx); err != nil {
+				return err
+			}
+
 			return RunRuntimeUninstall(ctx, &RuntimeUninstallOptions{
 				RuntimeName: args[0],
 				Timeout:     store.Get().WaitTimeout,
@@ -620,6 +629,10 @@ func NewRuntimeUninstallCommand() *cobra.Command {
 }
 
 func RunRuntimeUninstall(ctx context.Context, opts *RuntimeUninstallOptions) error {
+	if err := verifyLatestVersion(ctx); err != nil {
+		return err
+	}
+
 	// check whether the runtime exists
 	if !opts.SkipChecks {
 		_, err := cfConfig.NewClient().V2().Runtime().Get(ctx, opts.RuntimeName)
@@ -702,6 +715,7 @@ func NewRuntimeUpgradeCommand() *cobra.Command {
 				err     error
 			)
 			ctx := cmd.Context()
+
 			if len(args) < 1 {
 				log.G(ctx).Fatal("must enter runtime name")
 			}
@@ -713,6 +727,10 @@ func NewRuntimeUpgradeCommand() *cobra.Command {
 				}
 			}
 
+			if err := verifyLatestVersion(ctx); err != nil {
+				return err
+			}
+
 			return RunRuntimeUpgrade(ctx, &RuntimeUpgradeOptions{
 				RuntimeName: args[0],
 				Version:     version,

cmd/commands/workflow.go

@@ -59,6 +59,10 @@ func NewWorkflowGetCommand() *cobra.Command {
 		RunE: func(cmd *cobra.Command, args []string) error {
 			ctx := cmd.Context()
 
+			if err := verifyLatestVersion(ctx); err != nil {
+				return err
+			}
+
 			return RunWorkflowGet(ctx, args[0])
 		},
 	}
@@ -86,6 +90,10 @@ func NewWorkflowListCommand() *cobra.Command {
 		RunE: func(cmd *cobra.Command, args []string) error {
 			ctx := cmd.Context()
 
+			if err := verifyLatestVersion(ctx); err != nil {
+				return err
+			}
+
 			filterArgs := model.WorkflowsFilterArgs{
 				Namespace: &namespace,
 				Runtime:   &runtime,

docs/releases/release_notes.md

@@ -20,7 +20,7 @@ cf version
 ### Linux
 ```bash
 # download and extract the binary
-curl -L --output - https://github.com/codefresh-io/cli-v2/releases/download/v0.0.121/cf-linux-amd64.tar.gz | tar zx
+curl -L --output - https://github.com/codefresh-io/cli-v2/releases/download/v0.0.122/cf-linux-amd64.tar.gz | tar zx
 
 # move the binary to your $PATH
 mv ./cf-linux-amd64 /usr/local/bin/cf
@@ -32,7 +32,7 @@ cf version
 ### Mac
 ```bash
 # download and extract the binary
-curl -L --output - https://github.com/codefresh-io/cli-v2/releases/download/v0.0.121/cf-darwin-amd64.tar.gz | tar zx
+curl -L --output - https://github.com/codefresh-io/cli-v2/releases/download/v0.0.122/cf-darwin-amd64.tar.gz | tar zx
 
 # move the binary to your $PATH
 mv ./cf-darwin-amd64 /usr/local/bin/cf

go.mod

@@ -10,7 +10,7 @@ require (
 	github.com/argoproj/argo-events v1.4.0
 	github.com/argoproj/argo-workflows/v3 v3.1.6
 	github.com/briandowns/spinner v1.16.0
-	github.com/codefresh-io/go-sdk v0.34.12
+	github.com/codefresh-io/go-sdk v0.35.0
 	github.com/fatih/color v1.12.0
 	github.com/ghodss/yaml v1.0.1-0.20190212211648-25d852aebe32
 	github.com/go-git/go-billy/v5 v5.3.1
@@ -23,6 +23,7 @@ require (
 	github.com/spf13/pflag v1.0.5
 	github.com/spf13/viper v1.7.1
 	github.com/stretchr/testify v1.7.0
+	golang.org/x/crypto v0.0.0-20210817164053-32db794688a5 // indirect
 	k8s.io/api v0.21.3
 	k8s.io/apimachinery v0.21.1
 	k8s.io/client-go v11.0.1-0.20190816222228-6d55c1b1f1ca+incompatible

go.sum

@@ -262,8 +262,8 @@ github.com/clusterhq/flocker-go v0.0.0-20160920122132-2b8b7259d313/go.mod h1:P1w
 github.com/cncf/udpa/go v0.0.0-20191209042840-269d4d468f6f/go.mod h1:M8M6+tZqaGXZJjfX53e64911xZQV5JYwmTeXPW+k8Sc=
 github.com/cockroachdb/datadriven v0.0.0-20190809214429-80d97fb3cbaa/go.mod h1:zn76sxSg3SzpJ0PPJaLDCu+Bu0Lg3sKTORVIj19EIF8=
 github.com/codahale/hdrhistogram v0.0.0-20161010025455-3a0bb77429bd/go.mod h1:sE/e/2PUdi/liOCUjSTXgM1o87ZssimdTWN964YiIeI=
-github.com/codefresh-io/go-sdk v0.34.12 h1:cwUa1DD4yQ16xuUDHRik6M5GK+I2xkX2ADWNCnsQkOM=
-github.com/codefresh-io/go-sdk v0.34.12/go.mod h1:CcoVmTFWHGkbrSW8LyOGB/vJe5Vzr3iC/pNE2QIBTyg=
+github.com/codefresh-io/go-sdk v0.35.0 h1:v+1E8hfIho8yi4E1bdccwjzMCBeKpOzKrJ9nTFC6ohw=
+github.com/codefresh-io/go-sdk v0.35.0/go.mod h1:CcoVmTFWHGkbrSW8LyOGB/vJe5Vzr3iC/pNE2QIBTyg=
 github.com/colinmarc/hdfs v1.1.4-0.20180802165501-48eb8d6c34a9/go.mod h1:0DumPviB681UcSuJErAbDIOx6SIaJWj463TymfZG02I=
 github.com/colinmarc/hdfs v1.1.4-0.20180805212432-9746310a4d31/go.mod h1:vSBumefK4HA5uiRSwNP+3ofgrEoScpCS2MMWcWXEuQ4=
 github.com/container-storage-interface/spec v1.3.0/go.mod h1:6URME8mwIBbpVyZV93Ce5St17xBiQJQY67NDsuohiy4=
@@ -1381,8 +1381,9 @@ golang.org/x/crypto v0.0.0-20201002170205-7f63de1d35b0/go.mod h1:LzIPMQfyMNhhGPh
 golang.org/x/crypto v0.0.0-20210220033148-5ea612d1eb83/go.mod h1:jdWPYTVW3xRLrWPugEBEK3UY2ZEsg3UU495nc5E+M+I=
 golang.org/x/crypto v0.0.0-20210322153248-0c34fe9e7dc2/go.mod h1:T9bdIzuCu7OtxOm1hfPfRQxPLYneinmdGuTeoZ9dtd4=
 golang.org/x/crypto v0.0.0-20210421170649-83a5a9bb288b/go.mod h1:T9bdIzuCu7OtxOm1hfPfRQxPLYneinmdGuTeoZ9dtd4=
-golang.org/x/crypto v0.0.0-20210616213533-5ff15b29337e h1:gsTQYXdTw2Gq7RBsWvlQ91b+aEQ6bXFUngBGuR8sPpI=
 golang.org/x/crypto v0.0.0-20210616213533-5ff15b29337e/go.mod h1:GvvjBRRGRdwPK5ydBHafDWAxML/pGHZbMvKqRZ5+Abc=
+golang.org/x/crypto v0.0.0-20210817164053-32db794688a5 h1:HWj/xjIHfjYU5nVXpTM0s39J9CbLn7Cc5a7IC5rwsMQ=
+golang.org/x/crypto v0.0.0-20210817164053-32db794688a5/go.mod h1:GvvjBRRGRdwPK5ydBHafDWAxML/pGHZbMvKqRZ5+Abc=
 golang.org/x/exp v0.0.0-20180321215751-8460e604b9de/go.mod h1:CJ0aWSM057203Lf6IL+f9T1iT9GByDxfZKAQTCR3kQA=
 golang.org/x/exp v0.0.0-20180807140117-3d87b88a115f/go.mod h1:CJ0aWSM057203Lf6IL+f9T1iT9GByDxfZKAQTCR3kQA=
 golang.org/x/exp v0.0.0-20190121172915-509febef88a4/go.mod h1:CJ0aWSM057203Lf6IL+f9T1iT9GByDxfZKAQTCR3kQA=