Skip to content

Commit b1560fd

Browse files
Fix Istio protocol detection for argocd-server (#408)
* istio fix * comments * bump
1 parent f706aa7 commit b1560fd

File tree

4 files changed

+10
-11
lines changed

4 files changed

+10
-11
lines changed

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
VERSION=v0.0.359
1+
VERSION=v0.0.360
22

33
OUT_DIR=dist
44
YEAR?=$(shell date +"%Y")

docs/releases/release_notes.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
- Argo CD [v2.1.14](https://github.com/argoproj/argo-cd/releases/tag/v2.1.14)
44
- Argo CD ApplicationSet Controller [v0.2.0](https://github.com/argoproj-labs/applicationset/releases/tag/v0.2.0)
55
- Argo Events [v1.5.5](https://github.com/argoproj/argo-events/releases/tag/v1.5.5)
6-
- Argo Rollouts [v1.1.0](https://github.com/argoproj/argo-rollouts/releases/tag/v1.1.0)
6+
- Argo Rollouts [v1.2.0](https://github.com/argoproj/argo-rollouts/releases/tag/v1.2.0)
77
- Argo Workflows [v3.2.6](https://github.com/argoproj/argo-workflows/releases/tag/v3.2.6)
88

99
### Using brew:
@@ -23,7 +23,7 @@ cf version
2323

2424
```bash
2525
# download and extract the binary
26-
curl -L --output - https://github.com/codefresh-io/cli-v2/releases/download/v0.0.359/cf-linux-amd64.tar.gz | tar zx
26+
curl -L --output - https://github.com/codefresh-io/cli-v2/releases/download/v0.0.360/cf-linux-amd64.tar.gz | tar zx
2727

2828
# move the binary to your $PATH
2929
mv ./cf-linux-amd64 /usr/local/bin/cf
@@ -36,7 +36,7 @@ cf version
3636

3737
```bash
3838
# download and extract the binary
39-
curl -L --output - https://github.com/codefresh-io/cli-v2/releases/download/v0.0.359/cf-darwin-amd64.tar.gz | tar zx
39+
curl -L --output - https://github.com/codefresh-io/cli-v2/releases/download/v0.0.360/cf-darwin-amd64.tar.gz | tar zx
4040

4141
# move the binary to your $PATH
4242
mv ./cf-darwin-amd64 /usr/local/bin/cf

manifests/argo-cd/kustomization.yaml

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -32,14 +32,13 @@ patches:
3232
path: /subjects/0/namespace
3333
value: default
3434
35+
# Service ports naming affects Istio protocol detection.
36+
# Since this port may be used for http and grpc we decided to override the default name ("http").
3537
- target:
3638
version: v1
3739
kind: Service
3840
name: argocd-server
3941
patch: |
40-
- op: add
41-
path: /spec/ports/0/appProtocol
42-
value: grpc
43-
- op: add
44-
path: /spec/ports/1/appProtocol
45-
value: grpc
42+
- op: replace
43+
path: /spec/ports/0/name
44+
value: main

manifests/runtime.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ metadata:
55
namespace: "{{ namespace }}"
66
spec:
77
defVersion: 1.0.1
8-
version: 0.0.359
8+
version: 0.0.360
99
bootstrapSpecifier: github.com/codefresh-io/cli-v2/manifests/argo-cd
1010
components:
1111
- name: events

0 commit comments

Comments
 (0)