Skip to content

Commit ab51e4d

Browse files
fixing --skip-checks not working for uninstall (#458)
1 parent b72d268 commit ab51e4d

File tree

4 files changed

+10
-8
lines changed

4 files changed

+10
-8
lines changed

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
VERSION=v0.0.405
1+
VERSION=v0.0.406
22

33
OUT_DIR=dist
44
YEAR?=$(shell date +"%Y")

cmd/commands/runtime.go

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -446,9 +446,11 @@ func runtimeUninstallCommandPreRunHandler(cmd *cobra.Command, args []string, opt
446446
return err
447447
}
448448

449-
opts.Managed, err = isRuntimeManaged(cmd.Context(), opts.RuntimeName)
450-
if err != nil {
451-
return err
449+
if !opts.SkipChecks {
450+
opts.Managed, err = isRuntimeManaged(cmd.Context(), opts.RuntimeName)
451+
if err != nil {
452+
return err
453+
}
452454
}
453455

454456
if !opts.Managed {
@@ -459,7 +461,7 @@ func runtimeUninstallCommandPreRunHandler(cmd *cobra.Command, args []string, opt
459461
return err
460462
}
461463

462-
if !opts.Managed {
464+
if !opts.Managed && !opts.SkipChecks {
463465
kubeconfig := cmd.Flag("kubeconfig").Value.String()
464466
err = ensureRuntimeOnKubeContext(cmd.Context(), kubeconfig, opts.RuntimeName, opts.kubeContext)
465467

docs/releases/release_notes.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ cf version
2323

2424
```bash
2525
# download and extract the binary
26-
curl -L --output - https://github.com/codefresh-io/cli-v2/releases/download/v0.0.405/cf-linux-amd64.tar.gz | tar zx
26+
curl -L --output - https://github.com/codefresh-io/cli-v2/releases/download/v0.0.406/cf-linux-amd64.tar.gz | tar zx
2727

2828
# move the binary to your $PATH
2929
mv ./cf-linux-amd64 /usr/local/bin/cf
@@ -36,7 +36,7 @@ cf version
3636

3737
```bash
3838
# download and extract the binary
39-
curl -L --output - https://github.com/codefresh-io/cli-v2/releases/download/v0.0.405/cf-darwin-amd64.tar.gz | tar zx
39+
curl -L --output - https://github.com/codefresh-io/cli-v2/releases/download/v0.0.406/cf-darwin-amd64.tar.gz | tar zx
4040

4141
# move the binary to your $PATH
4242
mv ./cf-darwin-amd64 /usr/local/bin/cf

manifests/runtime.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ metadata:
55
namespace: "{{ namespace }}"
66
spec:
77
defVersion: 1.0.1
8-
version: 0.0.405
8+
version: 0.0.406
99
bootstrapSpecifier: github.com/codefresh-io/cli-v2/manifests/argo-cd
1010
components:
1111
- name: events

0 commit comments

Comments
 (0)