Skip to content

Commit 67f7c6d

Browse files
delete workflow and pods after 24 hours (#225)
* delete workflow and pods after 24 hours * fix
1 parent 9196d16 commit 67f7c6d

File tree

4 files changed

+24
-4
lines changed

4 files changed

+24
-4
lines changed

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
VERSION=v0.0.204
1+
VERSION=v0.0.205
22

33
OUT_DIR=dist
44
YEAR?=$(shell date +"%Y")

cmd/commands/runtime.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1544,7 +1544,7 @@ func inferAPIURLForGitProvider(provider apmodel.GitProviders) (string, error) {
15441544
func postInstallationHandler(ctx context.Context, opts *RuntimeInstallOptions, err *error, r reporter.AnalyticsReporter) {
15451545
if *err != nil {
15461546
summaryArr = append(summaryArr, summaryLog{"----------Uninstalling runtime----------", Info})
1547-
log.G(ctx).Warn("installation failed, performing installation rollback")
1547+
log.G(ctx).Warnf("installation failed due to error : %s, performing installation rollback", (*err).Error())
15481548
err := RunRuntimeUninstall(ctx, &RuntimeUninstallOptions{
15491549
RuntimeName: opts.RuntimeName,
15501550
Timeout: store.Get().WaitTimeout,

docs/releases/release_notes.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ cf version
2323

2424
```bash
2525
# download and extract the binary
26-
curl -L --output - https://github.com/codefresh-io/cli-v2/releases/download/v0.0.204/cf-linux-amd64.tar.gz | tar zx
26+
curl -L --output - https://github.com/codefresh-io/cli-v2/releases/download/v0.0.205/cf-linux-amd64.tar.gz | tar zx
2727

2828
# move the binary to your $PATH
2929
mv ./cf-linux-amd64 /usr/local/bin/cf
@@ -36,7 +36,7 @@ cf version
3636

3737
```bash
3838
# download and extract the binary
39-
curl -L --output - https://github.com/codefresh-io/cli-v2/releases/download/v0.0.204/cf-darwin-amd64.tar.gz | tar zx
39+
curl -L --output - https://github.com/codefresh-io/cli-v2/releases/download/v0.0.205/cf-darwin-amd64.tar.gz | tar zx
4040

4141
# move the binary to your $PATH
4242
mv ./cf-darwin-amd64 /usr/local/bin/cf

manifests/argo-workflows/kustomization.yaml

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,26 @@ patches:
2424
path: /spec/template/spec/containers/0/args/-
2525
value: --auth-mode=server
2626
27+
patchesStrategicMerge:
28+
- |
29+
apiVersion: v1
30+
kind: ConfigMap
31+
metadata:
32+
name: workflow-controller-configmap
33+
data:
34+
# Fields reference can be found here: https://argoproj.github.io/argo-workflows/workflow-controller-configmap.yaml
35+
workflowDefaults: |
36+
spec:
37+
ttlStrategy:
38+
secondsAfterCompletion: 86400
39+
secondsAfterSuccess: 86400
40+
secondsAfterFailure: 86400
41+
podGC:
42+
strategy: OnWorkflowCompletion
43+
labelSelector:
44+
matchLabels:
45+
should-be-deleted: "true"
46+
2747
configMapGenerator:
2848
- name: workflow-controller-configmap
2949
behavior: merge

0 commit comments

Comments
 (0)