CR-10596 identifing certificate errors bug fix (#341)

* -identify all certificate errors
-small addition to error msg

* bump

Author: rotem-codefresh

Makefile

@@ -1,4 +1,4 @@
-VERSION=v0.0.305
+VERSION=v0.0.306
 
 OUT_DIR=dist
 YEAR?=$(shell date +"%Y")

cmd/commands/common.go

@@ -524,8 +524,9 @@ func checkIngressHostCertificate(ingress string) (bool, error) {
 	_, ok3 := urlErr.Err.(x509.UnknownAuthorityError)
 	_, ok4 := urlErr.Err.(x509.ConstraintViolationError)
 	_, ok5 := urlErr.Err.(x509.HostnameError)
+	ok6 := strings.Contains(urlErr.Err.Error(), "x509")
 
-	certErr := ok1 || ok2 || ok3 || ok4 || ok5
+	certErr := ok1 || ok2 || ok3 || ok4 || ok5 || ok6
 	if !certErr {
 		return false, fmt.Errorf("failed with non-certificate error: %w", err)
 	}
@@ -562,7 +563,7 @@ func askUserIfToProceedWithInsecure(ctx context.Context) error {
 	}
 
 	if store.Get().Silent {
-		return fmt.Errorf("cancelled installation due to invalid ingress host certificate")
+		return fmt.Errorf("cancelled installation due to invalid ingress host certificate. you can try again with --insecure-ingress-host")
 	}
 
 	templates := &promptui.SelectTemplates{

docs/releases/release_notes.md

@@ -23,7 +23,7 @@ cf version
 
 ```bash
 # download and extract the binary
-curl -L --output - https://github.com/codefresh-io/cli-v2/releases/download/v0.0.305/cf-linux-amd64.tar.gz | tar zx
+curl -L --output - https://github.com/codefresh-io/cli-v2/releases/download/v0.0.306/cf-linux-amd64.tar.gz | tar zx
 
 # move the binary to your $PATH
 mv ./cf-linux-amd64 /usr/local/bin/cf
@@ -36,7 +36,7 @@ cf version
 
 ```bash
 # download and extract the binary
-curl -L --output - https://github.com/codefresh-io/cli-v2/releases/download/v0.0.305/cf-darwin-amd64.tar.gz | tar zx
+curl -L --output - https://github.com/codefresh-io/cli-v2/releases/download/v0.0.306/cf-darwin-amd64.tar.gz | tar zx
 
 # move the binary to your $PATH
 mv ./cf-darwin-amd64 /usr/local/bin/cf

manifests/runtime.yaml

@@ -5,7 +5,7 @@ metadata:
   namespace: "{{ namespace }}"
 spec:
   defVersion: 1.0.1
-  version: 0.0.305
+  version: 0.0.306
   bootstrapSpecifier: github.com/codefresh-io/cli-v2/manifests/argo-cd
   components:
     - name: events