Skip to content

Commit 3db5e74

Browse files
bypass-ingress-class-check hidden flag (#222)
* added bypass-ingress-class-check hidden flag * bump * lint fix
1 parent 2ae3ab2 commit 3db5e74

File tree

6 files changed

+11
-6
lines changed

6 files changed

+11
-6
lines changed

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
VERSION=v0.0.202
1+
VERSION=v0.0.203
22

33
OUT_DIR=dist
44
YEAR?=$(shell date +"%Y")

cmd/commands/git-source.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -179,6 +179,8 @@ func NewGitSourceCreateCommand() *cobra.Command {
179179
}
180180

181181
cmd.Flags().BoolVar(&createRepo, "create-repo", false, "If true, will create the specified git-source repo in case it doesn't already exist")
182+
cmd.Flags().BoolVar(&store.Get().BypassIngressClassCheck, "bypass-ingress-class-check", false, "Disables the ingress class check during git-source installation")
183+
util.Die(cmd.Flags().MarkHidden("bypass-ingress-class-check"))
182184

183185
insCloneOpts = apu.AddCloneFlags(cmd, &apu.CloneFlagsOptions{})
184186
gsCloneOpts = apu.AddCloneFlags(cmd, &apu.CloneFlagsOptions{

cmd/commands/runtime.go

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -205,7 +205,8 @@ func NewRuntimeInstallCommand() *cobra.Command {
205205
cmd.Flags().BoolVar(&installationOpts.InstallDemoResources, "demo-resources", true, "Installs demo resources (default: true)")
206206
cmd.Flags().DurationVar(&store.Get().WaitTimeout, "wait-timeout", store.Get().WaitTimeout, "How long to wait for the runtime components to be ready")
207207
cmd.Flags().StringVar(&gitIntegrationOpts.APIURL, "provider-api-url", "", "Git provider API url")
208-
208+
cmd.Flags().BoolVar(&store.Get().BypassIngressClassCheck, "bypass-ingress-class-check", false, "Disables the ingress class check during pre-installation")
209+
209210
installationOpts.InsCloneOpts = apu.AddCloneFlags(cmd, &apu.CloneFlagsOptions{
210211
CreateIfNotExist: true,
211212
})
@@ -215,8 +216,9 @@ func NewRuntimeInstallCommand() *cobra.Command {
215216
CreateIfNotExist: true,
216217
})
217218
installationOpts.KubeFactory = kube.AddFlags(cmd.Flags())
218-
219+
219220
util.Die(cmd.MarkFlagRequired("ingress-host"))
221+
util.Die(cmd.Flags().MarkHidden("bypass-ingress-class-check"))
220222

221223
return cmd
222224
}

docs/releases/release_notes.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ cf version
2323

2424
```bash
2525
# download and extract the binary
26-
curl -L --output - https://github.com/codefresh-io/cli-v2/releases/download/v0.0.202/cf-linux-amd64.tar.gz | tar zx
26+
curl -L --output - https://github.com/codefresh-io/cli-v2/releases/download/v0.0.203/cf-linux-amd64.tar.gz | tar zx
2727

2828
# move the binary to your $PATH
2929
mv ./cf-linux-amd64 /usr/local/bin/cf
@@ -36,7 +36,7 @@ cf version
3636

3737
```bash
3838
# download and extract the binary
39-
curl -L --output - https://github.com/codefresh-io/cli-v2/releases/download/v0.0.202/cf-darwin-amd64.tar.gz | tar zx
39+
curl -L --output - https://github.com/codefresh-io/cli-v2/releases/download/v0.0.203/cf-darwin-amd64.tar.gz | tar zx
4040

4141
# move the binary to your $PATH
4242
mv ./cf-darwin-amd64 /usr/local/bin/cf

manifests/runtime.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ metadata:
55
namespace: "{{ namespace }}"
66
spec:
77
defVersion: 1.0.0
8-
version: 0.0.202
8+
version: 0.0.203
99
bootstrapSpecifier: github.com/codefresh-io/cli-v2/manifests/argo-cd
1010
components:
1111
- name: events

pkg/store/store.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -116,6 +116,7 @@ type Store struct {
116116
ArgoCD string
117117
Silent bool
118118
InsecureIngressHost bool
119+
BypassIngressClassCheck bool
119120
MinimumMemorySizeRequired string
120121
MinimumCpuRequired string
121122
MinimumLocalDiskSizeRequired string

0 commit comments

Comments
 (0)