Skip to content

Commit 2588bf3

Browse files
installation-mutation-separate-args (#116)
* bump * back to separate args * bump sdk
1 parent fc53d73 commit 2588bf3

File tree

6 files changed

+11
-17
lines changed

6 files changed

+11
-17
lines changed

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
VERSION=v0.0.107
1+
VERSION=v0.0.108
22
OUT_DIR=dist
33
YEAR?=$(shell date +"%Y")
44

cmd/commands/runtime.go

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -224,11 +224,11 @@ func getComponents(rt *runtime.Runtime, opts *RuntimeInstallOptions) []string {
224224
return componentNames
225225
}
226226

227-
func createRuntimeOnPlatform(ctx context.Context, opts *model.RuntimeInstallationArgs) (string, error) {
228-
runtimeCreationResponse, err := cfConfig.NewClient().V2().Runtime().Create(ctx, opts)
227+
func createRuntimeOnPlatform(ctx context.Context, runtimeName string, server string, runtimeVersion string, ingressHost string, componentNames []string) (string, error) {
228+
runtimeCreationResponse, err := cfConfig.NewClient().V2().Runtime().Create(ctx, runtimeName, server, runtimeVersion, ingressHost, componentNames)
229229

230230
if err != nil {
231-
return "", fmt.Errorf("failed to create a new runtime: %s. Error: %w", opts.RuntimeName, err)
231+
return "", fmt.Errorf("failed to create a new runtime: %s. Error: %w", runtimeName, err)
232232
}
233233

234234
return runtimeCreationResponse.NewAccessToken, nil
@@ -256,13 +256,7 @@ func RunRuntimeInstall(ctx context.Context, opts *RuntimeInstallOptions) error {
256256

257257
componentNames := getComponents(rt, opts)
258258

259-
token, err := createRuntimeOnPlatform(ctx, &model.RuntimeInstallationArgs{
260-
RuntimeName: opts.RuntimeName,
261-
Cluster: server,
262-
RuntimeVersion: runtimeVersion,
263-
IngressHost: &opts.IngressHost,
264-
ComponentNames: componentNames,
265-
})
259+
token, err := createRuntimeOnPlatform(ctx, opts.RuntimeName, server, runtimeVersion, opts.IngressHost, componentNames)
266260

267261
if err != nil {
268262
return fmt.Errorf("failed to create a new runtime: %w", err)

docs/releases/release_notes.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ cf version
2020
### Linux
2121
```bash
2222
# download and extract the binary
23-
curl -L --output - https://github.com/codefresh-io/cli-v2/releases/download/v0.0.107/cf-linux-amd64.tar.gz | tar zx
23+
curl -L --output - https://github.com/codefresh-io/cli-v2/releases/download/v0.0.108/cf-linux-amd64.tar.gz | tar zx
2424

2525
# move the binary to your $PATH
2626
mv ./cf-linux-amd64 /usr/local/bin/cf
@@ -32,7 +32,7 @@ cf version
3232
### Mac
3333
```bash
3434
# download and extract the binary
35-
curl -L --output - https://github.com/codefresh-io/cli-v2/releases/download/v0.0.107/cf-darwin-amd64.tar.gz | tar zx
35+
curl -L --output - https://github.com/codefresh-io/cli-v2/releases/download/v0.0.108/cf-darwin-amd64.tar.gz | tar zx
3636

3737
# move the binary to your $PATH
3838
mv ./cf-darwin-amd64 /usr/local/bin/cf

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ require (
1010
github.com/argoproj/argo-events v1.4.0
1111
github.com/argoproj/argo-workflows/v3 v3.1.6
1212
github.com/briandowns/spinner v1.16.0
13-
github.com/codefresh-io/go-sdk v0.34.7
13+
github.com/codefresh-io/go-sdk v0.34.8
1414
github.com/fatih/color v1.12.0
1515
github.com/ghodss/yaml v1.0.1-0.20190212211648-25d852aebe32
1616
github.com/go-git/go-billy/v5 v5.3.1

go.sum

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -266,8 +266,8 @@ github.com/clusterhq/flocker-go v0.0.0-20160920122132-2b8b7259d313/go.mod h1:P1w
266266
github.com/cncf/udpa/go v0.0.0-20191209042840-269d4d468f6f/go.mod h1:M8M6+tZqaGXZJjfX53e64911xZQV5JYwmTeXPW+k8Sc=
267267
github.com/cockroachdb/datadriven v0.0.0-20190809214429-80d97fb3cbaa/go.mod h1:zn76sxSg3SzpJ0PPJaLDCu+Bu0Lg3sKTORVIj19EIF8=
268268
github.com/codahale/hdrhistogram v0.0.0-20161010025455-3a0bb77429bd/go.mod h1:sE/e/2PUdi/liOCUjSTXgM1o87ZssimdTWN964YiIeI=
269-
github.com/codefresh-io/go-sdk v0.34.7 h1:KyVAHuYmlwp5hqTzEKc95CqggDZDcBRwfsL22fIxGIc=
270-
github.com/codefresh-io/go-sdk v0.34.7/go.mod h1:CcoVmTFWHGkbrSW8LyOGB/vJe5Vzr3iC/pNE2QIBTyg=
269+
github.com/codefresh-io/go-sdk v0.34.8 h1:ty8IIHgRb1m9gKCIMMMklKNPwRh3npVq6r4FFpEYwqw=
270+
github.com/codefresh-io/go-sdk v0.34.8/go.mod h1:CcoVmTFWHGkbrSW8LyOGB/vJe5Vzr3iC/pNE2QIBTyg=
271271
github.com/colinmarc/hdfs v1.1.4-0.20180802165501-48eb8d6c34a9/go.mod h1:0DumPviB681UcSuJErAbDIOx6SIaJWj463TymfZG02I=
272272
github.com/colinmarc/hdfs v1.1.4-0.20180805212432-9746310a4d31/go.mod h1:vSBumefK4HA5uiRSwNP+3ofgrEoScpCS2MMWcWXEuQ4=
273273
github.com/container-storage-interface/spec v1.3.0/go.mod h1:6URME8mwIBbpVyZV93Ce5St17xBiQJQY67NDsuohiy4=

manifests/runtime.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ metadata:
55
namespace: "{{ namespace }}"
66
spec:
77
defVersion: 1.0.0
8-
version: 0.0.107
8+
version: 0.0.108
99
bootstrapSpecifier: github.com/codefresh-io/cli-v2/manifests/argo-cd
1010
components:
1111
- name: events

0 commit comments

Comments
 (0)