Fix-argocd-username (#307)

* moved argoCdUsername to cm

* updated version to 0.0.284

* added oren and myself to codeowners

* removed double env vars

Author: ATGardner

CODEOWNERS

@@ -1,2 +1 @@
-* roi.kramer@codefresh.io
-/docs/releases/release_notes.md roi.kramer@codefresh.io
+* roi.kramer@codefresh.io noam.gal@codefresh.io oren.gurfinkel@codefresh.io

Makefile

@@ -1,4 +1,4 @@
-VERSION=v0.0.283
+VERSION=v0.0.284
 
 OUT_DIR=dist
 YEAR?=$(shell date +"%Y")

cmd/commands/runtime.go

@@ -1847,7 +1847,6 @@ func configureAppProxy(ctx context.Context, opts *RuntimeInstallOptions, rt *run
 		"argoWorkflowsInsecure=true",
 		fmt.Sprintf("cfHost=%s", cfConfig.GetCurrentContext().URL),
 		fmt.Sprintf("cors=%s", cfConfig.GetCurrentContext().URL),
-		"argoCdUsername=admin",
 		"env=production",
 	}
 

docs/releases/release_notes.md

@@ -23,7 +23,7 @@ cf version
 
 ```bash
 # download and extract the binary
-curl -L --output - https://github.com/codefresh-io/cli-v2/releases/download/v0.0.283/cf-linux-amd64.tar.gz | tar zx
+curl -L --output - https://github.com/codefresh-io/cli-v2/releases/download/v0.0.284/cf-linux-amd64.tar.gz | tar zx
 
 # move the binary to your $PATH
 mv ./cf-linux-amd64 /usr/local/bin/cf
@@ -36,7 +36,7 @@ cf version
 
 ```bash
 # download and extract the binary
-curl -L --output - https://github.com/codefresh-io/cli-v2/releases/download/v0.0.283/cf-darwin-amd64.tar.gz | tar zx
+curl -L --output - https://github.com/codefresh-io/cli-v2/releases/download/v0.0.284/cf-darwin-amd64.tar.gz | tar zx
 
 # move the binary to your $PATH
 mv ./cf-darwin-amd64 /usr/local/bin/cf

manifests/app-proxy/app-proxy.cm.yaml

@@ -2,3 +2,5 @@ apiVersion: v1
 kind: ConfigMap
 metadata:
   name: cap-app-proxy-cm
+data:
+  argoCdUsername: admin

manifests/app-proxy/app-proxy.deploy.yaml

@@ -108,18 +108,6 @@ spec:
                   name: codefresh-token
                   key: encryptionIV
                   optional: true
-            - name: ARGO_CD_TOKEN
-              valueFrom:
-                secretKeyRef:
-                  name: argocd-token
-                  key: token
-                  optional: true
-            - name: ARGO_CD_URL
-              valueFrom:
-                configMapKeyRef:
-                  name: cap-app-proxy-cm
-                  key: argoCDUrl
-                  optional: true
             - name: STORE_BACKEND
               valueFrom:
                 configMapKeyRef:

manifests/runtime.yaml

@@ -5,7 +5,7 @@ metadata:
   namespace: "{{ namespace }}"
 spec:
   defVersion: 1.0.1
-  version: 0.0.283
+  version: 0.0.284
   bootstrapSpecifier: github.com/codefresh-io/cli-v2/manifests/argo-cd
   components:
     - name: events