Skip to content

Commit 9fbeeee

Browse files
committed
refactor(secrets): replace request with got
1 parent a1bdf30 commit 9fbeeee

File tree

3 files changed

+195
-56
lines changed

3 files changed

+195
-56
lines changed

lib/addNewMask.js

Lines changed: 26 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -1,30 +1,32 @@
1-
const rp = require('request-promise');
21
const { secretsServerAddress } = require('./logger');
32

4-
function updateMasks(secret) {
5-
secretsServerAddress
6-
.then((address) => {
7-
const opts = {
8-
uri: `${address}/secrets`,
9-
method: 'POST',
10-
json: true,
11-
body: secret,
12-
resolveWithFullResponse: true,
13-
};
14-
return rp(opts);
15-
})
16-
.then((res) => {
17-
if (res.statusCode >= 400) {
18-
console.log(`could not create mask for secret: ${secret.key}, because server responded with: ${res.statusCode}\n\n${res.body}`);
19-
process.exit(1);
20-
}
21-
console.log(`successfully updated masks with secret: ${secret.key}`);
22-
process.exit(0);
23-
})
24-
.catch((err) => {
25-
console.log(`could not create mask for secret: ${secret.key}, due to error: ${err}`);
26-
process.exit(1);
3+
async function updateMasks(secret) {
4+
try {
5+
const serverAddress = await secretsServerAddress;
6+
console.log(`server address: ${serverAddress}`);
7+
8+
const { default: got } = await import('got');
9+
/** @type {import('got').Got} */
10+
const httpClient = got.extend({
11+
prefixUrl: serverAddress,
12+
responseType: 'json',
13+
throwHttpErrors: false,
2714
});
15+
const response = await httpClient.post(
16+
'secrets',
17+
{ json: secret },
18+
);
19+
20+
if (!response.ok) {
21+
console.error(`could not create mask for secret: ${secret.key}, because server responded with: ${response.statusCode}\n\n${JSON.stringify(response.body)}`);
22+
process.exit(1);
23+
}
24+
console.log(`successfully updated masks with secret: ${secret.key}`);
25+
process.exit(0);
26+
} catch (error) {
27+
console.log(`could not create mask for secret: ${secret.key}, due to error: ${error}`);
28+
process.exit(1);
29+
}
2830
}
2931

3032
if (require.main === module) {

package.json

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,10 @@
1717
"docker-events": "0.0.2",
1818
"dockerode": "^2.5.8",
1919
"fastify": "^4.28.1",
20+
"got": "^14.4.1",
2021
"lodash": "^4.17.21",
2122
"promise-retry": "^2.0.1",
22-
"q": "^1.5.1",
23-
"request": "^2.88.2",
24-
"request-promise": "^4.2.6"
23+
"q": "^1.5.1"
2524
},
2625
"devDependencies": {
2726
"chai": "^4.3.6",

0 commit comments

Comments
 (0)