build: upgrade eslint, clean up dev env

Author: masontikhonov

.dockerignore

@@ -1,6 +1,10 @@
 .git
 .gitignore
+.github
 node_modules
 logs/*.log
 lib/state.json
-*.md
+*.md
+.eslintrc.json
+test
+.eslintignore

.eslintrc renamed to .eslintrc.json

@@ -1,21 +1,20 @@
 {
-  "extends": "airbnb",
-  "ignorePatterns":[
-    "node_modules"
-  ],
+  "extends": "airbnb-base",
+
+  "env": {
+    "node": true,
+    "mocha": true,
+    "es6": true
+  },
+
   "parserOptions": {
-    "ecmaVersion": 2018,
+    "ecmaVersion": 2021,
     "sourceType": "script",
     "ecmaFeatures": {
       "impliedStrict": true
     }
   },
-
-  "env": {
-    "node": true,
-    "mocha": true
-  },
-
+  
   "plugins": [
     "chai-friendly",
     "import",
@@ -90,25 +89,5 @@
     "node/no-deprecated-api": "warn",
     "no-useless-constructor": "warn",
     "no-return-await": "off"
-  },
-  "overrides": [
-    {
-      "plugins": ["jest"],
-      "env": {
-        "jest": true
-      },
-      "files": [
-        "**/__tests__/**/*.[jt]s?(x)",
-        "__mocks__/**/*.js",
-        "**/__mocks__/**/*.js"
-      ],
-      "rules": {
-        "jest/no-disabled-tests": "warn",
-        "jest/no-focused-tests": "error",
-        "jest/no-identical-title": "error",
-        "jest/prefer-to-have-length": "warn",
-        "jest/valid-expect": "error"
-      }
-    }
-  ]
+  }
 }

lib/addNewMask.js

@@ -6,11 +6,12 @@ async function updateMasks(secret) {
         console.debug(`server address: ${serverAddress}`);
         const url = new URL('secrets', serverAddress);
 
+        // eslint-disable-next-line import/no-unresolved
         const { default: httpClient } = await import('got');
         const response = await httpClient.post(url, {
             json: secret,
         });
-    
+
         if (response.statusCode !== 201) {
             console.error(`could not create mask for secret: ${secret.key}, because server responded with: ${response.statusCode}\n\n${JSON.stringify(response.body)}`);
             process.exit(1);

lib/logger.js

@@ -187,9 +187,11 @@ class Logger {
         const receivedLoggerId = _.get(container, 'Labels', _.get(container, 'Actor.Attributes'))['io.codefresh.logger.id'];
         const runCreationLogic = _.get(container, 'Labels', _.get(container, 'Actor.Attributes'))['io.codefresh.runCreationLogic'];
         const stepName = _.get(container, 'Labels', _.get(container, 'Actor.Attributes'))['io.codefresh.logger.stepName'];
-        const receivedLogSizeLimit = _.get(container,
+        const receivedLogSizeLimit = _.get(
+            container,
             'Labels',
-            _.get(container, 'Actor.Attributes'))['io.codefresh.logger.logSizeLimit'];
+            _.get(container, 'Actor.Attributes')
+        )['io.codefresh.logger.logSizeLimit'];
         const loggerStrategy = _.get(container, 'Labels', _.get(container, 'Actor.Attributes'))['io.codefresh.logger.strategy'];
 
         if (!containerId) {

no-onlys.sh

@@ -24,15 +24,14 @@
   },
   "devDependencies": {
     "chai": "^4.4.1",
-    "eslint": "^7.32.0",
-    "eslint-config-airbnb": "^18.2.1",
-    "eslint-plugin-chai-friendly": "^0.6.0",
-    "eslint-plugin-import": "^2.25.4",
-    "eslint-plugin-jsx-a11y": "^6.5.1",
-    "eslint-plugin-mocha": "^8.2.0",
+    "eslint": "^8.57.0",
+    "eslint-config-airbnb-base": "^15.0.0",
+    "eslint-plugin-chai-friendly": "^1.0.0",
+    "eslint-plugin-import": "^2.29.1",
+    "eslint-plugin-jsx-a11y": "^6.9.0",
+    "eslint-plugin-mocha": "^10.4.3",
     "eslint-plugin-node": "^11.1.0",
-    "eslint-plugin-promise": "^4.3.1",
-    "eslint-plugin-react": "^7.29.4",
+    "eslint-plugin-promise": "^6.4.0",
     "isparta": "^4.1.1",
     "mocha": "^10.6.0",
     "proxyquire": "^1.8.0",