Merge pull request #15 from codeforkjeff/fix-detach

check if schema exists before calling DETACH DATABASE

Author: codeforkjeff

dbt/adapters/sqlite/impl.py

@@ -244,6 +244,11 @@ def timestamp_add_sql(
     def drop_schema(self, relation: BaseRelation) -> None:
         super().drop_schema(relation)
 
+        # can't detach a databse in the middle of a transaction, so commit first.
+        # I wonder if drop_schema() in SQLAdapter should do this, since create_schema() does.
+        self.commit_if_has_connection()
+
         # never detach main
         if relation.schema != 'main':
-            self.connections.execute(f"DETACH DATABASE {relation.schema}")
+            if self.check_schema_exists(relation.database, relation.schema):
+                self.connections.execute(f"DETACH DATABASE {relation.schema}")