Skip to content

Commit 79fa6c5

Browse files
Fixes is_newer when non-int passed (#61)
* fixes is_newer when non-int passed * ref update * update ref * Submodules merge --------- Co-authored-by: Lina <lina.lumburovska@kern.ai>
1 parent a59f82e commit 79fa6c5

File tree

2 files changed

+10
-3
lines changed

2 files changed

+10
-3
lines changed

upgrade_logic/base_logic.py

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,13 +55,20 @@ def __function_is_relevant(
5555

5656
# v1 newer than v2 (e.g. 1.1.2 > 1.1.1)
5757
def is_newer(v1: str, v2: str) -> bool:
58-
a = [int(x) for x in v1.split(".")]
59-
b = [int(x) for x in v2.split(".")]
58+
a = [__get_int_from_string(x) for x in v1.split(".")]
59+
b = [__get_int_from_string(x) for x in v2.split(".")]
6060
if len(a) != len(b) and len(a) != 3:
6161
raise Exception("invalid version format")
6262
return __is_newer_int(a, b)
6363

6464

65+
def __get_int_from_string(value: str) -> int:
66+
try:
67+
return int(value)
68+
except ValueError:
69+
return 0
70+
71+
6572
def __is_newer_int(v1: List[int], v2: List[int]) -> bool:
6673
for idx, _ in enumerate(v1):
6774
if v2[idx] > v1[idx]:

0 commit comments

Comments
 (0)