add subnets to ecs service

Author: cat5inthecradle

cicd/3-app/aiproxy/template.yml

@@ -60,7 +60,9 @@ Resources:
       SecurityGroups:
         - !ImportValue VPC-ELBSecurityGroup
       Subnets:
-        # TODO: This copies geocoder and the code.org load balancer, but we may prefer something unique
+        # Place load balancer in public subnets, so it's accessible from the internet.
+        # We may want to move this to the private subnets, so only internal resources
+        # can access it, but this is very convenient for local development.
         - !ImportValue VPC-PublicSubnetB
         - !ImportValue VPC-PublicSubnetC
         - !ImportValue VPC-PublicSubnetD
@@ -134,9 +136,11 @@ Resources:
           SecurityGroups: 
             - !Ref ECSSecurityGroup
           Subnets:
-            # TODO: This copies geocoder, but we should probably have a separate subnet for this service.
+            # Place ECS Service in private subnets, but traffic should use the LoadBalancer.
             - !ImportValue VPC-SubnetB
             - !ImportValue VPC-SubnetC
+            - !ImportValue VPC-SubnetD
+            - !ImportValue VPC-SubnetE
       LoadBalancers:
         - ContainerName: aiproxy
           ContainerPort: 80