Skip to content

Commit 7801c7d

Browse files
committed
confirm support for CockroachDB 25.2
1 parent b0ca2a7 commit 7801c7d

File tree

4 files changed

+26
-1
lines changed

4 files changed

+26
-1
lines changed

.github/workflows/tests.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,11 @@ jobs:
4949
use_psycopg2: psycopg2
5050
- crdb-version: v25.1.2
5151
use_server_side_binding: server_side_binding
52+
- crdb-version: v25.2.0
53+
- crdb-version: v25.2.0
54+
use_psycopg2: psycopg2
55+
- crdb-version: v25.2.0
56+
use_server_side_binding: server_side_binding
5257
# Uncomment to enable testing of CockroachDB nightly.
5358
#- crdb-version: LATEST
5459
#- crdb-version: LATEST

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
# Changelog
22

3+
## 5.2.1 - Unreleased
4+
5+
- Confirmed support for CockroachDB 25.2.x (no code changes required).
6+
37
## 5.2 - 2025-04-07
48

59
Initial release for Django 5.2.x and CockroachDB 23.2.x, 24.1.x, 24.3.x, and

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ By default, CockroachDB sends the version of django-cockroachdb that you're
9292
using back to Cockroach Labs. To disable this, set
9393
`DISABLE_COCKROACHDB_TELEMETRY = True` in your Django settings.
9494

95-
## Known issues and limitations in CockroachDB 25.1.x and earlier
95+
## Known issues and limitations in CockroachDB 25.2.x and earlier
9696

9797
- CockroachDB [can't disable constraint checking](https://github.com/cockroachdb/cockroach/issues/19444),
9898
which means certain things in Django like forward references in fixtures

django_cockroachdb/features.py

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,10 @@ def is_cockroachdb_24_3(self):
8787
def is_cockroachdb_25_1(self):
8888
return self.connection.cockroachdb_version >= (25, 1)
8989

90+
@cached_property
91+
def is_cockroachdb_25_2(self):
92+
return self.connection.cockroachdb_version >= (25, 2)
93+
9094
@cached_property
9195
def django_test_expected_failures(self):
9296
expected_failures = super().django_test_expected_failures
@@ -287,6 +291,18 @@ def django_test_expected_failures(self):
287291
# data type of placeholder $1
288292
'expressions_case.tests.CaseExpressionTests.test_filter_with_expression_as_condition',
289293
})
294+
if self.is_cockroachdb_25_2:
295+
expected_failures.update({
296+
# concat(): error type checking resolved expression::
297+
# could not determine data type of placeholder $1
298+
'aggregation_regress.tests.AggregationTests.test_aggregate_group_by_unseen_columns_unmanaged',
299+
'db_functions.text.test_concat.ConcatTests.test_many',
300+
'db_functions.text.test_concat.ConcatTests.test_mixed_char_text',
301+
'db_functions.text.test_replace.ReplaceTests.test_replace_expression',
302+
'expressions.tests.BasicExpressionsTests.test_slicing_of_f_expression_with_annotated_expression',
303+
'filtered_relation.tests.FilteredRelationTests.test_condition_with_func_and_lookup_outside_relation_name', # noqa
304+
'select_for_update.tests.SelectForUpdateTests.test_for_update_of_values_list',
305+
})
290306
else:
291307
expected_failures.update({
292308
# Unsupported query: unsupported binary operator: <int> / <int>:

0 commit comments

Comments
 (0)