drop support for CockroachDB 23.2

Author: timgraham

.github/workflows/tests.yml

@@ -29,11 +29,6 @@ jobs:
       fail-fast: false
       matrix:
         include:
-          - crdb-version: v23.2.21
-          - crdb-version: v23.2.21
-            use_psycopg2: psycopg2
-          - crdb-version: v23.2.21
-            use_server_side_binding: server_side_binding
           - crdb-version: v24.1.14
           - crdb-version: v24.1.14
             use_psycopg2: psycopg2

django_cockroachdb/features.py

@@ -5,7 +5,7 @@
 
 
 class DatabaseFeatures(PostgresDatabaseFeatures):
-    minimum_database_version = (23, 2)
+    minimum_database_version = (24, 1)
 
     # Cloning databases doesn't speed up tests.
     # https://github.com/cockroachdb/django-cockroachdb/issues/206
@@ -75,10 +75,6 @@ def introspected_field_types(self):
         'virtual': None,
     }
 
-    @cached_property
-    def is_cockroachdb_24_1(self):
-        return self.connection.cockroachdb_version >= (24, 1)
-
     @cached_property
     def is_cockroachdb_24_3(self):
         return self.connection.cockroachdb_version >= (24, 3)
@@ -181,6 +177,10 @@ def django_test_expected_failures(self):
             # new primary key in same transaction
             'schema.tests.SchemaTests.test_add_auto_field',
             'schema.tests.SchemaTests.test_autofield_to_o2o',
+            # USING cast required: https://github.com/cockroachdb/cockroach/issues/82416#issuecomment-2029803229
+            'schema.tests.SchemaTests.test_alter_text_field_to_date_field',
+            'schema.tests.SchemaTests.test_alter_text_field_to_datetime_field',
+            'schema.tests.SchemaTests.test_alter_text_field_to_time_field',
             # incompatible COALESCE expressions: unsupported binary operator:
             # <int> * <int> (desired <decimal>):
             # https://github.com/cockroachdb/cockroach/issues/73587
@@ -202,13 +202,6 @@ def django_test_expected_failures(self):
                 # concat(): unknown signature: concat(string, int2) (desired <string>)
                 'db_functions.text.test_concat.ConcatTests.test_concat_non_str',
             })
-        if self.is_cockroachdb_24_1:
-            # USING cast required: https://github.com/cockroachdb/cockroach/issues/82416#issuecomment-2029803229
-            expected_failures.update({
-                'schema.tests.SchemaTests.test_alter_text_field_to_date_field',
-                'schema.tests.SchemaTests.test_alter_text_field_to_datetime_field',
-                'schema.tests.SchemaTests.test_alter_text_field_to_time_field',
-            })
         if self.is_cockroachdb_25_1:
             expected_failures.update({
                 # expected STORED COMPUTED COLUMN expression to have type

django_cockroachdb_gis/features.py

@@ -1,7 +1,6 @@
 from django.contrib.gis.db.backends.postgis.features import (
     DatabaseFeatures as PostGISFeatures,
 )
-from django.db.backends.postgresql.psycopg_any import is_psycopg3
 from django.utils.functional import cached_property
 
 from django_cockroachdb.features import DatabaseFeatures as CockroachFeatures
@@ -74,15 +73,6 @@ def django_test_expected_failures(self):
             # https://github.com/cockroachdb/cockroach/issues/47420#issuecomment-969578772
             'gis_tests.gis_migrations.test_operations.OperationTests.test_add_3d_field_opclass',
         })
-        if is_psycopg3 and not self.is_cockroachdb_24_1:
-            expected_failures.update({
-                # QuerySet.bulk_create() doesn't work with geometries after
-                # https://github.com/django/django/commit/a16eedcf9c69d8a11d94cac1811018c5b996d491
-                # could not parse geometry: error parsing EWKB hex: encoding/hex:
-                # invalid byte: U+003A ':'
-                # https://github.com/cockroachdb/cockroach/issues/138140
-                'gis_tests.geoapp.test_functions.GISFunctionsTests.test_area_lookups',
-            })
         if self.uses_server_side_binding:
             expected_failures.update({
                 # unknown signature: st_scale(geometry, int, int)