refactor: enable @typescript-eslint/no-floating-promises check

laggage · laggage · commit d1510d89d0a8 · 2022-04-01T18:49:20.000+08:00
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -3,7 +3,8 @@
     "parser": "@typescript-eslint/parser",
     "parserOptions": {
         "ecmaVersion": 6,
-        "sourceType": "module"
+        "sourceType": "module",
+        "project": ["./tsconfig.json", "./ui/tsconfig.json"]
     },
     "plugins": ["@typescript-eslint"],
     "extends": "eslint:recommended",
@@ -15,7 +16,8 @@
         "no-throw-literal": "warn",
         "semi": "warn",
         "require-await": "warn",
-        "no-undef": "off"
+        "no-undef": "off",
+        "@typescript-eslint/no-floating-promises": "warn"
     },
-    "ignorePatterns": ["out", "dist", "**/*.d.ts"]
+    "ignorePatterns": ["out", "dist", "src/test/**", "**/*.d.ts"]
 }
diff --git a/.vscode/settings.json b/.vscode/settings.json
@@ -12,5 +12,10 @@
     "typescript.tsc.autoDetect": "off",
     "editor.formatOnSave": true,
     "cSpell.words": ["ASPNETCORE", "fluentui", "randomstring", "tailwindcss"],
-    "json.format.enable": false
+    "json.format.enable": false,
+    "eslint.alwaysShowStatus": true,
+    "eslint.lintTask.enable": true,
+    "eslint.run": "onType",
+    "eslint.debug": false,
+    "eslint.format.enable": true
 }
diff --git a/src/commands/login.ts b/src/commands/login.ts
@@ -1,9 +1,9 @@
 import { accountService } from '../services/account.service';
 
 export const login = () => {
-    accountService.login();
+    return accountService.login();
 };
 
 export const logout = () => {
-    accountService.logout();
+    return accountService.logout();
 };
diff --git a/src/commands/open-my-account-settings.ts b/src/commands/open-my-account-settings.ts
@@ -1,5 +1,8 @@
 import vscode from 'vscode';
 
 export const openMyAccountSettings = () => {
-    vscode.commands.executeCommand('vscode.open', vscode.Uri.parse('https://account.cnblogs.com/settings/account'));
+    return vscode.commands.executeCommand(
+        'vscode.open',
+        vscode.Uri.parse('https://account.cnblogs.com/settings/account')
+    );
 };
diff --git a/src/commands/open-my-blog-management-background.ts b/src/commands/open-my-blog-management-background.ts
@@ -1,5 +1,5 @@
 import vscode from 'vscode';
 
 export const openMyWebBlogConsole = () => {
-    vscode.commands.executeCommand('vscode.open', vscode.Uri.parse('https://i.cnblogs.com'));
+    return vscode.commands.executeCommand('vscode.open', vscode.Uri.parse('https://i.cnblogs.com'));
 };
diff --git a/src/commands/open-my-blog.ts b/src/commands/open-my-blog.ts
@@ -4,6 +4,6 @@ import vscode from 'vscode';
 export const openMyBlog = () => {
     const userBlogUrl = accountService.curUser?.website;
     if (userBlogUrl) {
-        vscode.commands.executeCommand('vscode.open', vscode.Uri.parse(userBlogUrl));
+        return vscode.commands.executeCommand('vscode.open', vscode.Uri.parse(userBlogUrl));
     }
 };
diff --git a/src/commands/open-my-home-page.ts b/src/commands/open-my-home-page.ts
@@ -8,6 +8,6 @@ export const openMyHomePage = () => {
     }
     const userHomePageUrl = `https://home.cnblogs.com/u/${accountId}`;
     if (userHomePageUrl) {
-        vscode.commands.executeCommand('vscode.open', vscode.Uri.parse(userHomePageUrl));
+        void vscode.commands.executeCommand('vscode.open', vscode.Uri.parse(userHomePageUrl));
     }
 };
diff --git a/src/commands/open-post-in-blog-admin.ts b/src/commands/open-post-in-blog-admin.ts
@@ -9,5 +9,5 @@ export const openPostInBlogAdmin = (item: Post | Uri) => {
 
     const postId = item instanceof Post ? item.id : PostFileMapManager.getPostId(item.fsPath) ?? -1;
 
-    commands.executeCommand('vscode.open', Uri.parse(`https://i.cnblogs.com/posts/edit;postId=${postId}`));
+    void commands.executeCommand('vscode.open', Uri.parse(`https://i.cnblogs.com/posts/edit;postId=${postId}`));
 };
diff --git a/src/commands/pdf/export-pdf.command.ts b/src/commands/pdf/export-pdf.command.ts
@@ -124,7 +124,7 @@ const retrieveChromiumPath = async (): Promise<string | undefined> => {
     }
 
     if (path && path !== Settings.chromiumPath) {
-        Settings.setChromiumPath(path);
+        await Settings.setChromiumPath(path);
     }
 
     return path;
@@ -178,7 +178,7 @@ const mapToPostEditDto = async (posts: Post[]) =>
 
 const reportErrors = (errors: string[] | undefined) => {
     if (errors && errors.length > 0) {
-        window.showErrorMessage('导出pdf时遇到错误', { modal: true, detail: errors.join('\n') } as MessageOptions);
+        void window.showErrorMessage('导出pdf时遇到错误', { modal: true, detail: errors.join('\n') } as MessageOptions);
     }
 };
 
diff --git a/src/commands/post-category/new-post-category.ts b/src/commands/post-category/new-post-category.ts
@@ -11,7 +11,7 @@ export const newPostCategory = async () => {
     if (!input) {
         return;
     }
-    window.withProgress(
+    await window.withProgress(
         {
             title: '正在新建博文分类',
             location: ProgressLocation.Notification,
@@ -25,13 +25,13 @@ export const newPostCategory = async () => {
                 p.report({
                     increment: 90,
                 });
-                await refreshPostCategoriesList();
+                refreshPostCategoriesList();
                 const newCategory = (await postCategoryService.fetchCategories()).find(x => x.title === input.title);
                 if (newCategory) {
                     await extensionViews.postCategoriesList?.reveal(newCategory);
                 }
             } catch (err) {
-                window.showErrorMessage('新建博文分类时遇到了错误', {
+                void window.showErrorMessage('新建博文分类时遇到了错误', {
                     modal: true,
                     detail: `服务器反回了错误\n${err instanceof Error ? err.message : JSON.stringify(err)}`,
                 } as MessageOptions);
diff --git a/src/commands/post-category/update-post-category.ts b/src/commands/post-category/update-post-category.ts
@@ -9,7 +9,7 @@ export const updatePostCategory = async (category?: PostCategory) => {
     if (!category) {
         return;
     }
-    extensionViews.postCategoriesList?.reveal(category);
+    await extensionViews.postCategoriesList?.reveal(category);
     const addDto = await inputPostCategory({
         title: '编辑博文分类',
         category,
@@ -33,7 +33,7 @@ export const updatePostCategory = async (category?: PostCategory) => {
                 await postCategoryService.updateCategory(updateDto);
                 refreshPostCategoriesList();
             } catch (err) {
-                window.showErrorMessage('更新博文分类失败', {
+                void window.showErrorMessage('更新博文分类失败', {
                     detail: `服务器反回了错误, ${err instanceof Error ? err.message : JSON.stringify(err)}`,
                     modal: true,
                 } as MessageOptions);
diff --git a/src/commands/posts-list/delete-local-draft.ts b/src/commands/posts-list/delete-local-draft.ts
@@ -22,8 +22,8 @@ export const deleteLocalDraft = async (targetFile: LocalFileService) => {
         placeHolder: options.join('/'),
     });
     if (picked === options[0]) {
-        const deleteTasks: Thenable<any>[] = [];
-        extensionViews.postsList?.reveal(localDraftsTreeItem);
+        const deleteTasks: Thenable<unknown>[] = [];
+        void extensionViews.postsList?.reveal(localDraftsTreeItem);
         files.forEach(f => {
             deleteTasks.push(workspace.fs.delete(Uri.file(f.filePath), { useTrash: true }));
         });
diff --git a/src/commands/posts-list/delete-post.ts b/src/commands/posts-list/delete-post.ts
@@ -74,17 +74,13 @@ export const deleteSelectedPosts = async (post: Post) => {
                     .map(p => PostFileMapManager.getFilePath(p.id) ?? '')
                     .filter(x => !!x)
                     .forEach(path => {
-                        try {
-                            workspace.fs.delete(Uri.file(path));
-                        } catch (err) {
-                            console.error(err);
-                        }
+                        workspace.fs.delete(Uri.file(path)).then(undefined, ex => console.error(ex));
                     });
             }
             await PostFileMapManager.updateOrCreateMany(...selectedPosts.map<PostFileMap>(p => [p.id, '']));
             await refreshPostsList();
         } catch (err) {
-            window.showErrorMessage('删除博文失败', {
+            void window.showErrorMessage('删除博文失败', {
                 detail: `服务器返回了错误, ${err instanceof Error ? err.message : JSON.stringify(err)}`,
             } as MessageOptions);
         } finally {
diff --git a/src/commands/posts-list/rename-post.ts b/src/commands/posts-list/rename-post.ts
@@ -73,7 +73,7 @@ export const renamePost = async (post: Post) => {
                 postsDataProvider.fireTreeDataChangedEvent(post);
                 success = true;
             } catch (err) {
-                window.showInformationMessage('更新博文失败', {
+                void window.showInformationMessage('更新博文失败', {
                     modal: true,
                     detail: err instanceof Error ? err.message : '服务器返回了异常',
                 } as MessageOptions);
diff --git a/src/commands/posts-list/save-post.ts b/src/commands/posts-list/save-post.ts
@@ -59,7 +59,7 @@ export const savePostFileToCnblogs = async (fileUri: Uri | undefined) => {
                         quickPickTitle: '搜索要关联的博文',
                     });
                     if (selectedPost) {
-                        PostFileMapManager.updateOrCreate(selectedPost.id, filePath);
+                        await PostFileMapManager.updateOrCreate(selectedPost.id, filePath);
                         const postEditDto = await postService.fetchPostEditDto(selectedPost.id);
                         if (postEditDto) {
                             const fileContent = new TextDecoder().decode(await workspace.fs.readFile(fileUri));
@@ -98,7 +98,7 @@ export const saveLocalDraftToCnblogs = async (localDraft: LocalFileService) => {
     post.title = localDraft.fileNameWithoutExt;
     post.isMarkdown = true;
     post.categoryIds ??= [];
-    postConfigurationPanel.open(
+    void postConfigurationPanel.open(
         {
             panelTitle: '',
             breadcrumbs: ['新建博文', '博文设置', post.title],
diff --git a/src/commands/reveal-local-post-file-in-os.ts b/src/commands/reveal-local-post-file-in-os.ts
@@ -11,5 +11,5 @@ export const revealLocalPostFileInOs = (post: Post) => {
         return;
     }
 
-    commands.executeCommand('revealFileInOS', Uri.file(postFilePath));
+    return commands.executeCommand('revealFileInOS', Uri.file(postFilePath));
 };
diff --git a/src/commands/reveal-workspace-in-os.ts b/src/commands/reveal-workspace-in-os.ts
@@ -2,5 +2,5 @@ import { commands } from 'vscode';
 import { Settings } from '../services/settings.service';
 
 export const revealWorkspaceInOs = () => {
-    commands.executeCommand('revealFileInOS', Settings.workspaceUri);
+    return commands.executeCommand('revealFileInOS', Settings.workspaceUri);
 };
diff --git a/src/commands/upload-image/upload-clipboard-image.ts b/src/commands/upload-image/upload-clipboard-image.ts
@@ -23,7 +23,7 @@ export const uploadImageFromClipboard = async () => {
         );
     } finally {
         if (!clipboardImage.shouldKeepAfterUploading) {
-            workspace.fs.delete(Uri.file(clipboardImage.imgPath));
+            await workspace.fs.delete(Uri.file(clipboardImage.imgPath));
         }
     }
 };
diff --git a/src/commands/upload-image/upload-image-utils.ts b/src/commands/upload-image/upload-image-utils.ts
@@ -30,7 +30,7 @@ export const showUploadSuccessModel = async (imgLink: string): Promise<void> =>
             break;
     }
     if (formattedImageLink) {
-        env.clipboard.writeText(formattedImageLink);
+        await env.clipboard.writeText(formattedImageLink);
     }
 };
 
diff --git a/src/extension.ts b/src/extension.ts
@@ -14,7 +14,7 @@ import {
 // your extension is activated the very first time the command is executed
 export function activate(context: vscode.ExtensionContext) {
     globalState.extensionContext = context;
-    accountService.setIsAuthorizedToContext();
+    void accountService.setIsAuthorizedToContext();
     context.subscriptions.push(accountService);
 
     registerCommands();
diff --git a/src/services/account.service.ts b/src/services/account.service.ts
@@ -21,8 +21,7 @@ export class AccountService extends vscode.Disposable {
         accessToken ??= this.curUser.authorizationInfo?.accessToken;
         let expired = checkIsAccessTokenExpired(accessToken!);
         if (expired) {
-            this.logout();
-            this.alertLoginStatusExpired();
+            void Promise.all([this.logout(), this.alertLoginStatusExpired()]);
         }
         return ['Authorization', `Bearer ${expired ? '' : accessToken}`];
     }
@@ -50,7 +49,7 @@ export class AccountService extends vscode.Disposable {
         const { codeVerifier, codeChallenge } = generateCodeChallenge();
         this._oauthServ.startListenAuthorizationCodeCallback(codeVerifier, (authorizationInfo, err) => {
             if (authorizationInfo && !err) {
-                this.handleAuthorized(authorizationInfo);
+                return this.handleAuthorized(authorizationInfo);
             }
         });
         const { clientId, responseType, scope, authorizeEndpoint, authority, clientSecret } = globalState.config.oauth;
@@ -126,7 +125,7 @@ export class AccountService extends vscode.Disposable {
 
     private async setIsAuthorized(authorized = false): Promise<void> {
         await globalState.storage.update(isAuthorizedStorageKey, authorized);
-        this.setIsAuthorizedToContext();
+        await this.setIsAuthorizedToContext();
     }
 
     private async handleAuthorized(authorizationInfo: UserAuthorizationInfo) {
diff --git a/src/services/alert.service.ts b/src/services/alert.service.ts
@@ -2,14 +2,14 @@ import vscode from 'vscode';
 
 export class AlertService {
     static error(message: string) {
-        vscode.window.showErrorMessage(message);
+        void vscode.window.showErrorMessage(message);
     }
 
     static info(message: string) {
-        vscode.window.showInformationMessage(message);
+        void vscode.window.showInformationMessage(message);
     }
 
     static warning(message: string) {
-        vscode.window.showWarningMessage(message);
+        void vscode.window.showWarningMessage(message);
     }
 }
diff --git a/src/services/check-workspace.ts b/src/services/check-workspace.ts
@@ -7,7 +7,7 @@ import { Settings } from './settings.service';
 export const isTargetWorkspace = (): boolean => {
     const folders = workspace.workspaceFolders;
     const result = !!folders && folders.length === 1 && folders[0].uri.path === Settings.workspaceUri.path;
-    commands.executeCommand('setContext', `${globalState.extensionName}.isTargetWorkspace`, result);
+    void commands.executeCommand('setContext', `${globalState.extensionName}.isTargetWorkspace`, result);
     return result;
 };
 
@@ -32,7 +32,7 @@ export const observeWorkspaceFolderAndFileChange = () => {
                 const { oldUri, newUri } = item;
                 const postId = PostFileMapManager.getPostId(oldUri.fsPath);
                 if (postId !== undefined) {
-                    PostFileMapManager.updateOrCreate(postId, newUri.fsPath);
+                    void PostFileMapManager.updateOrCreate(postId, newUri.fsPath);
                 }
             }
         }),
diff --git a/src/services/cnblogs-oauth.service.ts b/src/services/cnblogs-oauth.service.ts
@@ -38,9 +38,9 @@ export class CnblogsOAuthService extends Disposable {
         this._app.get(['/', '/callback'], async (req, res) => {
             const authorizationInfo = await this.handleOAuthRedirect(req, res);
             if (authorizationInfo instanceof UserAuthorizationInfo) {
-                callback(authorizationInfo);
+                await callback(authorizationInfo);
             } else {
-                callback(undefined, authorizationInfo);
+                await callback(undefined, authorizationInfo);
             }
         });
     }
diff --git a/src/services/multi-step-input.ts b/src/services/multi-step-input.ts
@@ -119,12 +119,12 @@ export class MultiStepInput {
                     }),
                     input.onDidChangeValue(() => {
                         if (onValueChange) {
-                            onValueChange(input);
+                            void onValueChange(input);
                         }
                     }),
                     input.onDidChangeSelection(() => {
                         if (onSelectionChange) {
-                            onSelectionChange(input);
+                            void onSelectionChange(input);
                         }
                     }),
                     input.onDidHide(() => {
diff --git a/src/services/post-configuration-panel.service.ts b/src/services/post-configuration-panel.service.ts
@@ -62,11 +62,11 @@ export namespace postConfigurationPanel {
         }
         panel = await createPanel(panelTitle, post);
         const { webview } = panel;
-        webview.postMessage({
+        await webview.postMessage({
             command: webviewCommand.UiCommands.setFluentIconBaseUrl,
             baseUrl: webview.asWebviewUri(Uri.joinPath(resourceRootUri(), 'fonts')).toString() + '/',
         } as webviewMessage.SetFluentIconBaseUrlMessage);
-        webview.postMessage({
+        await webview.postMessage({
             command: webviewCommand.UiCommands.editPostConfiguration,
             post: cloneDeep(post),
             activeTheme: vscode.window.activeColorTheme.kind,
@@ -96,7 +96,7 @@ export namespace postConfigurationPanel {
                             successCallback(Object.assign({}, postToUpdate, postSavedModel));
                         } catch (err) {
                             if (isErrorResponse(err)) {
-                                webview.postMessage({
+                                await webview.postMessage({
                                     command: webviewCommand.UiCommands.showErrorResponse,
                                     errorResponse: err,
                                 } as webviewMessage.ShowErrorResponseMessage);
@@ -136,7 +136,7 @@ export namespace postConfigurationPanel {
         try {
             const { breadcrumbs } = options;
             const { webview } = panel;
-            webview.postMessage({
+            void webview.postMessage({
                 command: webviewCommand.UiCommands.updateBreadcrumbs,
                 breadcrumbs,
             } as webviewMessage.UpdateBreadcrumbsMessage);
@@ -166,7 +166,7 @@ export namespace postConfigurationPanel {
     ) => {
         if (panel) {
             const { webview } = panel;
-            webview.postMessage({
+            await webview.postMessage({
                 command: webviewCommand.UiCommands.updateImageUploadStatus,
                 status: {
                     id: ImageUploadStatusId.uploading,
@@ -175,7 +175,7 @@ export namespace postConfigurationPanel {
             } as webviewMessage.UpdateImageUpdateStatusMessage);
             try {
                 const imageUrl = await uploadImage(false);
-                webview.postMessage({
+                await webview.postMessage({
                     command: webviewCommand.UiCommands.updateImageUploadStatus,
                     status: {
                         imageUrl,
@@ -185,7 +185,7 @@ export namespace postConfigurationPanel {
                 } as webviewMessage.UpdateImageUpdateStatusMessage);
             } catch (err) {
                 if (isErrorResponse(err)) {
-                    webview.postMessage({
+                    await webview.postMessage({
                         command: webviewCommand.UiCommands.updateImageUploadStatus,
                         status: {
                             id: ImageUploadStatusId.failed,
diff --git a/src/services/search-post-by-title.ts b/src/services/search-post-by-title.ts
diff --git a/src/tree-view-providers/categories-view-data-provider.ts b/src/tree-view-providers/categories-view-data-provider.ts
diff --git a/src/tree-view-providers/posts-data-provider.ts b/src/tree-view-providers/posts-data-provider.ts
diff --git a/src/utils/chromium-path-provider.ts b/src/utils/chromium-path-provider.ts
diff --git a/ui/tsconfig.json b/ui/tsconfig.json

Original file line number	Diff line number	Diff line change
`@@ -4,6 +4,6 @@ import vscode from 'vscode';`
`4`	`4`	`export const openMyBlog = () => {`
`5`	`5`	`const userBlogUrl = accountService.curUser?.website;`
`6`	`6`	`if (userBlogUrl) {`
`7`		`- vscode.commands.executeCommand('vscode.open', vscode.Uri.parse(userBlogUrl));`
	`7`	`+ return vscode.commands.executeCommand('vscode.open', vscode.Uri.parse(userBlogUrl));`
`8`	`8`	`}`
`9`	`9`	`};`
Original file line number	Diff line number	Diff line change
`@@ -8,6 +8,6 @@ export const openMyHomePage = () => {`
`8`	`8`	`}`
`9`	`9`	const userHomePageUrl = `https://home.cnblogs.com/u/${accountId}`;
`10`	`10`	`if (userHomePageUrl) {`
`11`		`- vscode.commands.executeCommand('vscode.open', vscode.Uri.parse(userHomePageUrl));`
	`11`	`+ void vscode.commands.executeCommand('vscode.open', vscode.Uri.parse(userHomePageUrl));`
`12`	`12`	`}`
`13`	`13`	`};`
Original file line number	Diff line number	Diff line change
`@@ -124,7 +124,7 @@ const retrieveChromiumPath = async (): Promise<string \| undefined> => {`
`124`	`124`	`}`
`125`	`125`
`126`	`126`	`if (path && path !== Settings.chromiumPath) {`
`127`		`- Settings.setChromiumPath(path);`
	`127`	`+ await Settings.setChromiumPath(path);`
`128`	`128`	`}`
`129`	`129`
`130`	`130`	`return path;`
`@@ -178,7 +178,7 @@ const mapToPostEditDto = async (posts: Post[]) =>`
`178`	`178`
`179`	`179`	`const reportErrors = (errors: string[] \| undefined) => {`
`180`	`180`	`if (errors && errors.length > 0) {`
`181`		`- window.showErrorMessage('导出pdf时遇到错误', { modal: true, detail: errors.join('\n') } as MessageOptions);`
	`181`	`+ void window.showErrorMessage('导出pdf时遇到错误', { modal: true, detail: errors.join('\n') } as MessageOptions);`
`182`	`182`	`}`
`183`	`183`	`};`
`184`	`184`