Skip to content

Commit aea986b

Browse files
committed
Log error in PutObjectAsync and DeleteObjectAsync
1 parent 005a145 commit aea986b

File tree

2 files changed

+21
-5
lines changed

2 files changed

+21
-5
lines changed

src/Api/Bucket/List/ListBucketCommand.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,8 @@ public ListBucketCommand(RequestContext requestContext, string region, ListBucke
1919

2020
public override ServiceRequest BuildRequest()
2121
{
22-
2322
var req = new ServiceRequest(BucketInfo.CreateByRegion(_region, ""), "", HttpMethod.Get);
2423

25-
//
2624
req.AddParameter(RequestParameters.PREFIX, _request.Prefix);
2725
req.AddParameter(RequestParameters.MARKER, _request.Marker);
2826
req.AddParameter(RequestParameters.MAX_KEYS, _request.MaxKeys?.ToString());

src/OssClient.cs

Lines changed: 21 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
using Cuiliang.AliyunOssSdk.Request;
2020
using Cuiliang.AliyunOssSdk.Utility;
2121
using Cuiliang.AliyunOssSdk.Utility.Authentication;
22+
using Microsoft.Extensions.Logging;
2223

2324
namespace Cuiliang.AliyunOssSdk
2425
{
@@ -29,11 +30,13 @@ public class OssClient
2930
{
3031
private readonly HttpClient _client;
3132
private readonly RequestContext _requestContext;
33+
private readonly ILogger _logger;
3234

33-
public OssClient(HttpClient client, RequestContext requestContext)
35+
public OssClient(HttpClient client, RequestContext requestContext, ILoggerFactory loggerFactory)
3436
{
3537
_client = client;
3638
_requestContext = requestContext;
39+
_logger = loggerFactory.CreateLogger<OssClient>();
3740
}
3841

3942
/// <summary>
@@ -57,7 +60,14 @@ public async Task<OssResult<PutObjectResult>> PutObjectAsync(BucketInfo bucket,
5760
{
5861
var cmd = new PutObjectCommand(_requestContext, bucket, key, file, extraHeaders);
5962

60-
return await cmd.ExecuteAsync(_client);
63+
var result = await cmd.ExecuteAsync(_client);
64+
65+
if(!result.IsSuccess)
66+
{
67+
_logger.LogError($"Failed in OssClient.{nameof(PutObjectAsync)}(). \nBucket: {bucket.BucketName}\nPath: {key}");
68+
}
69+
70+
return result;
6171
}
6272

6373
/// <summary>
@@ -187,7 +197,15 @@ public async Task<OssResult<DeleteObjectResult>> DeleteObjectAsync(BucketInfo bu
187197
{
188198
var cmd = new DeleteObjectCommand(_requestContext, bucket, key);
189199

190-
return await cmd.ExecuteAsync(_client);
200+
var result = await cmd.ExecuteAsync(_client);
201+
202+
if (!result.IsSuccess)
203+
{
204+
_logger.LogError($"Failed in OssClient.{nameof(PutObjectAsync)}(). \nBucket: {bucket.BucketName}\nPath: {key}");
205+
}
206+
207+
return result;
208+
191209
}
192210

193211
/// <summary>

0 commit comments

Comments
 (0)