Skip to content

Commit 60c275f

Browse files
authored
feat: Engine CPS (#42)
Making the engine CPS so that it fits properly with the optimizer pub/sub model. This is in fact a simplication of the codebase.
1 parent 03e6b1d commit 60c275f

24 files changed

+3414
-2879
lines changed

optd-core/src/bridge/from_cir.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,7 @@ pub(crate) fn partial_physical_to_value(plan: &PartialPhysicalPlan) -> Value {
5959
}
6060

6161
/// Converts LogicalProperties to a HIR Value representation.
62+
#[allow(dead_code)]
6263
pub(crate) fn logical_properties_to_value(properties: &LogicalProperties) -> Value {
6364
match &properties.0 {
6465
Some(data) => properties_data_to_value(data),

optd-core/src/engine/error.rs

Lines changed: 0 additions & 15 deletions
This file was deleted.

optd-core/src/engine/eval/binary.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ pub(super) fn eval_binary_op(left: Value, op: &BinOp, right: Value) -> Value {
7676
})),
7777

7878
// Any other combination of literal types is not supported
79-
_ => panic!("Type mismatch in binary operation"),
79+
_ => panic!("Invalid binary operation: {:?} {:?} {:?}", left, op, right),
8080
},
8181

8282
// Array concatenation (joins two arrays)

0 commit comments

Comments
 (0)