Skip to content

Commit cff6afb

Browse files
committed
moved default metadata fn to IntegtestWorkspace
1 parent a2287d5 commit cff6afb

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed

env/integtest_pg_conn.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ def setUp(self) -> None:
2323
"Make sure Postgres isn't running before starting the integration test. `pkill postgres` is one way "
2424
+ "to ensure this. Be careful about accidentally taking down other people's Postgres instances though.",
2525
)
26-
self.metadata = MockTuningAgent.get_default_metadata()
26+
self.metadata = IntegtestWorkspace.get_default_metadata()
2727

2828
# The reason we restart Postgres every time is to ensure a "clean" starting point
2929
# so that all tests are independent of each other.

env/integtest_tuning_agent.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ def test_get_metadata(self) -> None:
6565
agent = MockTuningAgent(IntegtestWorkspace.get_dbgym_cfg())
6666
reader = TuningAgentArtifactsReader(agent.tuning_agent_artifacts_dpath)
6767
metadata = reader.get_metadata()
68-
expected_metadata = MockTuningAgent.get_default_metadata()
68+
expected_metadata = IntegtestWorkspace.get_default_metadata()
6969
self.assertEqual(metadata, expected_metadata)
7070

7171

env/integtest_util.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -56,12 +56,6 @@ def get_workspace_path() -> Path:
5656
with open(IntegtestWorkspace.ENV_INTEGTESTS_DBGYM_CONFIG_FPATH) as f:
5757
return Path(yaml.safe_load(f)["dbgym_workspace_path"])
5858

59-
60-
class MockTuningAgent(TuningAgent):
61-
def __init__(self, *args: Any, **kwargs: Any) -> None:
62-
super().__init__(*args, **kwargs)
63-
self.config_to_return: Optional[DBMSConfigDelta] = None
64-
6559
@staticmethod
6660
def get_default_metadata() -> TuningAgentMetadata:
6761
dbgym_cfg = IntegtestWorkspace.get_dbgym_cfg()
@@ -94,8 +88,14 @@ def get_default_metadata() -> TuningAgentMetadata:
9488
),
9589
)
9690

91+
92+
class MockTuningAgent(TuningAgent):
93+
def __init__(self, *args: Any, **kwargs: Any) -> None:
94+
super().__init__(*args, **kwargs)
95+
self.config_to_return: Optional[DBMSConfigDelta] = None
96+
9797
def _get_metadata(self) -> TuningAgentMetadata:
98-
return MockTuningAgent.get_default_metadata()
98+
return IntegtestWorkspace.get_default_metadata()
9999

100100
def _step(self) -> DBMSConfigDelta:
101101
assert self.config_to_return is not None

0 commit comments

Comments
 (0)