dbms integtest now uses intended_dbdata_hardware

Author: wangpatrick57

.github/workflows/tests.yaml

@@ -52,7 +52,7 @@ jobs:
       # Integration tests do require external systems to be running (most commonly a database instance).
       # Unlike end-to-end tests though, they test a specific module in a detailed manner, much like a unit test does.
       env:
-        # We set `INTENDED_DBDATA_HARDWARE` so that it's seen when `integtest_pg_conn.py` executes `_set_up_gymlib_integtest_workspace.sh`.
+        # The CI runs on ssd so we have to set this.
         INTENDED_DBDATA_HARDWARE: ssd
       run: |
         . "$HOME/.cargo/env"

dbms/postgres/cli.py

@@ -171,7 +171,9 @@ def _postgres_dbdata(
             dbdata_parent_path
         ), f"Intended hardware is SSD but dbdata_parent_path ({dbdata_parent_path}) is an HDD"
     else:
-        assert False
+        assert (
+            False
+        ), f'Intended hardware is "{intended_dbdata_hardware}" which is invalid'
 
     # Create dbdata
     _create_dbdata(

dbms/tests/integtest_dbms.py

@@ -1,3 +1,4 @@
+import os
 import shutil
 import unittest
 from pathlib import Path
@@ -54,7 +55,10 @@ def test_postgres_dbdata(self) -> None:
             self.workspace.dbgym_workspace_path, "tpch", scale_factor
         )
         self.assertFalse(dbdata_tgz_path.exists())
-        _postgres_dbdata(self.workspace, "tpch", scale_factor, None, "hdd", None)
+        intended_dbdata_hardware = os.environ.get("INTENDED_DBDATA_HARDWARE", "hdd")
+        _postgres_dbdata(
+            self.workspace, "tpch", scale_factor, None, intended_dbdata_hardware, None
+        )
         self.assertTrue(dbdata_tgz_path.exists())
         self.assertTrue(fully_resolve_path(dbdata_tgz_path).exists())