parameters in ctppsProtonReconstructionSimulationValidator_cfi

[SimaBashiri]

Hi there,

When I'm using Validation/CTPPS/python/ctppsProtonReconstructionSimulationValidator_cfi.py as below, it returns an error:

`import FWCore.ParameterSet.Config as cms

from Configuration.Eras.Era_Run2_2016_cff import *
process = cms.Process('CTPPSTest', Run2_2016)

process.load('SimGeneral.HepPDTESSource.pythiapdt_cfi')
process.load('Validation.CTPPS.ctppsLHCInfoPlotter_cfi')

process.load('Validation.CTPPS.ctppsProtonReconstructionSimulationValidator_cfi')

process.load('Configuration.Generator.randomXiThetaGunProducer_cfi')
process.load("CondCore.CondDB.CondDB_cfi")

minimal logger settings

process.MessageLogger = cms.Service("MessageLogger",
statistics = cms.untracked.vstring(),
destinations = cms.untracked.vstring('cout'),
cout = cms.untracked.PSet(
threshold = cms.untracked.string('WARNING')
)
)

particle generator

process.generator.xi_max = 0.25
process.generator.theta_x_sigma = 60.e-6
process.generator.theta_y_sigma = 60.e-6

default source

process.source = cms.Source("EmptySource",
firstRun = cms.untracked.uint32(1),
)

process.CondDB.connect = 'frontier://FrontierProd/CMS_CONDITIONS'
process.PoolDBESSource = cms.ESSource("PoolDBESSource",
process.CondDB,
toGet = cms.VPSet(cms.PSet(
record = cms.string('CTPPSPixelAnalysisMaskRcd'),
tag = cms.string("CTPPSPixelAnalysisMask_Run3_v1_hlt"))
))

random seeds

process.RandomNumberGeneratorService = cms.Service("RandomNumberGeneratorService",
sourceSeed = cms.PSet(initialSeed = cms.untracked.uint32(98765)),
generator = cms.PSet(initialSeed = cms.untracked.uint32(98766)),
beamDivergenceVtxGenerator = cms.PSet(initialSeed = cms.untracked.uint32(3849)),
ppsDirectProtonSimulation = cms.PSet(initialSeed = cms.untracked.uint32(4981))
)

number of events

process.maxEvents = cms.untracked.PSet(
input = cms.untracked.int32(int(4E5))
)

process.load('SimPPS.DirectSimProducer.simPPS2016_cfi')

from Validation.CTPPS.ctppsProtonReconstructionSimulationValidator_cfi import ctppsProtonReconstructionSimulationValidator

ctppsProtonReconstructionSimulationValidator.tagRecoProtonsSingleRP = cms.InputTag("ctppsProtons", "singleRP")

ctppsProtonReconstructionSimulationValidator.tagRecoProtonsMultiRP = cms.InputTag("ctppsProtons", "multiRP")

ctppsProtonReconstructionSimulationValidator.tagHepMCBeforeSmearing = cms.InputTag("generator")

ctppsProtonReconstructionSimulationValidator.tagHepMCAfterSmearing = cms.InputTag("smearingGenerator")

ctppsProtonReconstructionSimulationValidator.outputFile = "ctpps_validation.root"

# reconstruction validation

process.ctppsProtonReconstructionSimulationValidator = cms.EDAnalyzer("CTPPSProtonReconstructionSimulationValidator",

tagHepMCBeforeSmearing = cms.InputTag("generator", "unsmeared"),

tagHepMCAfterSmearing = cms.InputTag("beamDivergenceVtxGenerator"),

tagRecoProtonsSingleRP = cms.InputTag("ctppsProtons", "singleRP"),

tagRecoProtonsMultiRP = cms.InputTag("ctppsProtons", "multiRP"),

lhcInfoLabel = cms.string(""),

outputFile = cms.string("")

)

process.ctppsProtons.opticsLabel = "modified"

process.generation = cms.Path(process.generator)

process.validation = cms.Path(

process.ctppsProtonReconstructionSimulationValidator

)

processing path

process.schedule = cms.Schedule(
process.generation,
process.validation
)

from SimPPS.Configuration.Utils import setupPPSDirectSim
setupPPSDirectSim(process)

process.ctppsBeamParametersFromLHCInfoESSource.vtxOffsetX45 = 0.
process.ctppsBeamParametersFromLHCInfoESSource.vtxOffsetY45 = 0.
process.ctppsBeamParametersFromLHCInfoESSource.vtxOffsetZ45 = 0.
process.source.numberEventsInLuminosityBlock = process.ctppsCompositeESSource.generateEveryNEvents
`

----- Begin Fatal Exception 16-Oct-2025 22:18:51 CEST-----------------------
An exception of category 'Configuration' occurred while
[0] Constructing the EventProcessor
[1] Constructing module: class=CTPPSProtonReconstructionSimulationValidator label='ctppsProtonReconstructionSimulationValidator'
Exception Message:
MissingParameter: Parameter 'tagHepMCBeforeSmearing' not found.
----- End Fatal Exception -------------------------------------------------

And when I uncomment these lines, the error message says that the parameters are illegal.

`# ctppsProtonReconstructionSimulationValidator.tagRecoProtonsSingleRP = cms.InputTag("ctppsProtons", "singleRP")

ctppsProtonReconstructionSimulationValidator.tagRecoProtonsMultiRP = cms.InputTag("ctppsProtons", "multiRP")

ctppsProtonReconstructionSimulationValidator.tagHepMCBeforeSmearing = cms.InputTag("generator")

ctppsProtonReconstructionSimulationValidator.tagHepMCAfterSmearing = cms.InputTag("smearingGenerator")

ctppsProtonReconstructionSimulationValidator.outputFile = "ctpps_validation.root"`

could you please help about this issue.

Best regards
Sima

[cmsbuild]

cms-bot internal usage

[cmsbuild]

A new Issue was created by @SimaBashiri.

@Dr15Jones, @ftenchini, @makortel, @mandrenguyen, @sextonkennedy, @smuzaffar can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

[SimaBashiri]

the config file i'm using can be found here:
https://gitlab.cern.ch/sibashir/proton_simulation_validation_update/-/blob/master/config.py

[makortel]

assign Validation/CTPPS

[makortel]

@cms-sw/ctpps-dpg-l2

[cmsbuild]

New categories assigned: dqm

@ctarricone,@gabrielmscampos,@nothingface0,@rseidita you have been requested to review this Pull request/Issue and eventually sign? Thanks

[Dr15Jones]

The problem is the module does require that parameter as it has the call

cmssw/Validation/CTPPS/plugins/CTPPSProtonReconstructionSimulationValidator.cc

Line 201 in 36dd114

consumes<edm::HepMCProduct>(iConfig.getParameter<edm::InputTag>("tagHepMCBeforeSmearing"))),

but it also has a fillDescriptions method (which the framework uses to validate a configuration passed to the module) and that method does not include that parameter (plus several other parameters required are also missing).

cmssw/Validation/CTPPS/plugins/CTPPSProtonReconstructionSimulationValidator.cc

Lines 216 to 229 in 36dd114

	void CTPPSProtonReconstructionSimulationValidator::fillDescriptions(edm::ConfigurationDescriptions &descriptions) {
	edm::ParameterSetDescription desc;
	desc.add<std::string>("lhcInfoLabel", "")->setComment("label of the LHCInfo record");
	desc.add<std::string>("lhcInfoPerLSLabel", "")->setComment("label of the LHCInfoPerLS record");
	desc.add<std::string>("lhcInfoPerFillLabel", "")->setComment("label of the LHCInfoPerFill record");
	desc.add<bool>("useNewLHCInfo", false)->setComment("flag whether to use new LHCInfoPer* records or old LHCInfo");
	desc.add<std::string>("outputFile", "output.root")->setComment("output file name");
	desc.addUntracked<unsigned int>("verbosity", 0)->setComment("verbosity level");
	descriptions.add("ctppsProtonReconstructionSimulationValidatorDefault", desc);
	}

The fix is to update fillDescriptions so it adds all the parameters.