Skip to content

Commit c48c6c1

Browse files
committed
gui code tidy
1 parent dedf6ff commit c48c6c1

File tree

2 files changed

+21
-13
lines changed

2 files changed

+21
-13
lines changed

getdist/gui/SyntaxHighlight.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,9 @@
33
from PySide6.QtGui import QColor, QTextCharFormat, QFont, QSyntaxHighlighter
44

55
except ImportError:
6-
6+
# noinspection PyUnresolvedReferences
77
from PySide2.QtCore import QRegularExpression
8+
# noinspection PyUnresolvedReferences
89
from PySide2.QtGui import QColor, QTextCharFormat, QFont, QSyntaxHighlighter
910

1011

getdist/gui/mainwindow.py

Lines changed: 19 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626

2727
except:
2828
matplotlib.use('Qt5Agg')
29+
# noinspection PyUnresolvedReferences
2930
from PySide2 import QtCore
3031
except ImportError as _e:
3132
if 'DLL load failed' in str(_e):
@@ -60,9 +61,13 @@
6061
QSplitter, QHBoxLayout, QToolBar, QPlainTextEdit, QScrollArea, QFileDialog, QMessageBox, QTableWidgetItem, \
6162
QLabel, QTableWidget, QListWidgetItem, QTextEdit, QDialogButtonBox
6263
except ImportError:
64+
# noinspection PyUnresolvedReferences
6365
import PySide2 as PySide
66+
# noinspection PyUnresolvedReferences
6467
from PySide2.QtGui import QIcon, QKeySequence, QFont, QTextOption, QPixmap, QImage
68+
# noinspection PyUnresolvedReferences
6569
from PySide2.QtCore import Qt, SIGNAL, QSize, QSettings, QCoreApplication, QPoint
70+
# noinspection PyUnresolvedReferences
6671
from PySide2.QtWidgets import QListWidget, QMainWindow, QDialog, QApplication, QAbstractItemView, \
6772
QTabWidget, QWidget, QComboBox, QPushButton, QCheckBox, QRadioButton, QGridLayout, QVBoxLayout, \
6873
QSplitter, QHBoxLayout, QToolBar, QPlainTextEdit, QScrollArea, QFileDialog, QMessageBox, QTableWidgetItem, \
@@ -135,6 +140,7 @@ def __init__(self, app, ini=None, base_dir=None, plot_scale=1):
135140
self.setWindowIcon(self._icon('Icon', False))
136141

137142
if base_dir is None and batchjob:
143+
# noinspection PyUnresolvedReferences
138144
base_dir = batchjob.getCodeRootPath()
139145
if base_dir:
140146
os.chdir(base_dir)
@@ -414,7 +420,7 @@ def _createWidgets(self):
414420
self.pushButtonRemove.setToolTip("Remove a chain root")
415421
self.pushButtonRemove.setEnabled(False)
416422
self.pushButtonRemove.setMaximumWidth(30 * self.dpiScale())
417-
self.connect(self.pushButtonRemove, SIGNAL("clicked()"), self.removeRoot)
423+
self.pushButtonRemove.clicked.connect(self.removeRoot)
418424

419425
self.comboBoxParamTag = QComboBox(self.selectWidget)
420426
self.comboBoxParamTag.clear()
@@ -430,23 +436,23 @@ def _createWidgets(self):
430436

431437
self.listParametersX = QListWidget(self.selectWidget)
432438
self.listParametersX.clear()
433-
self.connect(self.listParametersX, SIGNAL("itemChanged(QListWidgetItem *)"), self.itemCheckChange)
439+
self.listParametersX.itemChanged.connect(self.itemCheckChange)
434440

435441
self.listParametersY = QListWidget(self.selectWidget)
436442
self.listParametersY.clear()
437-
self.connect(self.listParametersY, SIGNAL("itemChanged(QListWidgetItem *)"), self.itemCheckChange)
443+
self.listParametersY.itemChanged.connect(self.itemCheckChange)
438444

439445
self.selectAllX = QCheckBox("Select All", self.selectWidget)
440446
self.selectAllX.setCheckState(Qt.Unchecked)
441-
self.connect(self.selectAllX, SIGNAL("clicked()"), self.statusSelectAllX)
447+
self.selectAllX.clicked.connect(self.statusSelectAllX)
442448

443449
self.selectAllY = QCheckBox("Select All", self.selectWidget)
444450
self.selectAllY.setCheckState(Qt.Unchecked)
445-
self.connect(self.selectAllY, SIGNAL("clicked()"), self.statusSelectAllY)
451+
self.selectAllX.clicked.connect(self.statusSelectAllY)
446452

447453
self.toggleFilled = QRadioButton("Filled")
448454
self.toggleLine = QRadioButton("Line")
449-
self.connect(self.toggleLine, SIGNAL("toggled(bool)"), self.statusPlotType)
455+
self.toggleLine.toggled.connect(self.statusPlotType)
450456

451457
self.checkShade = QCheckBox("Shaded", self.selectWidget)
452458
self.checkShade.setEnabled(False)
@@ -456,14 +462,14 @@ def _createWidgets(self):
456462
self.checkInsideLegend.setVisible(False)
457463

458464
self.toggleColor = QRadioButton("Color by:")
459-
self.connect(self.toggleColor, SIGNAL("toggled(bool)"), self.statusPlotType)
465+
self.toggleColor.toggled.connect(self.statusPlotType)
460466

461467
self.comboBoxColor = QComboBox(self)
462468
self.comboBoxColor.clear()
463469
self.comboBoxColor.setEnabled(False)
464470

465471
self.toggleZ = QRadioButton("Z-axis:", self.selectWidget)
466-
self.connect(self.toggleZ, SIGNAL("toggled(bool)"), self.statusPlotType)
472+
self.toggleZ.toggled.connect(self.statusPlotType)
467473
self.comboBoxZ = QComboBox(self)
468474
self.comboBoxZ.clear()
469475
self.comboBoxZ.setEnabled(False)
@@ -476,10 +482,10 @@ def _createWidgets(self):
476482

477483
self.trianglePlot = QCheckBox("Triangle Plot", self.selectWidget)
478484
self.trianglePlot.setCheckState(Qt.Unchecked)
479-
self.connect(self.trianglePlot, SIGNAL("toggled(bool)"), self.statusTriangle)
485+
self.trianglePlot.toggled.connect(self.statusTriangle)
480486

481487
self.pushButtonPlot = QPushButton("Make plot", self.selectWidget)
482-
self.connect(self.pushButtonPlot, SIGNAL("clicked()"), self.plotData)
488+
self.pushButtonPlot.clicked.connect(self.plotData)
483489

484490
def h_stack(*items):
485491
widget = QWidget(self.selectWidget)
@@ -583,9 +589,9 @@ def h_stack(*items):
583589

584590
self.pushButtonPlot2 = QPushButton("Make plot", self.editWidget)
585591
self.pushButtonPlot2.setToolTip("Ctrl+Return")
586-
self.connect(self.pushButtonPlot2, SIGNAL("clicked()"), self.plotData2)
592+
self.pushButtonPlot2.clicked.connect(self.plotData2)
587593
shortcut = QShortcut(QKeySequence(self.tr("Ctrl+Return")), self)
588-
self.connect(shortcut, SIGNAL("activated()"), self.plotData2)
594+
shortcut.activated.connect(self.plotData2)
589595

590596
layoutEdit = QVBoxLayout()
591597
layoutEdit.addWidget(self.toolBar)
@@ -752,6 +758,7 @@ def reLoad(self):
752758
adir = self.getSettings().value('lastSearchDirectory')
753759
if adir:
754760
if batchjob:
761+
# noinspection PyUnresolvedReferences
755762
batchjob.resetGrid(adir)
756763
self.openDirectory(adir)
757764
if self.plotter:

0 commit comments

Comments
 (0)