Skip to content

Commit 6192657

Browse files
Merge pull request #2 from Xtansia/master
Fix error when a boost repo tag isn't a valid semver
2 parents fc03078 + 157d469 commit 6192657

File tree

2 files changed

+11
-6
lines changed

2 files changed

+11
-6
lines changed

lib/boostDownloader.js

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -113,11 +113,16 @@ BoostDownloader.prototype._download = function () {
113113
var parts = line.split(/\s+/);
114114
if (parts.length === 2) {
115115
var relVersion = parts[1].substr("refs/tags/boost-".length);
116-
self.log.verbose("BOOST", "Comparing version: " + relVersion);
117-
if (semver.satisfies(relVersion, self.version)) {
118-
self.log.verbose("BOOST", "Version OK.");
119-
downloadVersion = relVersion;
120-
return false;
116+
117+
// Fix error when a tag is not a valid semver, by validating first
118+
var sv = semver.valid(relVersion);
119+
if (sv) {
120+
self.log.verbose("BOOST", "Comparing version: " + relVersion);
121+
if (semver.satisfies(sv, self.version)) {
122+
self.log.verbose("BOOST", "Version OK.");
123+
downloadVersion = relVersion;
124+
return false;
125+
}
121126
}
122127
}
123128
});

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "boost-lib",
3-
"version": "0.11.0",
3+
"version": "0.11.1",
44
"description": "Boost dependency manager for CMake.js based native modules",
55
"license": "MIT",
66
"keywords": [

0 commit comments

Comments
 (0)