chore: add names to controllers (#5641)

Controller-runtime v0.19.0 errors when a controller manager detects
multiple controllers with the same name; this is done to improve the
clarity of the log messages.

This patch adds a name for every controller in the operator, complying
with this rule.

For more information, see kubernetes-sigs/controller-runtime#2902

Closes #5640

Signed-off-by: Jonathan Gonzalez V. <jonathan.gonzalez@enterprisedb.com>
Signed-off-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com>
Co-authored-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com>
(cherry picked from commit 6e28aa8)

Author: sxd

internal/cmd/manager/instance/run/cmd.go

@@ -162,6 +162,7 @@ func runSubCommand(ctx context.Context, instance *postgres.Instance) error {
 	reconciler := controller.NewInstanceReconciler(instance, mgr.GetClient(), metricsServer)
 	err = ctrl.NewControllerManagedBy(mgr).
 		For(&apiv1.Cluster{}).
+		Named("instance-cluster").
 		Complete(reconciler)
 	if err != nil {
 		setupLog.Error(err, "unable to create controller")

internal/controller/backup_controller.go

@@ -633,6 +633,7 @@ func (r *BackupReconciler) SetupWithManager(ctx context.Context, mgr ctrl.Manage
 
 	controllerBuilder := ctrl.NewControllerManagedBy(mgr).
 		For(&apiv1.Backup{}).
+		Named("backup").
 		Watches(&apiv1.Cluster{},
 			handler.EnqueueRequestsFromMapFunc(r.mapClustersToBackup()),
 			builder.WithPredicates(clustersWithBackupPredicate),

internal/controller/cluster_controller.go

@@ -860,6 +860,7 @@ func (r *ClusterReconciler) SetupWithManager(ctx context.Context, mgr ctrl.Manag
 
 	return ctrl.NewControllerManagedBy(mgr).
 		For(&apiv1.Cluster{}).
+		Named("cluster").
 		Owns(&corev1.Pod{}).
 		Owns(&batchv1.Job{}).
 		Owns(&corev1.Service{}).

internal/controller/pooler_controller.go

@@ -129,6 +129,7 @@ func (r *PoolerReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctr
 func (r *PoolerReconciler) SetupWithManager(mgr ctrl.Manager) error {
 	return ctrl.NewControllerManagedBy(mgr).
 		For(&apiv1.Pooler{}).
+		Named("pooler").
 		Owns(&v1.Deployment{}).
 		Owns(&corev1.Service{}).
 		Owns(&corev1.ServiceAccount{}).

internal/controller/scheduledbackup_controller.go

@@ -353,5 +353,6 @@ func (r *ScheduledBackupReconciler) SetupWithManager(ctx context.Context, mgr ct
 
 	return ctrl.NewControllerManagedBy(mgr).
 		For(&apiv1.ScheduledBackup{}).
+		Named("scheduled-backup").
 		Complete(r)
 }

internal/management/controller/externalservers/manager.go

@@ -46,6 +46,7 @@ func NewReconciler(instance *postgres.Instance, client client.Client) *Reconcile
 func (r *Reconciler) SetupWithManager(mgr ctrl.Manager) error {
 	return ctrl.NewControllerManagedBy(mgr).
 		For(&apiv1.Cluster{}).
+		Named("instance-external-server").
 		Complete(r)
 }
 

internal/management/controller/tablespaces/manager.go

@@ -47,6 +47,7 @@ func NewTablespaceReconciler(instance *postgres.Instance, client client.Client)
 func (r *TablespaceReconciler) SetupWithManager(mgr ctrl.Manager) error {
 	return ctrl.NewControllerManagedBy(mgr).
 		For(&apiv1.Cluster{}).
+		Named("instance-tablespaces").
 		Complete(r)
 }