feat: Moved prepareMutations logic to DgraphDataProcessor

Author: Marco Franceschi

src/plugins/policyPack/index.ts

@@ -263,6 +263,8 @@ export default class PolicyPackPlugin extends Plugin {
       schemaMap?: SchemaMap
     }) => void
   }): Promise<any> {
+    console.log('storage type', typeof storageEngine, storageEngine)
+
     !isEmpty(this.policyPacksPlugins) &&
       this.logger.info(
         `Beginning ${chalk.italic.green('RULES')} for ${this.provider.name}`

src/rules-engine/index.ts

@@ -167,6 +167,8 @@ export default class RulesProvider implements Engine {
     return [mainType, extensions]
   }
 
+  prepareMutations: (findings: RuleFinding[]) => Entity[]
+
   processRule = async (rule: Rule, data: unknown): Promise<RuleFinding[]> => {
     const res: any[] = []
     const dedupeIds = {}

tests/evaluators/js-evaluator.test.ts

@@ -3,8 +3,6 @@ import { Result } from '../../src'
 import JsEvaluator from '../../src/rules-engine/evaluators/js-evaluator'
 import { Severity } from '../../src/rules-engine/types'
 
-const providerName = 'azure'
-const entityName = 'CIS'
 const jsRule = {
   id: cuid(),
   description: 'none',
@@ -32,7 +30,7 @@ export default {
 describe('JsEvaluator', () => {
   let evaluator
   beforeEach(() => {
-    evaluator = new JsEvaluator(providerName, entityName)
+    evaluator = new JsEvaluator()
   })
 
   it('should accept all rules that have a check field', () => {
@@ -68,25 +66,4 @@ describe('JsEvaluator', () => {
     )
     expect(passedRule.result).toEqual(Result.PASS)
   })
-
-  it('should return a processed rules mutations array', async () => {
-    const resourceId = cuid()
-    const resourceType = 'schemaA'
-    await evaluator.evaluateSingleResource(jsRule, {
-      resource: {
-        id: resourceId,
-        __typename: resourceType,
-        value: 'automated',
-      },
-    })
-    const mutations = evaluator.prepareMutations()
-    const [atuomatedMutation] = mutations
-
-    expect(mutations.length).toBe(1)
-    expect(atuomatedMutation).toBeDefined()
-    expect(atuomatedMutation.data instanceof Object).toBeTruthy()
-    expect(atuomatedMutation.data.filter.id.eq).toBe(resourceId)
-    expect(atuomatedMutation.name).toBe(`${providerName}${entityName}Findings`)
-    expect(atuomatedMutation.mutation).toContain(`update${resourceType}`)
-  })
 })

tests/evaluators/json-evaluator.test.ts

@@ -3,8 +3,6 @@ import { Result } from '../../src'
 import JsonEvaluator from '../../src/rules-engine/evaluators/json-evaluator'
 import { Severity } from '../../src/rules-engine/types'
 
-const providerName = 'aws'
-const entityName = 'CIS'
 const ruleMetadata = {
   id: cuid(),
   description: 'none',
@@ -73,7 +71,7 @@ export default {
 describe('JsonEvaluator', () => {
   let evaluator
   beforeEach(() => {
-    evaluator = new JsonEvaluator(providerName, entityName)
+    evaluator = new JsonEvaluator()
   })
 
   test('should accept all rules that have a conditions field', () => {

tests/evaluators/manual-evaluator.test.ts

@@ -3,8 +3,6 @@ import { Result } from '../../src'
 import ManualEvaluator from '../../src/rules-engine/evaluators/manual-evaluator'
 import { Severity } from '../../src/rules-engine/types'
 
-const providerName = 'gcp'
-const entityName = 'CIS'
 const manualRule = {
   id: cuid(),
   description: 'none',
@@ -22,7 +20,7 @@ export default {
 describe('ManualEvaluator', () => {
   let evaluator
   beforeEach(() => {
-    evaluator = new ManualEvaluator(providerName, entityName)
+    evaluator = new ManualEvaluator()
   })
 
   it('should pass when it does not contain gql, conditions, check, and resource fields', () => {
@@ -57,17 +55,4 @@ describe('ManualEvaluator', () => {
     )
     expect(finding.id.includes('manual')).toEqual(true)
   })
-
-  it('should return a manual mutations array', async () => {
-    await evaluator.evaluateSingleResource(manualRule)
-    const mutations = evaluator.prepareMutations()
-    const [manualMutation] = mutations
-
-    expect(mutations.length).toBe(1)
-    expect(manualMutation.name).toBe(`${providerName}${entityName}Findings`)
-    expect(manualMutation.data.length).toBe(1)
-    expect(manualMutation.mutation).toContain(
-      `add${providerName}${entityName}Findings`
-    )
-  })
 })

tests/operators/date.test.ts

@@ -5,7 +5,7 @@ import JsonEvaluator from '../../src/rules-engine/evaluators/json-evaluator'
 describe('Date Operators', () => {
   let evaluator
   beforeEach(() => {
-    evaluator = new JsonEvaluator('aws', 'CIS')
+    evaluator = new JsonEvaluator()
   })
 
   test('should process dates', async () => {